Re: [jclouds] JCLOUDS-365: ChefSolo should not depend on InstallChefGems (#196)

2013-11-11 Thread Ignasi Barrera
Sure @demobox! It is worth adding a command existence check before running the script. Will update the PR today (I hope). --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/196#issuecomment-28216000

Re: [jclouds] JCLOUDS-365: ChefSolo should not depend on InstallChefGems (#196)

2013-11-11 Thread Andrew Phillips
Looks good - please squash'n'rebase! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/196#issuecomment-28258037

Re: [jclouds] JCLOUDS-365: ChefSolo should not depend on InstallChefGems (#196)

2013-11-08 Thread Andrew Phillips
Should we have some kind of prerequisite check here, or will things fail with an obvious error message if we try to run Solo _without_ Chef now? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/196#issuecomment-28088996

Re: [jclouds] JCLOUDS-365: ChefSolo should not depend on InstallChefGems (#196)

2013-11-08 Thread Ignasi Barrera
This is something that will fail when running the bootstrap script with a `Command not found: chef-solo`. The prerequisite is to have Chef installed (via the gem or the Omnibus installer), but I think that should not be a precondition of the script, as the image being deployed could already

Re: [jclouds] JCLOUDS-365: ChefSolo should not depend on InstallChefGems (#196)

2013-11-08 Thread Noorul Islam K M
I see a positive use case here https://gist.github.com/nacx/7317938 I think the purpose of the patch is to make ChefSolo statement independent of Chef installation. If ChefSolo statement is already being consumed by someone and assumes that it takes care of installing Chef then that will be

Re: [jclouds] JCLOUDS-365: ChefSolo should not depend on InstallChefGems (#196)

2013-11-08 Thread Ignasi Barrera
If ChefSolo statement is already being consumed by someone and assumes that it takes care of installing Chef then that will be broken now. Apart from that I don't see a problem. The workaround is trivial, just adding declare the InstallChefGems to the script, so I think we can just ignore

Re: [jclouds] JCLOUDS-365: ChefSolo should not depend on InstallChefGems (#196)

2013-11-08 Thread Andrew Phillips
This is something that will fail when running the bootstrap script with a `Command not found: chef-solo.` OK. I think that should be fine, but would it be easy to amend that to add something like Unable to find chef-solo -please install Chef? --- Reply to this email directly or view it on