Re: [jclouds-labs] Added a new predicate to capture disk links (#32)

2013-11-07 Thread Andrew Phillips
+1 - looks good to me! Thanks, @carlosgarciaibanez and @nacx! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/32#issuecomment-27960195

Re: [jclouds-labs] Added a new predicate to capture disk links (#32)

2013-11-07 Thread Andrew Phillips
Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds-labs.git;a=commit;h=d9717a432fcd1a2512f4a5d121b9454822f928e7) under [JCLOUDS-369](https://issues.apache.org/jira/browse/JCLOUDS-369) --- Reply to this email directly or view it on GitHub:

Re: [jclouds-labs] Added a new predicate to capture disk links (#32)

2013-11-06 Thread CloudBees pull request builder plugin
[jclouds-labs-pull-requests #80](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/80/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/32#issuecomment-27941871

[jclouds-labs] Added a new predicate to capture disk links (#32)

2013-11-05 Thread Carlos García Ibáñez
A new static method has been added to the LinkPredicates utility class to create predicate which determines whether a given REST link refers to a disk entity. You can merge this Pull Request by running: git pull https://github.com/carlosgarciaibanez/jclouds-labs master Or you can view,

Re: [jclouds-labs] Added a new predicate to capture disk links (#32)

2013-11-05 Thread Ignasi Barrera
Could you rebase your branch to the latest master version? Now the repo has been synched with the ASF one, and your PR should contain only the commit that adds the predicate. --- Reply to this email directly or view it on GitHub:

Re: [jclouds-labs] Added a new predicate to capture disk links (#32)

2013-11-05 Thread CloudBees pull request builder plugin
[jclouds-labs-pull-requests #76](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/76/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/32#issuecomment-27760442

Re: [jclouds-labs] Added a new predicate to capture disk links (#32)

2013-11-05 Thread Ignasi Barrera
Yes, it looks good. Thanks! To avoid getting in trouble with the master branch sync, when contributing it is highly recommended that you develop the changes in a specific branch, and send the PR from your branch to our master branch. This way you have the master branch clean and you can use it