Squash-n-rebase done, @demobox. Thanks for reviewing :smiley:
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/33#issuecomment-28186914
[jclouds-labs-pull-requests
#85](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/85/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/33#issuecomment-28187335
return input.get() != null;
}
}, operationCompleteCheckTimeout, operationCompleteCheckInterval,
MILLISECONDS).apply(instance);
}
- InstanceInZone instanceInZone = new InstanceInZone(instance.get(),
template.getLocation().getId());
+
+ */
+package org.jclouds.googlecomputeengine.compute.functions;
+
+import com.google.common.base.Predicate;
+import org.jclouds.compute.functions.GroupNamingConvention;
+
+import javax.inject.Inject;
+
+/**
+ * The convention for naming instance tags that firewall rules recognise.
+ *
- retry(operationDonePredicate, operationCompleteCheckTimeout,
operationCompleteCheckInterval,
- MILLISECONDS).apply(operation);
-
- checkState(!operation.get().getHttpError().isPresent(), Could not
create firewall, operation failed + operation);
+
Thanks @demobox, I think I've gone through all of your review comments, with
the exception of the failure-cleanup question. Any more comments at this stage?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/33#issuecomment-28069473
[jclouds-labs-pull-requests
#84](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/84/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/33#issuecomment-28069826
return input.get() != null;
}
}, operationCompleteCheckTimeout, operationCompleteCheckInterval,
MILLISECONDS).apply(instance);
}
- InstanceInZone instanceInZone = new InstanceInZone(instance.get(),
template.getLocation().getId());
+
- retry(operationDonePredicate, operationCompleteCheckTimeout,
operationCompleteCheckInterval,
- MILLISECONDS).apply(operation);
-
- checkState(!operation.get().getHttpError().isPresent(), Could not
create firewall, operation failed + operation);
+
@@ -266,6 +266,12 @@ public static IPProtocol fromValue(String protocol) {
private final IPProtocol ipProtocol;
private final RangeSetInteger ports;
+ /* Some handy shortcuts */
+ public static Rule permitTcpRule(Integer start, Integer end) { return
The inboundPort settings of the first node in the group dictated the firewall
configuration. Subsequent nodes added to the group had their inboundPort
settings ignored.
GCE firewalls specify their quot;targetquot; (VM instances) by means of tags
- if a targetTag on a firewall matches the tag
[jclouds-labs-pull-requests
#82](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/82/)
UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/33#issuecomment-27974025
[jclouds-labs-pull-requests
#83](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/83/)
UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/33#issuecomment-27989047
- if (operation.get().getHttpError().isPresent()) {
- HttpResponse response = operation.get().getHttpError().get();
- logger.warn(delete orphaned firewall failed. Http Error Code: +
response.getStatusCode() +
- HttpError: + response.getMessage());
@@ -108,6 +114,7 @@ public
GoogleComputeEngineServiceAdapter(GoogleComputeEngineApi api,
operationCompleteCheckInterval, TimeUnit.MILLISECONDS);
this.zones = checkNotNull(zones, zones);
this.hardwareMap = checkNotNull(hardwareMap, hardwareMap);
+
@@ -116,6 +123,8 @@ public
GoogleComputeEngineServiceAdapter(GoogleComputeEngineApi api,
checkNotNull(template, template);
+ final InstanceApi instanceApi =
api.getInstanceApiForProject(userProject.get());
+
Get `instanceApi` down where it's used?
---
Reply to this
@@ -166,14 +176,28 @@ public boolean apply(AtomicReferenceInstance input) {
retry(new PredicateAtomicReferenceInstance() {
@Override
public boolean apply(AtomicReferenceInstance input) {
-
+ */
+package org.jclouds.googlecomputeengine.compute.functions;
+
+import com.google.common.base.Predicate;
+import org.jclouds.compute.functions.GroupNamingConvention;
+
+import javax.inject.Inject;
+
+/**
+ * The convention for naming instance tags that firewall rules recognise.
+ *
18 matches
Mail list logo
