Re: [jclouds-labs-openstack] Adds support for Swift Object copy (#73)

2014-01-07 Thread Andrew Phillips
private String name = getClass().getSimpleName(); private String containerName = getClass().getSimpleName() + Container; + + public void copy() throws Exception { I personally am not a fan of `testX` names for tests, but that seems to be what we mainly use in jclouds. So

Re: [jclouds-labs-openstack] Adds support for Swift Object copy (#73)

2014-01-07 Thread Andrew Phillips
+ // Create the destination object + assertNotNull(destApi.replace(destinationObject, data, ImmutableMap.String, String of())); + object = destApi.get(destinationObject, GetOptions.NONE); + checkObject(destApi.get(destinationObject, GetOptions.NONE)); + +

Re: [jclouds-labs-openstack] Adds support for Swift Object copy (#73)

2014-01-07 Thread Andrew Phillips
+ checkObject(destApi.get(destinationObject, GetOptions.NONE)); + + // check the copy operation + assertTrue(destApi.copy(destinationObject, sourceContainer, sourceObject)); + assertNotNull(destApi.head(destinationObject)); + + // now get

Re: [jclouds-labs-openstack] Adds support for Swift Object copy (#73)

2014-01-07 Thread Andrew Phillips
+ assertTrue(api.objectApiInRegionForContainer(DFW, destinationContainer) +.copy(destinationObject, sourceContainer, sourceObject)); + + assertEquals(server.getRequestCount(), 2); + assertEquals(server.takeRequest().getRequestLine(), POST

Re: [jclouds-labs-openstack] Adds support for Swift Object copy (#73)

2014-01-07 Thread Andrew Phillips
public class BaseSwiftApiLiveTest extends BaseApiLiveTestSwiftApi { + protected SetString regions = Sets.newHashSet(); Leave uninitialized here and assign below? --- Reply to this email directly or view it on GitHub:

Re: [jclouds-labs-openstack] Adds support for Swift Object copy (#73)

2014-01-07 Thread Andrew Phillips
public BaseSwiftApiLiveTest() { provider = openstack-swift; } + @BeforeClass + public void setupRegions() { + String key = test. + provider + .region; + + if (System.getProperties().containsKey(key)) { + regions.add(System.getProperty(key)); +

Re: [jclouds-labs-openstack] Adds support for Swift Object copy (#73)

2014-01-07 Thread Andrew Phillips
Thanks, @jdaggett! Main comment is 3rd vs. 2nd person usage in Javadocs, I guess - otherwise just a couple of small things. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/73#issuecomment-31789253

Re: [jclouds-labs-openstack] Renames multiple domain classes for consistency (#74)

2014-01-07 Thread Andrew Phillips
* @author Zack Shoylev */ -public class Webhook { - private final String name; - private final ImmutableMapString, Object metadata; - - @ConstructorProperties({ name, metadata }) - protected Webhook(String name, @Nullable MapString, Object metadata) { - this.name =

Re: [jclouds-labs-openstack] Renames multiple domain classes for consistency (#74)

2014-01-07 Thread Andrew Phillips
Just briefly scanned through this - I trust the refactoring tool ;-) A couple of minors, otherwise +1 from me if the PR builders look happy. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/74#issuecomment-31789493

Re: [jclouds-examples] Updated .gitignore to ignore Mac OS specific files (#29)

2014-01-07 Thread Andrew Phillips
Not sure why the PR builders didn't trigger on this one. Could you squash the two commits? That should hopefully kick them off. Otherwise, +1 from me - thanks, @jdaggett! --- Reply to this email directly or view it on GitHub:

Re: [jclouds-site] specifying wire and header log appender names explicitly. (#46)

2014-01-07 Thread Andrew Phillips
@nirmal070125: ping? Or would it be easier if I simply applied this as a patch..? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/46#issuecomment-31791789

Re: [jclouds-site] Rebranding proposal (#51)

2014-01-07 Thread Andrew Phillips
So this is what comes to my mind when thinking about what I'd want to have before publishing the new site. WDYT? Any reason to wait before all this is done before merging the landing page? Obviously, if you think this can be finished relatively quickly, sure...but I think it would be great

Re: [jclouds] JCLOUDS-416. Add TemplateOptions#networks. (#246)

2014-01-07 Thread Andrew Phillips
@@ -468,4 +492,21 @@ public CloudStackTemplateOptions userMetadata(String key, String value) { public CloudStackTemplateOptions nodeNames(IterableString nodeNames) { return CloudStackTemplateOptions.class.cast(super.nodeNames(nodeNames)); } + + /** +* {@inheritDoc}

Re: [jclouds] JCLOUDS-416. Add TemplateOptions#networks. (#246)

2014-01-07 Thread Andrew Phillips
@@ -43,8 +40,8 @@ public DeployVirtualMachineOptions apply(CloudStackTemplateOptions templateOptio // at least one network must be given to CloudStack, // but jclouds will try to autodetect an appropriate network if none given.

Re: [jclouds] JCLOUDS-416. Add TemplateOptions#networks. (#246)

2014-01-07 Thread Andrew Phillips
@@ -196,4 +190,11 @@ public void testNodeNames() { TemplateOptions options = nodeNames(nodeNames); assertTrue(options.getNodeNames().containsAll(nodeNames)); } + + @Test + public void testNetworks() { + SetString networks = ImmutableSet.of(first-network,

Re: [jclouds-examples] Updated .gitignore to ignore Mac OS specific files (#29)

2014-01-08 Thread Andrew Phillips
@demobox Squashed and pushed, now crossing fingers! ;) No need to cross fingers - it's the jclouds-examples repo...didn't see that. @jdaggett: intentional? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/29#issuecomment-31820389

Re: [jclouds-site] specifying wire and header log appender names explicitly. (#46)

2014-01-08 Thread Andrew Phillips
Committed squashed version to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds-site.git;a=search;s=nirmal070125;st=author). Thanks, @nirmal070125! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/46#issuecomment-31829362

Re: [jclouds-site] specifying wire and header log appender names explicitly. (#46)

2014-01-08 Thread Andrew Phillips
Published! ![image](https://f.cloud.github.com/assets/223702/1868581/7a72a200-786d-11e3-8eb9-b8f71a255bfc.png) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/46#issuecomment-31832948

Re: [jclouds-examples] Updated .gitignore to ignore Mac OS specific files (#29)

2014-01-08 Thread Andrew Phillips
Merged to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds-examples.git;a=commit;h=15e8825ad8ad3a171f648aeb21ffc1761d2cf8bc). --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/29#issuecomment-31865258

Re: [jclouds-labs-google] JCLOUDS-416. Use new TemplateOptions#networks field, albeit a bit janky. (#19)

2014-01-08 Thread Andrew Phillips
*/ public OptionalString getNetworkName() { - return networkName; + return fromNullable(Iterables.getFirst(getNetworks(), null)); I guess this is the bit janky bit? I see what you mean. The user can get at _all_ networks too, though? In that case, add a `@see` Javadoc to

Re: [jclouds-labs-google] JCLOUDS-416. Use new TemplateOptions#networks field, albeit a bit janky. (#19)

2014-01-08 Thread Andrew Phillips
Another [compilation failure](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/41/console). Was this also an expected one? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/19#issuecomment-31871998

Re: [jclouds] Backport JCLOUDS-416 to 1.7.x. Add TemplateOptions#networks. (#249)

2014-01-08 Thread Andrew Phillips
@@ -196,4 +190,11 @@ public void testNodeNames() { TemplateOptions options = nodeNames(nodeNames); assertTrue(options.getNodeNames().containsAll(nodeNames)); } + + @Test + public void testNetworks() { + SetString networks = ImmutableSet.of(first-network,

Re: [jclouds] JCLOUDS-416. Add TemplateOptions#networks. (#246)

2014-01-08 Thread Andrew Phillips
@@ -114,6 +114,14 @@ public static CloudSigmaTemplateOptions nodeNames(IterableString nodeNames) { return CloudSigmaTemplateOptions.class.cast(options.nodeNames(nodeNames)); } + /** + * @see TemplateOptions#nodeNames(Iterable) + */ + public

Re: [jclouds] Backport JCLOUDS-416 to 1.7.x. Add TemplateOptions#networks. (#249)

2014-01-08 Thread Andrew Phillips
@@ -332,7 +329,15 @@ public static EC2TemplateOptions nodeNames(IterableString nodeNames) { EC2TemplateOptions options = new EC2TemplateOptions(); return EC2TemplateOptions.class.cast(options.nodeNames(nodeNames)); } - + + /** + * @see

Re: [jclouds-labs] JCLOUDS-330 JCLOUDS-416: Use network options in Abiquo (#47)

2014-01-09 Thread Andrew Phillips
@@ -260,6 +255,55 @@ public boolean apply(VirtualMachine machine) { }); } + /** +* Configures the networkking for the created virtual machine. networking --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/47/files#r8754214

Re: [jclouds-labs] JCLOUDS-330 JCLOUDS-416: Use network options in Abiquo (#47)

2014-01-09 Thread Andrew Phillips
@@ -260,6 +255,55 @@ public boolean apply(VirtualMachine machine) { }); } + /** +* Configures the networkking for the created virtual machine. +* p +* If the template options have been configured with a set of network +* identifiers, jclouds will assign the

Re: [jclouds-labs] JCLOUDS-330 JCLOUDS-416: Use network options in Abiquo (#47)

2014-01-09 Thread Andrew Phillips
+ /** +* Configures the networkking for the created virtual machine. +* p +* If the template options have been configured with a set of network +* identifiers, jclouds will assign the virtual machine one IP address of +* each network. +* p +* If no network ids

Re: [jclouds-labs] JCLOUDS-330 JCLOUDS-416: Use network options in Abiquo (#47)

2014-01-09 Thread Andrew Phillips
+*/ + private void configureNetworking(VirtualMachine vm, VirtualApplianceCachingTemplate template, Datacenter datacenter, + TemplateOptions options) { + + if (!options.getNetworks().isEmpty()) { + ListIp?, ? ips = Lists.newArrayList(); + Enterprise

Re: [jclouds-labs] JCLOUDS-330 JCLOUDS-416: Use network options in Abiquo (#47)

2014-01-09 Thread Andrew Phillips
@@ -269,6 +313,15 @@ public boolean apply(final VirtualMachine input) { }; } + private static PredicateNetwork? networkId(final String id) { + return new PredicateNetwork?() { + @Override + public boolean apply(final Network? input) { +

Re: [jclouds-labs-openstack] Adds support for Swift Object copy (#73)

2014-01-09 Thread Andrew Phillips
+ server.enqueue(addCommonHeaders(new MockResponse().setBody(stringFromResource(/access.json; + server.enqueue(addCommonHeaders(new MockResponse().setResponseCode(404) +.addHeader(SwiftHeaders.OBJECT_COPY_FROM, bar))); + + try { + SwiftApi api =

Re: [jclouds-labs-openstack] Adds support for Swift Object copy (#73)

2014-01-09 Thread Andrew Phillips
Thanks for the update, @jdaggett! Skimmed through it a bit more quickly this time. One minor comment, otherwise looks good to me! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/73#issuecomment-32001727

Re: [jclouds-labs] Add CloudSigma v2 Washington DC provider (#48)

2014-01-10 Thread Andrew Phillips
+Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an AS IS BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and

Re: [jclouds-labs-openstack] Adds support for Swift Object copy (#73)

2014-01-10 Thread Andrew Phillips
+ server.enqueue(addCommonHeaders(new MockResponse().setBody(stringFromResource(/access.json; + server.enqueue(addCommonHeaders(new MockResponse().setResponseCode(404) +.addHeader(SwiftHeaders.OBJECT_COPY_FROM, bar))); + + try { + SwiftApi api =

Re: [jclouds-labs] Add CloudSigma v2 Washington DC provider (#48)

2014-01-10 Thread Andrew Phillips
+ public CloudSigma2WashingtonProviderMetadata() { + super(builder()); + } + + public CloudSigma2WashingtonProviderMetadata(Builder builder) { + super(builder); + } + + public static Properties defaultProperties() { + Properties properties = new Properties(); +

Re: [jclouds-labs] Add CloudSigma v2 Washington DC provider (#48)

2014-01-10 Thread Andrew Phillips
+ .apiMetadata(new CloudSigma2ApiMetadata()) + .homepage(URI.create(http://www.cloudsigma.com/en/our-cloud/features;)) + .console(URI.create(https://gui.wdc.cloudsigma.com/;)) + .iso3166Codes(US-DC) + .endpoint(https://wdc.cloudsigma.com/api/2.0/;) +

Re: [jclouds] Adds support for networks in the NovaComputeServiceAdapter (#250)

2014-01-10 Thread Andrew Phillips
+1 - looks good to me. So, to be clear, in the test we're just verifying that ``` template.getOptions().as(NovaTemplateOptions.class).networks(4ebd35cf-bfe7-4d93-b0d8-eb468ce2245a); ``` gets correctly included in the create server request? --- Reply to this email directly or view it on GitHub:

Re: notifications@ and/or commits@ lists?

2014-01-10 Thread Andrew Phillips
Just to resurrect this one, after seeing an interesting comment [1] in a podling review about how a low signal-to-noise ratio on the dev@ list could also deter committers. According to infra, we should just be able to file a ticket: 17:47] gmcdonald up to the project to choose. 1. create a

Re: [jclouds-labs] JCLOUDS-330 JCLOUDS-416: Use network options in Abiquo (#47)

2014-01-10 Thread Andrew Phillips
Unfortunately the ComputeServiceAdapterLiveTest is still not working in Abiquo Would this be worth pulling out into a strategy with a unit test, or something like that? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/47#issuecomment-32075214

Re: notifications@ and/or commits@ lists?

2014-01-10 Thread Andrew Phillips
This is now: https://issues.apache.org/jira/browse/INFRA-7180 If INFRA is unable to unsubscribe dev@ from the new list, does anyone know who here is a moderator who *could* do that? ap

Re: notifications@ and/or commits@ lists?

2014-01-12 Thread Andrew Phillips
I think I can, maybe? Good to know, thanks. Let's see what happens to the JIRA issue and take it from there..? ap

Re: [jclouds] Add OkHttp driver to support modern HTTP verbs (#232)

2014-01-13 Thread Andrew Phillips
OkHttp 1.3.0 has been released including PATCH support. Nice! Thanks, @nacx! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/232#issuecomment-32170483

Re: [jclouds-labs-openstack] Use the OkHttp driver in Marconi to support PATCH methods (#75)

2014-01-13 Thread Andrew Phillips
PS: Change itself looks good - +1 from me. Thanks, @nacx! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/75#issuecomment-32170908

Re: [jclouds-labs-openstack] Use the OkHttp driver in Marconi to support PATCH methods (#75)

2014-01-13 Thread Andrew Phillips
Actually, BuildHive seems [to be complaining](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/769/console) about something else: ``` [ERROR] 'dependencies.dependency.version' for com.squareup.okhttp:mockwebserver:jar is missing. @ line 109, column 17 ``` I'm sure the

Re: [jclouds-labs] JCLOUDS-330 JCLOUDS-416: Use network options in Abiquo (#47)

2014-01-13 Thread Andrew Phillips
I plan to open a PR today with an alternative implementation of the TemplateBuilderImpl Curious! Looking forward to that... --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/47#issuecomment-32171037

Re: [jclouds-examples] Example of creating a server with a key pair (#30)

2014-01-13 Thread Andrew Phillips
+import java.util.Properties; +import java.util.Set; +import java.util.concurrent.TimeoutException; + +import static com.google.common.base.Charsets.UTF_8; +import static org.jclouds.compute.config.ComputeServiceProperties.POLL_INITIAL_PERIOD; +import static

Re: [jclouds-examples] Example of creating a server with a key pair (#30)

2014-01-13 Thread Andrew Phillips
+ public CreateServerWithKeyPair(String username, String apiKey) { + IterableModule modules = ImmutableSet.Module of(new SshjSshClientModule()); + + // These properties control how often jclouds polls for a status update + Properties overrides = new Properties(); +

Re: [jclouds-examples] Example of creating a server with a key pair (#30)

2014-01-13 Thread Andrew Phillips
+ + /** +* Delete the public key in the cloud and the local private key. +*/ + private void deleteKeyPair(KeyPair keyPair) { + System.out.format( Delete Key Pair%n); + + KeyPairApi keyPairApi = nova.getApi().getKeyPairExtensionForZone(ZONE).get(); +

Re: Openstack glance - incubation

2014-01-13 Thread Andrew Phillips
[redirecting to dev@j.a.o...] Hi, I've noticed that glance is still in incubation, even though it's been there since nova. I expected that 1.7 release would include a production glance since it is a basic functionality for any nova operation. why is glance still in incubation? when glance

Re: [jclouds-site] Improve jclouds call to action in the footer (10da131)

2014-01-13 Thread Andrew Phillips
Become a jclouds Developer? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/commit/10da131f035c6739a1be82142261e315235b1832#commitcomment-5056628

Re: [jclouds-site] Rebranding proposal (#51)

2014-01-13 Thread Andrew Phillips
![image](https://f.cloud.github.com/assets/223702/1905954/d06b3e3c-7ca6-11e3-8eb2-a1d9ee3b6ca8.png) CUSTOMERS - USERS? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/51#issuecomment-32221835

Re: [jclouds-site] Improve jclouds call to action in the footer (10da131)

2014-01-13 Thread Andrew Phillips
Make jclouds Better? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/commit/10da131f035c6739a1be82142261e315235b1832#commitcomment-5056667

Re: [jclouds-site] Rebranding proposal (#51)

2014-01-13 Thread Andrew Phillips
What do you think? I certainly like the idea of encouraging the reader to do something. Just wondering if we can make it a horizontal menu in some way, in keeping with most of the other menus and the general layout theme on the page? --- Reply to this email directly or view it on GitHub:

Re: CreateImageOptions and UpdateImageOptions cunstroctors

2014-01-14 Thread Andrew Phillips
In jclouds we usually provide builders that return the result of a self() methos instead of returning this. This allows proper builder inheritance. See an api metadata builder examples [1] (and have a look at its superclass too). If the builder you are using does not follow that pattern

Re: [jclouds] BACKPORT: Added OkHttp driver to support modern HTTP verbs (#251)

2014-01-14 Thread Andrew Phillips
Skimmed over this as I assume it's mainly a backport of already reviewed code. Bearing that in mind, +1 - looks good to me. Thanks, @nacx! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/251#issuecomment-32270637

Re: [jclouds-site] Rebranding proposal (#51)

2014-01-14 Thread Andrew Phillips
I'm not married to it. users might be more appropriate in this case. My motivation was mainly to avoid users thinking that jclouds is somehow paid-for software. If you're thinking about something like Meetup then yes, agreed.

Re: [jclouds] JCLOUDS-423: Update Service Type for Cloud Files CDN (#252)

2014-01-15 Thread Andrew Phillips
jclouds-pull-requests #507 UNSTABLE Unrelated [test failure](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/org.apache.jclouds$jclouds-compute/507/testReport/junit/org.jclouds.compute.util/ConcurrentOpenSocketFinderTest/testChecksSocketsConcurrently/) +1 - looks good to me. ---

Re: [jclouds-site] New Google Analytics account (#52)

2014-01-15 Thread Andrew Phillips
I do see traffic in the Real-Time report for jclouds.apache.org so I think it's working properly. Nice. Thanks! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/52#issuecomment-32367892

Re: Code snippets in JIRA for minor new features

2014-01-15 Thread Andrew Phillips
I'd like to encourage everyone to include code snippets in JIRA for how to use minor new features that you've developed. Sounds useful not just for newly developed features, but also in feature *requests* if users have an idea of the kind of code they'd *like* to use. I'm just curious,

Hoping for infra karma for notifications@ ticket

2014-01-16 Thread Andrew Phillips
I've tried to see if our create notifications@ ticket [1] is at least correctly specified on #asfinfra a couple of times, but haven't had much luck so far. If anyone has some karma to potentially move this along, that would be much appreciated. I don't know if voting for the issue helps in

Re: [jclouds-site] Added pom.xml file for OpenStack dependencies (#53)

2014-01-16 Thread Andrew Phillips
-This is a list of providers that work with OpenStack that you can use to build your Context. +This pom.xml file specifies all of the dependencies you'll need to work with OpenStack. Replace the jclouds.version X.X.X with the latest version available according to the [Release

Re: [jclouds-site] Added pom.xml file for OpenStack dependencies (#53)

2014-01-16 Thread Andrew Phillips
-* `openstack-nova` -* `openstack-keystone` -* `openstack-cinder` -* `swift-keystone` +pre +{% highlight xml %} Does Jekyll support some way of making a block of text easy to copy to the clipboard? Or would it be worth also having a link to a Gist or something for easy downloading?

Re: [jclouds-site] Added pom.xml file for OpenStack dependencies (#53)

2014-01-16 Thread Andrew Phillips
-* `openstack-nova` -* `openstack-keystone` -* `openstack-cinder` -* `swift-keystone` +pre +{% highlight xml %} I very purposefully didn't use a Gist True, true. Worth putting a downloadable file in jclouds-site? --- Reply to this email directly or view it on GitHub:

Re: [jclouds-examples] Renames domain classes for consitency (#31)

2014-01-16 Thread Andrew Phillips
@@ -117,11 +117,6 @@ /dependency dependency groupIdorg.apache.jclouds.labs/groupId - artifactIdrackspace-autoscale/artifactId - version${jclouds.version}/version -/dependency -dependency - groupIdorg.apache.jclouds.labs/groupId I'm guessing this is

Re: [jclouds-examples] Renames domain classes for consitency (#31)

2014-01-16 Thread Andrew Phillips
Pending the PR builders, +1 - looks good to me! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/31#issuecomment-32523495

Re: [jclouds-labs-openstack] Adds support for Swift Object copy (#73)

2014-01-16 Thread Andrew Phillips
Zack's comments aside, looks good to me too. Thanks, @jdaggett! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/73#issuecomment-32530108

Re: [jclouds-labs-openstack] Renames multiple domain classes for consistency (#76)

2014-01-16 Thread Andrew Phillips
+ */ +package org.jclouds.rackspace.autoscale.v1.domain; + +import static com.google.common.base.Preconditions.checkNotNull; + +import java.beans.ConstructorProperties; +import java.util.Map; + +import org.jclouds.javax.annotation.Nullable; + +import com.google.common.base.Objects;

Re: [jclouds-labs-openstack] Renames multiple domain classes for consistency (#76)

2014-01-16 Thread Andrew Phillips
+import static com.google.common.base.Preconditions.checkArgument; +import static com.google.common.base.Preconditions.checkNotNull; + +import java.beans.ConstructorProperties; +import java.util.EnumSet; +import java.util.Map; + + +import com.google.common.base.Objects; +import

Re: [jclouds-labs-openstack] Renames multiple domain classes for consistency (#76)

2014-01-16 Thread Andrew Phillips
@@ -194,7 +194,7 @@ public void testUpdateWebhook() { String webhookId = webhookApi.list().first().get().getId(); assertTrue( webhookApi.update(webhookId, updated_name, ImmutableMap.String, Objectof()) ); - WebhookResponse webhook= webhookApi.get(webhookId); +

Re: [jclouds-labs-openstack] Renames multiple domain classes for consistency (#76)

2014-01-16 Thread Andrew Phillips
A couple of minor comments, but if this is a backport, address in a different PR? Code itself looks good to me...+1. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/76#issuecomment-32530686

Re: [jclouds-site] Added pom.xml file for OpenStack dependencies (#53)

2014-01-16 Thread Andrew Phillips
-* `openstack-nova` -* `openstack-keystone` -* `openstack-cinder` -* `swift-keystone` +pre +{% highlight xml %} OK! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/53/files#r8946375

Re: [jclouds-labs-openstack] Adds support for Swift Object copy (#73)

2014-01-16 Thread Andrew Phillips
@@ -163,11 +163,11 @@ public void alreadyCreated() throws Exception { /** upper-cases first char, and lower-cases rest!! **/ public void getKnowingServerMessesWithMetadataKeyCaseFormat() throws Exception { MockWebServer server = mockOpenStackServer(); -

[jclouds-site] Eclipe's - Eclipse's in dev guide (#54)

2014-01-16 Thread Andrew Phillips
Should be straightforward...just want to check the rendering. You can merge this Pull Request by running: git pull https://github.com/jclouds/jclouds-site fix-typo Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-site/pull/54 -- Commit Summary --

Re: [jclouds-site] Eclipe's - Eclipse's in dev guide (#54)

2014-01-16 Thread Andrew Phillips
![image](https://f.cloud.github.com/assets/223702/1935436/b78e1ef2-7ef9-11e3-8361-367ea0479625.png) Looks OK. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/54#issuecomment-32551812

Re: [jclouds-labs-openstack] Adds support for Swift Object copy (#73)

2014-01-16 Thread Andrew Phillips
@@ -163,11 +163,11 @@ public void alreadyCreated() throws Exception { /** upper-cases first char, and lower-cases rest!! **/ public void getKnowingServerMessesWithMetadataKeyCaseFormat() throws Exception { MockWebServer server = mockOpenStackServer(); -

ASF Board Report?

2014-01-17 Thread Andrew Phillips
I see in Brett's summary email: The following reports were not received and are expected next month: ... Report from the Apache jclouds Project [Andrew Bayer] Did we *miss* this month or is it our turn only next month? I did a quick search for ASF project board report but couldn't find a

Re: [jclouds-labs-openstack] Adds support for Swift Object copy (#73)

2014-01-17 Thread Andrew Phillips
I had to merge this properly just now. I think I messed up when pushing. All done, though? Or still work to come? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/73#issuecomment-32669617

Re: notifications@ and/or commits@ lists?

2014-01-17 Thread Andrew Phillips
So, we have notifications@ (in fact, it seems like we've had it for a while...doh!) [1, 2]. I have now changed the notifications for: * BuildHive * DEV@cloud to go there. JIRA has already been switched over. Leaves a couple of tasks: 1. Change the email address for the jclouds-mirror user

Re: [jclouds-site] Eclipe's - Eclipse's in dev guide (#54)

2014-01-17 Thread Andrew Phillips
Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds-site.git;a=commit;h=3c40769e73790cb400750f3a4711dc03732d7c92) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/54#issuecomment-32673950

Re: openstack glance live test

2014-01-19 Thread Andrew Phillips
Hi Inbar I don't know the Glance tests well, but, looking at the POM, it seems there may be some other properties you need to set? https://github.com/jclouds/jclouds-labs-openstack/blob/master/openstack-glance/pom.xml#L38 Regards ap

Re: [jclouds-site] Rebranding proposal (#51)

2014-01-19 Thread Andrew Phillips
Just to show these two side by side: ![image](https://f.cloud.github.com/assets/223702/1945762/8985b5bc-7fd8-11e3-9726-dd77fc06171f.png) and ![image](https://f.cloud.github.com/assets/223702/1949746/dd4cc852-811d-11e3-8358-7fef4c13bdb0.png) --- Reply to this email directly or view it on

Fwd: [GitHub] Please verify your email 'dev@jclouds.apache.org'

2014-01-20 Thread Andrew Phillips
Just ensuring GitHub notifications are sent to dev@ rather than private@ while we wait for Infra [1]... ap [1] https://issues.apache.org/jira/browse/INFRA-7213

Fw: HP Cloud - Gratis Status Ending

2014-01-20 Thread Andrew Phillips
Forwarding message from private@... Does anyone have some karma with HP Cloud to get this extended? Perhaps as part of [1]? ap [1] http://apache.markmail.org/thread/atpf4t3bsyskex4z Subject: HP Cloud - Gratis Status Ending From: Cloud Support supp...@hpcloud.com Dear Apache Incubator

Re: [jclouds] The metadata needs to be ordered for this implementation. (#255)

2014-01-20 Thread Andrew Phillips
@@ -30,8 +30,8 @@ * @author Everett Toews */ public class Metadata extends ForwardingMapString, String { - private final MapString, String metadata = newHashMap(); - private final MapString, Integer keyToId = newHashMap(); + private final MapString, String metadata =

Re: Glance implementation

2014-01-21 Thread Andrew Phillips
As the v1 and v2 contains a different metadata classes, is it possible to give support to both versions at the same time in a module? Is there any way of overriding the default value of the service file? Any suggestions here? Even though the ServiceLoader spec *does* allow multiple

Re: Fwd: MODERATE for priv...@jclouds.apache.org

2014-01-21 Thread Andrew Phillips
Which address do we want to configure for Twitter notifications? private@ doesn't seem the right place..? Beat me to it, Everett ;-) Thanks! ap

Fwd: MODERATE for priv...@jclouds.apache.org

2014-01-21 Thread Andrew Phillips
Which address do we want to configure for Twitter notifications? private@ doesn't seem the right place..? ap Date: Tue, 21 Jan 2014 18:02:10 + Subject: Everett Toews (@everett_toews) mentioned you on Twitter! From: Everett Toews (via Twitter) not...@twitter.com To: Apache jclouds

Re: Glance implementation

2014-01-21 Thread Andrew Phillips
If we start going down the path of breaking it out into glance-v1, glance-v2, and glance-common, we're going to see an explosion of OpenStack modules in jclouds as new versions of APIs are released in OpenStack land. I wasn't very clear in my original answer: I was under the impression

Re: Fwd: MODERATE for priv...@jclouds.apache.org

2014-01-22 Thread Andrew Phillips
We should also decide which address should be configured for the notifications/moderation of the comments in the blog! Good question. Don't have a particularly good answer for that one...dev@ would seem the most appropriate option so far? Who is actually *able* to accept/deny comments?

Re: Fwd: MODERATE for priv...@jclouds.apache.org

2014-01-22 Thread Andrew Phillips
Yes, you need the credentials for the Disquss account, and currently only PMC members have them Create a pmc@ group or mailing list, then? On the other hand: we have plenty of lists already... ap

Re: [jclouds] Update glance's endpoint for unit tests (#258)

2014-01-22 Thread Andrew Phillips
@@ -71,7 +71,7 @@ endpoints: [ { tenantName: 40806637803162, -publicURL: https://glance.jclouds.org:9292/v1.0;, +publicURL: https://glance.jclouds.org:9292;, Is this a real

Roadmap for 1.8.0 and beyond?

2014-01-22 Thread Andrew Phillips
Picking up from discussions last year about our release cadence [1]...would it make sense to try to put together a draft backlog for 1.8/2.0 and beyond, to see what development capacity we're likely to have and hence what can realistically be done? ap [1]

Re: [jclouds] JCLOUDS-431: Added m3.medium and m3.large instance types to EC2 (#259)

2014-01-22 Thread Andrew Phillips
@@ -296,6 +296,30 @@ public static EC2HardwareBuilder m2_4xlarge() { } /** +* @see InstanceType#M3_MEDIUM +*/ + public static EC2HardwareBuilder m3_medium() { + return new EC2HardwareBuilder(InstanceType.M3_MEDIUM) +.ram(3840) +

Re: [jclouds] JCLOUDS-431: Added m3.medium and m3.large instance types to EC2 (#259)

2014-01-22 Thread Andrew Phillips
@@ -118,6 +118,28 @@ */ public static final String M2_4XLARGE = m2.4xlarge; /** +* M3 Medium Instance +* ul +* li3.75 GiB memory/li +* li3 EC2 Compute Units (1 virtual core with 3 EC2 Compute Units)/li +* li1 SSD-based volume with 4 GiB of instance

Re: [jclouds] JCLOUDS-431: Added m3.medium and m3.large instance types to EC2 (#259)

2014-01-22 Thread Andrew Phillips
+* li32-bit or 64-bit platform/li +* liI/O Performance: Moderate/li +* /ul +*/ + public static final String M3_MEDIUM = m3.medium; + /** +* M3 Large Instance +* ul +* li7 GiB memory/li +* li6.5 EC2 Compute Units (2 virtual cores with 3.25 EC2 Compute

Re: jclouds not working with 1.7.0_51

2014-01-22 Thread Andrew Phillips
On this subject... https://jclouds.ci.cloudbees.com/view/Java%207/job/jclouds-java-7u51/19/console is currently running and looks good so far. Compiles and passes all tests in core and the first few providers. The required changes are reasonably small but a bit clunky. See the JCLOUDS-427

[jclouds] Fixing an error message about an unassignable backend (#260)

2014-01-23 Thread Andrew Phillips
You can merge this Pull Request by running: git pull https://github.com/jclouds/jclouds fix-assignment-message Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/260 -- Commit Summary -- * Fixing an error message about an unassignable backend

Re: [jclouds] Avoiding broken parts of Guava (#261)

2014-01-23 Thread Andrew Phillips
+import com.google.common.reflect.TypeToken; + +/* + * FIXME: remove this class ASAP! + * + * Evil stuff, adapted from https://code.google.com/p/guava-libraries/source/browse/guava/src/com/google/common/reflect/TypeToken.java#236. + * See https://issues.apache.org/jira/browse/JCLOUDS-427

Re: [jclouds] Fixing an error message about an unassignable backend (#260)

2014-01-23 Thread Andrew Phillips
Dang. Forgot the `BaseViewTest`. Let's try that again... --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/260#issuecomment-33122501

Re: [jclouds] JCLOUDS-431: Added m3.medium and m3.large instance types to EC2 (#259)

2014-01-23 Thread Andrew Phillips
@@ -296,6 +296,30 @@ public static EC2HardwareBuilder m2_4xlarge() { } /** +* @see InstanceType#M3_MEDIUM +*/ + public static EC2HardwareBuilder m3_medium() { + return new EC2HardwareBuilder(InstanceType.M3_MEDIUM) +.ram(3840) +

Re: [jclouds] Avoiding broken parts of Guava (#261)

2014-01-23 Thread Andrew Phillips
Hm, a duplicate finder [failure](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/520/console): ``` [WARNING] Found duplicate (but equal) classes in [com.google.guava:guava:15.0,org.apache.jclouds:jclouds-core:1.8.0-SNAPSHOT] : [WARNING]

<    1   2   3   4   5   6   7   8   9   10   >