Checkstyle looks good. Committed to
[1.7.x](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=dc7bad39ccfd766129ee8710911420fca2e435d3)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/266#issuecomment-33478260
+/**
+ * Transforms an {@link Status} to the jclouds portable model.
+ *
+ * @author Sergi Castro
+ * @author Ignasi Barrera
+ */
+@Singleton
+public class DropletStatusToStatus implements FunctionDroplet.Status,
Status {
+
+ private static final FunctionDroplet.Status, Status
+ public org.jclouds.compute.domain.Image apply(final Image input) {
+ ImageBuilder builder = new ImageBuilder();
+ builder.ids(String.valueOf(input.getId()));
+ builder.name(input.getName());
+ builder.description(input.getName());
+
+import org.jclouds.domain.LocationScope;
+import org.jclouds.location.suppliers.all.JustProvider;
+
+import com.google.common.base.Function;
+import com.google.common.collect.ImmutableSet;
+
+/**
+ * Transforms an {@link Region} to the jclouds portable model.
+ *
+ * @author Sergi
Thanks for the updates! Haven't had a chance to run through the whole thing
yet, but one quick comment: I noticed you removed trailing `//` comments
somewhere...is it the plan to do this elsewhere or not?
---
Reply to this email directly or view it on GitHub:
Committed to
[1.7.x](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=742003ab3ab69b65f33c1cd8e88300920dcc7acb)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/268#issuecomment-33486107
Sorry for the long delay.
No need for an apology! Was your PR, not mine ;-) Glad you have some time to
get back to this.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/24#issuecomment-33494779
@iocanel: Could you have a look? I guess this would need to be aligned with the
version [used by the
driver](https://github.com/jclouds/jclouds/blob/master/drivers/bouncycastle/pom.xml#L65)?
Thanks, @janstey!
---
Reply to this email directly or view it on GitHub:
Whoops...I totally missed this. Thanks, @iocanel! +1 - looks good to me!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/52#issuecomment-33578393
@iocanel While you're looking at Karaf...does this one look OK?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/28#issuecomment-33581977
@iocanel: https://github.com/jclouds/jclouds/pull/269 still seems to be open..?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/24#issuecomment-33599513
@janstey @iocanel: According to the [Bouncy Castle
site](http://www.bouncycastle.org/latest_releases.html), they're now on 1.50?
Could we go straight to that or is there some reason to stop at 1.49.
---
Reply to this email directly or view it on GitHub:
jclouds » jclouds-karaf #698 UNSTABLE
No _new_ itest failures here...not sure what is going on with these, though.
@iocanel Any ideas? Seems to have [started
here](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-karaf/689/),
caused by...erm...me with [the Guava
jclouds » jclouds-karaf #699 UNSTABLE
Still the same [test
failures](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-karaf/699/)
as before, so I think this change is fine - +1
---
Reply to this email directly or view it on GitHub:
Artifact ID has also changed: bcprov-jdk16 -gt; bcprov-ext-jdk15on
See https://github.com/jclouds/jclouds-karaf/pull/29 and
[JCLOUDS-440](https://issues.apache.org/jira/browse/JCLOUDS-440)
You can merge this Pull Request by running:
git pull https://github.com/jclouds/jclouds upgrade-bouncy
It's
[BuildHive](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-karaf/699/).
Let me check the build setup...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/30#issuecomment-33634617
All good again
[now](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-karaf/701/),
though, so hopefully no investigation required ;-)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/30#issuecomment-33634716
Committed to
[master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=32a2a7c59b86e8c6047d8de0d7c426ae871b0bc0).
Thanks, @andrewgaul!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/271#issuecomment-33645280
Artifact ID has also changed: bcprov-jdk16 -gt; bcprov-ext-jdk15on
1.7.x backport of https://github.com/jclouds/jclouds/pull/271
You can merge this Pull Request by running:
git pull https://github.com/jclouds/jclouds upgrade-bouncy-1.7.x
Or you can view, comment on it, or merge it online at:
Artifact ID has also changed: bcprov-jdk16 -gt; bcprov-ext-jdk15on
1.6.x backport of https://github.com/jclouds/jclouds/pull/271
You can merge this Pull Request by running:
git pull https://github.com/jclouds/jclouds upgrade-bouncy-1.6.x
Or you can view, comment on it, or merge it online at:
jclouds-pull-requests #546 FAILURE
No space left on device, eh? Let's try again...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/273#issuecomment-33648492
jclouds-pull-requests #545 FAILURE
No space left on device, eh? Let's try again...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/272#issuecomment-33648519
jclouds-java-7-pull-requests #1015 FAILURE
```
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 29:18.666s
[INFO] Finished at: Wed Jan 29 20:01:57
Committed to
[1.7.x](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=3de11fa8403700233dc51ab5e0c15f8ebc9f64b0)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/272#issuecomment-33651639
jclouds-karaf-pull-requests #27 UNSTABLE
This was still running `mvn clean verify` instead of `clean install`. BuildHive
is enough, I think.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/31#issuecomment-33651725
jclouds-java-7-pull-requests #1018 UNSTABLE
Ah, better. One of our usual [spurious test
Committed to
[1.6.x](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=c56d7ad8cde78f43c813105860b7f1f3445a620a)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/273#issuecomment-33653751
OK, this really has gone weird. Time to clean the workspace and try one more
time.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/32#issuecomment-33654266
Committed to
[1.6.x](https://git-wip-us.apache.org/repos/asf?p=jclouds-karaf.git;a=commit;h=d73f1885d7f38b7f1d9fa69022d053c2b0899289).
Thanks, @janstey and @iocanel!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/29#issuecomment-33654388
@iocanel: I think we need to revert this commit. The Guava upgrade is only
happening on master (see
https://github.com/jclouds/jclouds-karaf/commit/897bd89557b0847075f4fb38a4cb6aab2d5c0bb2).
Users apparently don't like us switching to a new Guava version in a minor
release (they can always
Not switching to a new Guava version outside major releases.
This reverts commit 6e9419f1c3e781c2f7c3eb49c8d179bf03c99f29.
See similar revert at
https://github.com/jclouds/jclouds-karaf/commit/897bd89557b0847075f4fb38a4cb6aab2d5c0bb2
You can merge this Pull Request by running:
git pull
jclouds-labs-pull-requests #130 FAILURE
Repo download failure. Let's wait for BuildHive.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/53#issuecomment-33658597
jclouds-karaf-pull-requests #29 UNSTABLE
jclouds » jclouds-karaf #706 UNSTABLE
Looks like these were actually caused by an [inadvertent Guava
upgrade](https://github.com/jclouds/jclouds-labs/commit/6e9419f1c3e781c2f7c3eb49c8d179bf03c99f29)
in jclouds-labs 1.7.x. Now
jclouds-karaf-pull-requests #30 UNSTABLE
No test failures, just an unhappy checkstyle.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/32#issuecomment-3371
Let's try these one more time with Maven 3.0.5 (rather than 3.0.3)...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/273#issuecomment-33651482
It's happening with a LiveTest
Ah, OK. Could you put the stacktrace in a Gist or Pastie? Guess we're missing a
unit test somewhere, then ;-)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/273#issuecomment-33808318
jclouds » jclouds-labs-google #654 UNSTABLE
Even with the Bouncycastle change there are some [test
failures](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/654/testReport/).
Are they related to the Bouncycastle thing, or..?
---
Reply to this email directly or view it on
If your browser can detect feeds, they should show up however your browser
detects them on any
page.
Where would you see that in Chrome, if at all? The Atom files themselves look
fine...thanks, @everett-toews!
---
Reply to this email directly or view it on GitHub:
No if I add that extra lib to the pom.xml my livetests are ok
Good. But there are still some unit test failures reported by BuildHive (even
_with_ the new lib) - do you see those too?
---
Reply to this email directly or view it on GitHub:
@andreaturli: which live test is failing? According to `mvn dependency:list`,
this repo should only have a _test_ dependency on Bouncycastle:
```
C:\...\jclouds-labs-googlemvn dependency:list | findstr bouncy
[INFO]org.apache.jclouds.driver:jclouds-bouncycastle:jar:1.7.1-SNAPSHOT:test
[INFO]
Hi James!
The Phoenix project has recently come into incubation from it's former life
as a Github project. I believe jclouds went through this same transition,
so I'm looking to get some advice from you. What's the best development
methodology folks have found for collaborative development when
- Does the github mirror get behind the Apache git repo leading to problems
(perhaps leading to the committer having to do extra merges)?
Our Jenkins job runs every 15min, so any lag isn't significant. I
don't think we've experienced any problems as a result of this. If at
all, we may have
Related to the roadmap, but perhaps worthy of a separate discussion:
what kind of strategy are we aiming for with regard to provider
maintenance? Apart from the great work the Rackspace guys our doing,
our existing providers are generally going stale and risk becoming
outdated. vCloud and
We've got a whole bunch of outstanding pull requests:
jclouds: 22
jclouds-labs: 4
jclouds-labs-openstack: 3
jclouds-karaf: 4
jclouds-cli: 1
Any chance of getting together for a one-day PR jam or so to plough
through these and close, update or merge them?
ap
Rough draft here:
https://wiki.apache.org/jclouds/FebruaryBoardReportProposal
abayer: is this draft sufficient for us to submit it to the next ASF
board meetings?
ap
Removing unneeded header file and strange characters from the POM
You can merge this Pull Request by running:
git pull https://github.com/jclouds/jclouds-labs-google backports-1.7.x
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs-google/pull/21
ones. Which brings the discussion onto the table: when do we consider
a PR dead? Should we close dead ones?
I would say so. They can always be reopened, if necessary. I'd say
ping the authors and see if there's a response within a week or so..?
ap
Ah...I think this might be due to the fact that the SSHJ version (0.8.1) is on
an [older version of
Bouncycastle](https://github.com/shikhar/sshj/blob/v0.8.1/pom.xml#L209). I'll
submit a PR to try to update to the latest version.
In the meantime, could you try a local build in which you
Committed to 1.7.x:
[1](https://git-wip-us.apache.org/repos/asf?p=jclouds-labs-google.git;a=commit;h=9db8806106ee108e248d8b53f909572627f17647),
[2](https://git-wip-us.apache.org/repos/asf?p=jclouds-labs-google.git;a=commit;h=c01292025a54896d559bd10e8b9a3aa7d76acc1e)
---
Reply to this email
See https://issues.apache.org/jira/browse/JCLOUDS-448
You can merge this Pull Request by running:
git pull https://github.com/jclouds/jclouds up-sshj-1.7.x
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/275
-- Commit Summary --
* Upgrading
See https://issues.apache.org/jira/browse/JCLOUDS-448
You can merge this Pull Request by running:
git pull https://github.com/jclouds/jclouds up-sshj-1.6.x
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/276
-- Commit Summary --
* Upgrading
See https://issues.apache.org/jira/browse/JCLOUDS-448
You can merge this Pull Request by running:
git pull https://github.com/jclouds/jclouds up-sshj
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/274
-- Commit Summary --
* Upgrading sshj
So seems like upgrading sshj is the way to go. Thanks!
Thanks for testing, @andreaturli!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/273#issuecomment-33978582
jclouds » jclouds #798 FAILURE
Doh! Stupid compilation failure. Hopefully fixed with the upcoming commit.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/274#issuecomment-33979888
See discussion at
[#273](https://github.com/jclouds/jclouds/pull/273#issuecomment-33970133)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/20#issuecomment-33980122
org.jclouds -gt; org.apache.jclouds.driver
You can merge this Pull Request by running:
git pull https://github.com/jclouds/jclouds-site update-log-ref
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-site/pull/56
-- Commit Summary --
* Updating
Looks OK:
Quick review from anyone?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/56#issuecomment-34001125
The RestAnnotationProcessor [1] currently supports four ways of
generating the endpoint, and they are invoked in the following order:
Thanks for the explanation, Ignasi! Any chance of turning this into a
short Wiki doc..?
ap
Just answered the incubator thread clarifying our workflow.
Thanks, Ignasi! I see Bertrand responded with a couple of TODO items
;-) But overall it looks like our PR process is fine, if I'm reading
him correctly.
ap
stated otherwise. From an IP standpoint, I am happy with the level of
assurance that provides.
Thanks for clarifying, David!
ap
@nacx: Actually, I think you may be seeing the same issue as Andrea was in
https://github.com/jclouds/jclouds/pull/273. Could you try what he did -
exclude sshj (you have the old 0.8.1 version in your dep list) and try again
with the 0.9.0 version?
---
Reply to this email directly or view it
--
From: Andrew Phillips andr...@apache.orgmailto:andr...@apache.org
Date: 2013-12-22
To: u...@jclouds.apache.orgmailto:u...@jclouds.apache.org
Is this issue been solved in jclouds 1.7.0?
No, there has been no additional work on vCloud 5.1 in 1.7.0. See two recent
user group threads on this topic [1
Shame on me.
Certainly not! Thanks for working through to try to figure out what was going
on. And let's see whether upgrading the dep helps at all ;-)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/274#issuecomment-34087648
jclouds-pull-requests #560 UNSTABLE
Unusual failure (some test method not [finishing within
Deployed:
```
Sendingdocumentation/reference/jclouds-logging/index.html
Transmitting file data ..
Committed revision 1564501.
```
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/56#issuecomment-34108038
jclouds-pull-requests #563 FAILURE
Build was successful, then the job barfed with a
```
[ERROR] Internal error: java.lang.NullPointerException - [Help 1]
org.apache.maven.InternalErrorException: Internal error:
java.lang.NullPointerException
at
Thanks for the reviewing, @everett-toews!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/77#issuecomment-34109258
+ }
+
+ @Override
+ public boolean equals(Object obj) {
+ if (this == obj) return true;
+ if (obj == null || getClass() != obj.getClass()) return false;
+ Router that = Router.class.cast(obj);
+ return super.equals(obj)
+ Objects.equal(this.adminStateUp,
+ *
+ * @author Nick Livens
+ * @see a href=
+ *
http://docs.openstack.org/api/openstack-network/2.0/content/router_ext.html;api
doc/a
+ */
+@Path(/v2.0/routers)
+@RequestFilters(AuthenticateRequest.class)
+@Consumes(MediaType.APPLICATION_JSON)
+public interface RouterApi {
+
+
@@ -116,6 +122,7 @@
@Path(/{id})
@SelectJson(subnet)
@Fallback(Fallbacks.NullOnNotFoundOr404.class)
+ @Nullable
Subnet get(@PathParam(id) String id);
[minor] I think we tend to put `@Nullable` on the same line as the object, i.e.
```
@Fallback(...
@Nullable Subnet get(...
@demobox Addressed your last comments :)
Thanks! Just a squash'n'rebase to go, then! Oh, and the sshj/Bouncycastle issue
with the live tests, obviously. Otherwise, +1!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/49#issuecomment-34114395
I managed to get to 3 today.
Thanks, Everett! I'll hopefully be able to make some time tomorrow or
Friday...
ap
I've just run the live tests one more time and now one test is failing always
at the same point:
Hm. That does look like something related to the SSH driver, though. Do you
know if that call is made _successfully_ anywhere in the live tests?
---
Reply to this email directly or view it on
is now failing here
Oh, er, and what's the error? ;-)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/274#issuecomment-34117694
Tomorrow I'll run again the tests with the older sshj + bouncycastle versions
so we can compare
and make a proper decision if this should be merged or not. Sounds good?
Works for me! There's no _huge_ rush on this PR, after all.
---
Reply to this email directly or view it on GitHub:
@@ -122,6 +131,10 @@ public ToStringHelper string() {
ImmutableSetBlockDeviceMapping mappings =
blockDeviceMappings.build();
if (mappings.size() != 0)
toString.add(blockDeviceMappings, mappings);
+ if (maxCount != null)
Do we need a ` 0` check here..?
---
@@ -82,6 +82,10 @@ public void copyTo(TemplateOptions to) {
eTo.noKeyPair();
if (getUserData() != null)
eTo.userData(getUserData());
+ if (getMaxCount() != 0)
Do we need a null check here too, or can this never be null?
---
Reply to this email
@@ -200,6 +213,16 @@ public EC2TemplateOptions blockDeviceMappings(Iterable?
extends BlockDeviceMapp
return this;
}
+ public EC2TemplateOptions maxCount(Integer maxCount) {
+ this.maxCount = maxCount;
Any checks needed? Not null or ` 0`?
---
Reply to this email
-
-import javax.annotation.Resource;
-import javax.inject.Inject;
-import javax.inject.Named;
-import javax.inject.Singleton;
-
+import com.google.common.annotations.VisibleForTesting;
+import com.google.common.base.Function;
+import com.google.common.base.Optional;
+import
-import com.google.common.util.concurrent.ListenableFuture;
+import javax.annotation.Resource;
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.atomic.AtomicReference;
+
@@ -41,12 +34,15 @@
import org.jclouds.ec2.options.RunInstancesOptions;
import org.jclouds.javax.annotation.Nullable;
-import com.google.common.annotations.VisibleForTesting;
-import com.google.common.base.Function;
-import com.google.common.cache.LoadingCache;
-import
int countStarted = 0;
int tries = 0;
SetRunningInstance started = ImmutableSet.RunningInstance of();
+ int maxCount =
EC2TemplateOptions.class.cast(template.getOptions()).getMaxCount();
+ int provCount;
What is provCount supposed to stand for? Was just
@@ -285,4 +279,36 @@ public void testinboundPortsStatic() {
assertEquals(options.getInboundPorts()[0], 22);
assertEquals(options.getInboundPorts()[1], 30);
}
+
+ @Test
+ public void testMaxCountDefault() {
+ EC2TemplateOptions options = new EC2TemplateOptions();
WDYT?
Let's try it and see what happens ;-) I think we should figure out at some
point what is going on, since getting stuck on an old version of SSHJ doesn't
seem like a great idea. But for now this seems like a good way forward. I'll
also ask Andrea to test with this combination.
Thanks
Blocked by [JCLOUDS-451](https://issues.apache.org/jira/browse/JCLOUDS-451).
Will close.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/276#issuecomment-34148291
See [JCLOUDS-452](https://issues.apache.org/jira/browse/JCLOUDS-452).
@andreaturli: Turns out sshj 0.9.0 [breaks
stuff](https://issues.apache.org/jira/browse/JCLOUDS-451), so now tryng the
solution you [originally
found](https://github.com/jclouds/jclouds/pull/273#issuecomment-33805542) ;-)
Thanks to Andrea Turli and Ignasi Barrera for research and testing!
You can merge this Pull Request by running:
git pull https://github.com/jclouds/jclouds add-bcpkix-1.7.x
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/279
-- Commit Summary
Successful DEV@cloud run against 7u51:
https://jclouds.ci.cloudbees.com/job/jclouds-java-7u51/34/
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/281#issuecomment-34150009
We got there in the end! Thanks, @nacx!!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/49#issuecomment-34151090
See [JCLOUDS-432](https://issues.apache.org/jira/browse/JCLOUDS-432) and [Guava
1635](https://code.google.com/p/guava-libraries/issues/detail?id=1635)
You can merge this Pull Request by running:
git pull https://github.com/jclouds/jclouds revert-guava-fix
Or you can view, comment on it, or
Blocked by [JCLOUDS-451](https://issues.apache.org/jira/browse/JCLOUDS-451).
Will close.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/275#issuecomment-34148277
jclouds » jclouds-labs #783 FAILURE
```
Failed to transfer Could not find metadata
org.apache.jclouds:jclouds-project:1.7.1-SNAPSHOT/maven-metadata.xml in
sonatype-nexus-snapshots
(https://oss.sonatype.org/content/repositories/snapshots)
Downloaded artifact
@demobox This will be backported to 1.7.x correct?
I don't see how to, yet. The Guava team has not so far released a fix for Guava
15, and from what I know we were not planning to bump Guava versions in minor
releases. So the current workaround for 1.7.x would have to stay in place.
---
Reply
jclouds-java-7-pull-requests #1044 UNSTABLE
Yet another timing-related [test
@@ -91,6 +91,21 @@
version${jclouds.version}/version
scopetest/scope
/dependency
+!--
+exclusions
+exclusion
+groupIdnet.schmizz/groupId
+artifactIdsshj/artifactId
+
+import static com.google.common.base.Preconditions.checkState;
+import static com.google.common.collect.Iterables.contains;
+import static com.google.common.collect.Iterables.filter;
+import static com.google.common.collect.Iterables.transform;
+import static
+ rules.addAll(firewall.getAllowed());
+ FirewallOptions firewallOptions = new FirewallOptions()
+ .name(firewallName)
+ .network(network.getSelfLink())
+ .allowedRules(rules)
+
@@ -56,7 +57,7 @@ public FirewallOptions addAllowedRule(Firewall.Rule
allowedRule) {
/**
* @see org.jclouds.googlecomputeengine.domain.Firewall#getAllowed()
*/
- public FirewallOptions allowedRules(SetFirewall.Rule allowedRules) {
+ public FirewallOptions
+ FirewallOptions firewallOptions = new FirewallOptions()
+ .name(firewallName)
+ .network(network.getSelfLink())
+ .allowedRules(rules)
+ .sourceTags(templateOptions.getTags())
+
Quick update: INFRA-7213 (our ticket about getting notifications@ set
up) has been resolved - yay! - so we now have all our JIRA, BuildHive
and DEV@cloud notifications going there.
Open to sign up...if you dare! ;-)
ap
PS: It hasn't been that long yet, but do we feel this change has made
the
701 - 800 of 1315 matches
Mail list logo
