Jenkins build is still unstable: Kafka » Kafka Branch Builder » trunk #150

2021-05-20 Thread Apache Jenkins Server
See

Re: [DISCUSS] KIP-743: Deprecate config value 0.10.0-2.4 of Streams built-in metrics version config

2021-05-20 Thread Sophie Blee-Goldman
I agree with John's assessment -- if I'm interpreting it correctly, otherwise I'll claim this idea as my own :P -- that we can just drop it in 3.0 as it was effectively deprecated since day 1, ie version 2.5. In addition to what John said about this not being the default, I'll note that we never

Jenkins build is still unstable: Kafka » Kafka Branch Builder » trunk #149

2021-05-20 Thread Apache Jenkins Server
See

Re: [VOTE] KIP-720 Deprecate MirrorMaker v1

2021-05-20 Thread Ryanne Dolan
Hey y'all, reviving this thread because it seems we have a way forward w.r.t. IdentityReplicationPolicy aka LegacyReplicationPolicy, which I believe is the only missing feature in MM2 that we need to deprecate MM1. If there are no objections over the next couple of days I'll consider this

Re: [DISCUSS] KIP-743: Deprecate config value 0.10.0-2.4 of Streams built-in metrics version config

2021-05-20 Thread Guozhang Wang
I'm also a bit leaning towards dropping the config value in 3.0 directly. For the config itself, I'd rather keep it a bit longer in case we may update the metrics again (there are a couple near term projects on the roadmap including named topology, restoration threads etc). Guozhang On Thu,

Re: [DISCUSS] KIP-737 Add canTrackSource to ReplicationPolicy

2021-05-20 Thread Ryanne Dolan
Matthew, I stole your integration tests to prove that point, but I would like to make sure you get credit for them in the commit history. If you want to break out your tests into a separate commit, I can cherry-pick them into my PR. That would yield a PR with: - a couple bug fixes from me in

[jira] [Created] (KAFKA-12821) Kafka consumer skip reading from single partition

2021-05-20 Thread Prakash Patel (Jira)
Prakash Patel created KAFKA-12821: - Summary: Kafka consumer skip reading from single partition Key: KAFKA-12821 URL: https://issues.apache.org/jira/browse/KAFKA-12821 Project: Kafka Issue

Re: [DISCUSS] KIP-737 Add canTrackSource to ReplicationPolicy

2021-05-20 Thread Matthew de Detrich
@Ryanne, I just noted you updated your PR at https://github.com/apache/kafka/pull/10652/files#diff-79a09517576a35906123533490ed39c0e1a9416878e284d7b71f5f4c53eeca29R31 and I was mistaken in regards to the API changes being required. In this case we can just use your PR instead of mine without the

[jira] [Resolved] (KAFKA-12779) TaskMetadata should return actual TaskId rather than plain String

2021-05-20 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman resolved KAFKA-12779. Resolution: Fixed > TaskMetadata should return actual TaskId rather than

[REVIEW REQUESTED] - Pull Requests for KIP-633 and Addition of Missing Javadocs

2021-05-20 Thread Israel Ekpo
I just submitted my first two pull requests for the project today [KAFKA-12644] Add Missing Class-Level Javadoc to Exception Classes https://github.com/apache/kafka/pull/10741 [KAFKA-8613] Set default grace period to 0 KIP-633: Drop 24 hour default of grace period in Streams

Re: [VOTE] KIP-740: Use TaskId instead of String for the taskId field in TaskMetadata

2021-05-20 Thread Sophie Blee-Goldman
Thanks Bruno, fixed. Definitely a leftover from one of the many iterations of this KIP. Guozhang, Thanks for pointing out the change in TaskMetadata constructor, I definitely agree to just swap out the constructor since that's not really the useful part of this API. I'm more on the fence when it

Re: [VOTE] KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

2021-05-20 Thread Sanjana Kaundinya
Hi Mickael, Apologies for pinging on this again, but just wondering if you got a chance to make any progress on this? Would love to take a look and help with the reviews if you have. Thanks, Sanjana On May 7, 2021, 3:33 AM -0700, Mickael Maison , wrote: > Hi Sanjana, > > Sorry for the late

Re: [DISCUSS] KIP-741: Change default serde to be null

2021-05-20 Thread Leah Thomas
Thanks for finding that, Guozhang. Consistency seems like the best option to me as well, for the time being. I updated the KIP with that detail On Thu, May 20, 2021 at 11:53 AM Sophie Blee-Goldman wrote: > Thanks Guozhang, I forgot about ConfigException. I actually just reviewed > two KIPs

Jenkins build is still unstable: Kafka » Kafka Branch Builder » trunk #148

2021-05-20 Thread Apache Jenkins Server
See

Re: [DISCUSS] KIP-739: Block Less on KafkaProducer#send

2021-05-20 Thread Nakamura
> > My suggestion was just do this in multiple steps/phases, firstly let's fix > the issue of send being misleadingly asynchronous (i.e. internally its > blocking) and then later one we can make the various > threadpools configurable with a sane default. I like that approach. I updated the "Which

Jenkins build is still unstable: Kafka » Kafka Branch Builder » trunk #147

2021-05-20 Thread Apache Jenkins Server
See

Re: [DISCUSS] KIP-741: Change default serde to be null

2021-05-20 Thread Sophie Blee-Goldman
Thanks Guozhang, I forgot about ConfigException. I actually just reviewed two KIPs related to config-based Serdes, both of which use the ConfigException in this way: the ListSerde KIP, and the KIP to clean up the windowed inner class serde configuration. For the sake of simplicity and keeping

Re: [DISCUSS] KIP-633: Drop 24 hour default of grace period in Streams

2021-05-20 Thread Israel Ekpo
The pull request has been submitted with the changes to implement the KIP https://github.com/apache/kafka/pull/10740 Please take a look when you have a moment Thanks. On Wed, Apr 28, 2021 at 5:12 PM Israel Ekpo wrote: > Excellent Sophie. > > I have the initial changes (without the Unit tests

Re: [DISCUSS] KIP-743: Deprecate config value 0.10.0-2.4 of Streams built-in metrics version config

2021-05-20 Thread John Roesler
Thanks for opening this discussion, Bruno! I wonder if it would be ok to simply drop that config value in 3.0 instead of 4.0. Config values are a bit different than Java APIs, since many users would be using property files or string constants instead of referencing the "official" constants

Re: [VOTE] KIP-740: Use TaskId instead of String for the taskId field in TaskMetadata

2021-05-20 Thread John Roesler
Thanks for the updates, Sophie, I'm +1 (binding) -John On Thu, 2021-05-20 at 12:54 +0200, Bruno Cadonna wrote: > Thanks for the KIP, Sophie! > > +1 (binding) > > Note: > The sentence in the KIP seems to need some corrections: > > "To migrate from the String to TaskIdInfo in TaskMetadata,

[jira] [Created] (KAFKA-12820) Upgrade maven-artifact dependency to resolve CVE-2021-26291

2021-05-20 Thread Boojapho (Jira)
Boojapho created KAFKA-12820: Summary: Upgrade maven-artifact dependency to resolve CVE-2021-26291 Key: KAFKA-12820 URL: https://issues.apache.org/jira/browse/KAFKA-12820 Project: Kafka Issue

Re: [VOTE] KIP-734: Improve AdminClient.listOffsets to return timestamp and offset for the record with the largest timestamp

2021-05-20 Thread Thomas Scott
Thank Manikumar, I'm closing the voting here, the KIP passes with 3 +1 binding votes from David, Rajini and Manikumar. Thanks Tom On Thu, May 20, 2021 at 8:32 AM Manikumar wrote: > +1 (binding) > > Thanks for the KIP. > > Manikumar > > On Mon, May 17, 2021 at 5:20 PM Rajini Sivaram >

[jira] [Created] (KAFKA-12819) Quality of life improvements for tests

2021-05-20 Thread Matthew de Detrich (Jira)
Matthew de Detrich created KAFKA-12819: -- Summary: Quality of life improvements for tests Key: KAFKA-12819 URL: https://issues.apache.org/jira/browse/KAFKA-12819 Project: Kafka Issue

[jira] [Created] (KAFKA-12818) Memory leakage when kafka connect 2.7 uses directory config provider

2021-05-20 Thread Viktor Utkin (Jira)
Viktor Utkin created KAFKA-12818: Summary: Memory leakage when kafka connect 2.7 uses directory config provider Key: KAFKA-12818 URL: https://issues.apache.org/jira/browse/KAFKA-12818 Project: Kafka

[DISCUSS] KIP-743: Deprecate config value 0.10.0-2.4 of Streams built-in metrics version config

2021-05-20 Thread Bruno Cadonna
Hi, I would like to propose KIP-743 to deprecate the old structures of the built-in metrics in Streams. https://cwiki.apache.org/confluence/x/uIfOCg Best, Bruno

Jenkins build is still unstable: Kafka » Kafka Branch Builder » trunk #146

2021-05-20 Thread Apache Jenkins Server
See

Re: [DISCUSS] KIP-739: Block Less on KafkaProducer#send

2021-05-20 Thread Matthew de Detrich
@ Nakamura On Wed, May 19, 2021 at 7:35 PM Nakamura wrote: > @Ryanne: > In my mind's eye I slightly prefer the throwing the "cannot enqueue" > exception to satisfying the future immediately with the "cannot enqueue" > exception? But I agree, it would be worth doing more research. > > @Matthew:

[jira] [Resolved] (KAFKA-12776) Producer sends messages out-of-order inspite of enabling idempotence

2021-05-20 Thread NEERAJ VAIDYA (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] NEERAJ VAIDYA resolved KAFKA-12776. --- Resolution: Information Provided KIP-739 has considerable of overlap with this issue. >

Re: [VOTE] KIP-740: Use TaskId instead of String for the taskId field in TaskMetadata

2021-05-20 Thread Bruno Cadonna
Thanks for the KIP, Sophie! +1 (binding) Note: The sentence in the KIP seems to need some corrections: "To migrate from the String to TaskIdInfo in TaskMetadata, we'll need to deprecate the existing taskId() getter method and add a TaskId() getter in its place." I guess you wanted to

Re: [DISCUSS] KIP-741: Change default serde to be null

2021-05-20 Thread Bruno Cadonna
Hi, I think using ConfigException makes sense. But I am also fine with SerdeConfigurationException. I think both are meaningful in this situation where the former has the advantage that we do not need to introduce a new exception. Best, Bruno On 20.05.21 07:54, Guozhang Wang wrote:

Alternative official kafka chatroom due to freenode hostile takeover?

2021-05-20 Thread Matthew de Detrich
Hello everyone. As you may have noticed freenode has undergone a hostile takeover (see https://www.reddit.com/r/opensource/comments/ng65se/freenode_is_no_longer_run_by_community_staff/ and https://twitter.com/freenodestaff for context). Ontop of this the apache kafka freenode IRC chatroom

[ANNOUNCE] Apache Kafka 2.7.1

2021-05-20 Thread Mickael Maison
The Apache Kafka community is pleased to announce the release for Apache Kafka 2.7.1 This is a bug fix release and it includes fixes and improvements from 45 JIRAs, including a few critical bugs. All of the changes in this release can be found in the release notes:

[jira] [Created] (KAFKA-12817) Make Task ID an Implementation Detail

2021-05-20 Thread Bruno Cadonna (Jira)
Bruno Cadonna created KAFKA-12817: - Summary: Make Task ID an Implementation Detail Key: KAFKA-12817 URL: https://issues.apache.org/jira/browse/KAFKA-12817 Project: Kafka Issue Type:

[GitHub] [kafka-site] mimaison merged pull request #354: Updated downloads.html to include 2.7.1

2021-05-20 Thread GitBox
mimaison merged pull request #354: URL: https://github.com/apache/kafka-site/pull/354 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka-site] mimaison commented on pull request #354: Updated downloads.html to include 2.7.1

2021-05-20 Thread GitBox
mimaison commented on pull request #354: URL: https://github.com/apache/kafka-site/pull/354#issuecomment-844905400 @rajinisivaram @omkreddy Can you take a look? We need this PR and https://github.com/apache/kafka/pull/10660 in order to release 2.7.1. Thanks -- This is an automated

Re: [VOTE] KIP-373: Allow users to create delegation tokens for other users

2021-05-20 Thread Viktor Somogyi-Vass
Hi Matthew, I saw your email the other day. Unfortunately this has been deprioritized in our team back then but now I started to rebase and finish the solution. I'll create a PR (at least a draft) sometime later today and hopefully can start reviewing it soon in a few days. Viktor On Tue, May

Re: [VOTE] KIP-734: Improve AdminClient.listOffsets to return timestamp and offset for the record with the largest timestamp

2021-05-20 Thread Manikumar
+1 (binding) Thanks for the KIP. Manikumar On Mon, May 17, 2021 at 5:20 PM Rajini Sivaram wrote: > +1 (binding) > > Thanks for the KIP, Tom! > > Regards, > > Rajini > > > On Mon, May 17, 2021 at 12:42 PM David Jacot > wrote: > > > +1 (binding) > > > > Thanks for the KIP, Tom. > > > > Best, >

Re: [VOTE] KIP-740: Use TaskId instead of String for the taskId field in TaskMetadata

2021-05-20 Thread Guozhang Wang
A quick note: since we changed the constructor of TaskMetadata as well in the PR, we'd need to add that in the KIP wiki as well. Personally I think it is okay to just replace the constructor as you did in the PR rather than adding/deprecating --- I would even advocate for replacing the `taskId`

Re: [VOTE] KIP-740: Use TaskId instead of String for the taskId field in TaskMetadata

2021-05-20 Thread Guozhang Wang
Thanks Sophie, I like the current proposal better compared to adding a new TaskInfo class. +1 ! Guozhang On Wed, May 19, 2021 at 4:58 PM Sophie Blee-Goldman wrote: > Just a friendly ping to please check out the finalized proposal of the KIP > and (re)cast your votes > > Thanks! > Sophie > > On