Re: [VOTE] KIP-919: Allow AdminClient to Talk Directly with the KRaft Controller Quorum and add Controller Registration

2023-07-27 Thread Ismael Juma
Sounds good to me. Ismael On Thu, Jul 27, 2023, 6:32 PM Colin McCabe wrote: > I would incline towards plural, but I honestly don't feel that strongly > about it. I will just change it to --bootstrap-controller for now, to match > --bootstrap-server. Perhaps we can discuss this further in a

Re: [VOTE] KIP-919: Allow AdminClient to Talk Directly with the KRaft Controller Quorum and add Controller Registration

2023-07-27 Thread Colin McCabe
I would incline towards plural, but I honestly don't feel that strongly about it. I will just change it to --bootstrap-controller for now, to match --bootstrap-server. Perhaps we can discuss this further in a later KIP, if people are inclined... Colin On Thu, Jul 27, 2023, at 07:13, Ron

Re: [VOTE] KIP-919: Allow AdminClient to Talk Directly with the KRaft Controller Quorum and add Controller Registration

2023-07-27 Thread Ron Dagostino
> support plural for both and the singular one is just an alias for > compatibility I like that approach. I can never remember what works, so I would prefer to just use what I think works and then have it work. Ron On Thu, Jul 27, 2023 at 8:33 AM Ismael Juma wrote: > > I think singular was

Re: [VOTE] KIP-919: Allow AdminClient to Talk Directly with the KRaft Controller Quorum and add Controller Registration

2023-07-27 Thread Ismael Juma
I think singular was used because that's the common case for the cli tools. To be honest, it's actually a bit more confusing to have both singular and plural for the cli tools and you have to remember the exact version for each one. We should either support plural for both and the singular one is

Re: [VOTE] KIP-919: Allow AdminClient to Talk Directly with the KRaft Controller Quorum and add Controller Registration

2023-07-26 Thread Colin McCabe
Hi all, With binding +1s from Ron, David, Divij, ziming, and Luke, the vote passes. Thanks, everyone. Best, Colin On Wed, Jul 26, 2023, at 16:02, Colin McCabe wrote: > On Wed, Jul 26, 2023, at 07:09, Ron Dagostino wrote: >> Thanks, Colin. +1 (binding) from me. >> >> I will note that Ziming

Re: [VOTE] KIP-919: Allow AdminClient to Talk Directly with the KRaft Controller Quorum and add Controller Registration

2023-07-26 Thread Colin McCabe
On Wed, Jul 26, 2023, at 07:09, Ron Dagostino wrote: > Thanks, Colin. +1 (binding) from me. > > I will note that Ziming mentioned in the DISCUSS thread that "There is > a mistake that we use `--bootstrap-server` instead of > `--bootstrap-server(s)`, so should we also change the new argument >

Re: [VOTE] KIP-919: Allow AdminClient to Talk Directly with the KRaft Controller Quorum and add Controller Registration

2023-07-26 Thread Ron Dagostino
Thanks, Colin. +1 (binding) from me. I will note that Ziming mentioned in the DISCUSS thread that "There is a mistake that we use `--bootstrap-server` instead of `--bootstrap-server(s)`, so should we also change the new argument `--bootstrap-controller` (no s).". I agree that this is an

Re: [VOTE] KIP-919: Allow AdminClient to Talk Directly with the KRaft Controller Quorum and add Controller Registration

2023-07-26 Thread David Arthur
Thanks for driving this KIP, Colin! +1 binding -David On Wed, Jul 26, 2023 at 8:58 AM Divij Vaidya wrote: > +1 (binding) > > -- > Divij Vaidya > > > On Wed, Jul 26, 2023 at 2:56 PM ziming deng > wrote: > > > > +1 (binding) from me. > > > > Thanks for the KIP! > > > > -- > > Ziming > > > > >

Re: [VOTE] KIP-919: Allow AdminClient to Talk Directly with the KRaft Controller Quorum and add Controller Registration

2023-07-26 Thread Divij Vaidya
+1 (binding) -- Divij Vaidya On Wed, Jul 26, 2023 at 2:56 PM ziming deng wrote: > > +1 (binding) from me. > > Thanks for the KIP! > > -- > Ziming > > > On Jul 26, 2023, at 20:18, Luke Chen wrote: > > > > +1 (binding) from me. > > > > Thanks for the KIP! > > > > Luke > > > > On Tue, Jul 25,

Re: [VOTE] KIP-919: Allow AdminClient to Talk Directly with the KRaft Controller Quorum and add Controller Registration

2023-07-26 Thread ziming deng
+1 (binding) from me. Thanks for the KIP! -- Ziming > On Jul 26, 2023, at 20:18, Luke Chen wrote: > > +1 (binding) from me. > > Thanks for the KIP! > > Luke > > On Tue, Jul 25, 2023 at 1:24 AM Colin McCabe wrote: > >> Hi all, >> >> I'd like to start the vote for KIP-919: Allow

Re: [VOTE] KIP-919: Allow AdminClient to Talk Directly with the KRaft Controller Quorum and add Controller Registration

2023-07-26 Thread Luke Chen
+1 (binding) from me. Thanks for the KIP! Luke On Tue, Jul 25, 2023 at 1:24 AM Colin McCabe wrote: > Hi all, > > I'd like to start the vote for KIP-919: Allow AdminClient to Talk Directly > with the KRaft Controller Quorum and add Controller Registration. > > The KIP is here:

[VOTE] KIP-919: Allow AdminClient to Talk Directly with the KRaft Controller Quorum and add Controller Registration

2023-07-24 Thread Colin McCabe
Hi all, I'd like to start the vote for KIP-919: Allow AdminClient to Talk Directly with the KRaft Controller Quorum and add Controller Registration. The KIP is here: https://cwiki.apache.org/confluence/x/Owo0Dw Thanks to everyone who reviewed the proposal. best, Colin