[GitHub] maven issue #93: MNG-5889 - adding logic that looks for the file argument an...

2016-09-15 Thread rpatrick00
Github user rpatrick00 commented on the issue: https://github.com/apache/maven/pull/93 Submitting a new pull request... https://github.com/apache/maven/pull/94 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] maven pull request #94: MNG-5889 - adding logic that looks for the file argu...

2016-09-15 Thread rpatrick00
GitHub user rpatrick00 opened a pull request: https://github.com/apache/maven/pull/94 MNG-5889 - adding logic that looks for the file argument and starts t… …he search for the .mvn directory at the location of the specified POM when present You can merge this pull request into

[GitHub] maven pull request #93: MNG-5889 - adding logic that looks for the file argu...

2016-09-15 Thread rpatrick00
Github user rpatrick00 closed the pull request at: https://github.com/apache/maven/pull/93 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] maven issue #93: MNG-5889 - adding logic that looks for the file argument an...

2016-09-15 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven/pull/93 @rpatrick00 pls squash it to one commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] maven issue #93: MNG-5889 - adding logic that looks for the file argument an...

2016-09-15 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven/pull/93 I want to test it as well and then push it to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] maven issue #93: MNG-5889 - adding logic that looks for the file argument an...

2016-09-15 Thread rpatrick00
Github user rpatrick00 commented on the issue: https://github.com/apache/maven/pull/93 I tested this on both Linux and Windows, but most of the testing was on Windows simply because Windows CMD scripts are challenging to get right. The sh script is much simpler... --- If your

[GitHub] maven issue #93: MNG-5889 - adding logic that looks for the file argument an...

2016-09-15 Thread aheritier
Github user aheritier commented on the issue: https://github.com/apache/maven/pull/93 +1000 for this change (as far as it is tested/validated) This problem of using -f on CI servers (and non only) is very common and it makes the usage of .mvn folders useless. The problem is to

[GitHub] maven issue #93: MNG-5889 - adding logic that looks for the file argument an...

2016-09-15 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven/pull/93 IIUC this might be useful in CI because you may run `mvn deploy -f /path/to/project/pom.xml` and the discovery would be made in `/path/to/project/.mvn` as well. AFAIK Maven is not 2 processes running

Re: New warnings with Maven 3.4-SNAP

2016-09-15 Thread Stephane Nicoll
Awesome Christian, it's much better now. Thank you! On Wed, Sep 14, 2016 at 3:48 PM, Christian Schulte wrote: > Am 09/14/16 um 13:50 schrieb Stephane Nicoll: > > Dependency 'org.springframework.cloud:spring-cloud-commons:jar' has > > conflicting dependency management from ' >

[GitHub] maven-surefire issue #119: Make JUnit4VersionsIT acutally use the versions s...

2016-09-15 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/119 @britter Pls contact INFRA team [1] in order to require the permissions. Why you are not in `pmc-member-votes.txt` and `maven/private/board-reports/*.txt`. Why we did not add your name

[GitHub] maven-surefire pull request #119: Make JUnit4VersionsIT acutally use the ver...

2016-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven-surefire/pull/119 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] maven issue #93: MNG-5889 - adding logic that looks for the file argument an...

2016-09-15 Thread rpatrick00
Github user rpatrick00 commented on the issue: https://github.com/apache/maven/pull/93 Did you not understand what I said? .mvn/jvm.config might look like this: -Xmx2048m -Xms1024m -XX:MaxPermSize=512m -Djava.awt.headless=true If I move the

[GitHub] maven issue #93: MNG-5889 - adding logic that looks for the file argument an...

2016-09-15 Thread jochenw
Github user jochenw commented on the issue: https://github.com/apache/maven/pull/93 Then possibly a good first step would be to move that logic from the scripts to the Java Main class. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] maven issue #93: MNG-5889 - adding logic that looks for the file argument an...

2016-09-15 Thread rpatrick00
Github user rpatrick00 commented on the issue: https://github.com/apache/maven/pull/93 Because the maven shell scripts are finding the .mvn directory before starting java in order to find the relevant .mvn/jvm.config to process any java command-line options that may be found in it.

[GitHub] maven issue #93: MNG-5889 - adding logic that looks for the file argument an...

2016-09-15 Thread jochenw
Github user jochenw commented on the issue: https://github.com/apache/maven/pull/93 I wonder, whether this couldn't be handled at the Java level? If so, there would be no need to change script files, making them even more complex than they already are. --- If your project is set

[GitHub] maven-surefire issue #119: Make JUnit4VersionsIT acutally use the versions s...

2016-09-15 Thread britter
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/119 @Tibor17 I don't have commit access to the maven repositories. You will have to merge it for me :-) --- If your project is set up for it, you can reply to this email and have your reply