Re: Dependency resolution broken on Wagon master with Maven 3.4.0-SNAPSHOT

2016-12-14 Thread Stephen Connolly
On Wednesday, 14 December 2016, Michael Osipov wrote: > Am 2016-12-14 um 00:46 schrieb Christian Schulte: > >> That's MRESOLVER-9. Fixed the POMs with this >> > a=commit;h=f244ece2eee01500e4b1bc334b8dcd35b47f9422>

Re: Question regarding repository overriding.

2016-12-14 Thread Stephen Connolly
On Thursday, 15 December 2016, Christian Schulte wrote: > Am 12/15/16 um 01:09 schrieb Christian Schulte: > > I would have expected the nearest wins strategy as well, BTW. Seems to > > not make sense for the resolver to just ignore repository declarations > > matching an ID

Re: Question regarding repository overriding.

2016-12-14 Thread Christian Schulte
Am 12/15/16 um 01:09 schrieb Christian Schulte: > I would have expected the nearest wins strategy as well, BTW. Seems to > not make sense for the resolver to just ignore repository declarations > matching an ID already discovered at another level. Well. Makes perfect sense for the resolver to do

[GitHub] maven-plugins pull request #101: getProjectModules: IllegalStateException

2016-12-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven-plugins/pull/101 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] maven-plugins pull request #101: getProjectModules: IllegalStateException

2016-12-14 Thread seusher
GitHub user seusher opened a pull request: https://github.com/apache/maven-plugins/pull/101 getProjectModules: IllegalStateException In my project, we have multiple modules, some of which also contain other modules. When building one specific module (which itself had child

Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

2016-12-14 Thread Christian Schulte
Am 12/15/16 um 01:15 schrieb Christian Schulte: > Am 12/14/16 um 23:29 schrieb Michael Osipov: >> I just hit the same issue with the Maven Clean Plugin: >> plexus-container-default is missing on the classpath. >> >> I think that Christian does the right thing, either adjusting code to >>

Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

2016-12-14 Thread Christian Schulte
Am 12/14/16 um 23:29 schrieb Michael Osipov: > I just hit the same issue with the Maven Clean Plugin: > plexus-container-default is missing on the classpath. > > I think that Christian does the right thing, either adjusting code to > documentation or the other way around. We just need to agree

Re: Question regarding repository overriding.

2016-12-14 Thread Christian Schulte
I would have expected the nearest wins strategy as well, BTW. Seems to not make sense for the resolver to just ignore repository declarations matching an ID already discovered at another level. - To unsubscribe, e-mail:

Re: Question regarding repository overriding.

2016-12-14 Thread Christian Schulte
Am 12/14/16 um 20:41 schrieb Stephen Connolly: > definition nearest to the project should win is the principle that has been > in force... That's what Maven core developers had in mind. Maven resolver developers did the opposite. See this class:

Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

2016-12-14 Thread Christian Schulte
Just an additional information. Maven core and the resolver are not behaving consistently in that area and also not in the "repository overriding" area. As you may have noticed, I am just heading for consistency. I am having a hard time figuring out why the core has not been updated to reflect

Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

2016-12-14 Thread Christian Schulte
Am 12/15/16 um 00:19 schrieb Christian Schulte: > -ldm,--legacy-dependency-management > Use Maven 2 dependency management behaviour. Can also be activated by > using -Dmaven.legacyDependencyManagement=true. > > There are a bunch of issues in JIRA affecting dependency management. > That option

Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

2016-12-14 Thread Christian Schulte
Am 12/14/16 um 22:57 schrieb Robert Scholte: > Digging into this case before the change: > > The 4 related modules ignoring the versions: > > org.apache.maven.wagon:wagon:pom > { > dependencyManagement { > dependencies { >

Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

2016-12-14 Thread Michael Osipov
Am 2016-12-14 um 22:57 schrieb Robert Scholte: Digging into this case before the change: The 4 related modules ignoring the versions: org.apache.maven.wagon:wagon:pom { dependencyManagement { dependencies { org.apache.maven.wagon:wagon-provider-test:compile

Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

2016-12-14 Thread Robert Scholte
Digging into this case before the change: The 4 related modules ignoring the versions: org.apache.maven.wagon:wagon:pom { dependencyManagement { dependencies { org.apache.maven.wagon:wagon-provider-test:compile

Re: Dependency resolution broken on Wagon master with Maven 3.4.0-SNAPSHOT

2016-12-14 Thread Michael Osipov
Am 2016-12-14 um 00:46 schrieb Christian Schulte: That's MRESOLVER-9. Fixed the POMs with this commit. This is what is lacking documentation the most. Does the commit message clarify

Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

2016-12-14 Thread Michael Osipov
Am 2016-12-14 um 18:14 schrieb Christian Schulte: Am 12/14/16 um 17:57 schrieb Robert Scholte: Hi, I read the comment but I'm not sure I follow. The original setup is a widely used pattern: give dependencies which should always have the test-scope this scope in the dependencyManagement of the

[GitHub] maven-plugins pull request #100: Fixed MEAR-217: Correct match of snapshot v...

2016-12-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven-plugins/pull/100 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: 2nd question regarding repository overriding.

2016-12-14 Thread Stephen Connolly
profiles are applied IMHO *after* the current pom... and whatever is in the current pom overrides dependencies... On 13 December 2016 at 01:57, Christian Schulte wrote: > Am 12/13/16 um 02:32 schrieb Christian Schulte: > > Consider these projects: > > > > P1 declares a

Re: Question regarding repository overriding.

2016-12-14 Thread Stephen Connolly
definition nearest to the project should win is the principle that has been in force... when the definition is coming from a dependency, however, the concept of distance can become confused - especially given how the dependency graph is version conflict reduced On 13 December 2016 at 01:32,

Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

2016-12-14 Thread Christian Schulte
Am 12/14/16 um 17:57 schrieb Robert Scholte: > Hi, > > I read the comment but I'm not sure I follow. The original setup is a > widely used pattern: give dependencies which should always have the > test-scope this scope in the dependencyManagement of the parent. > Considering the case below it

Re: maven-wagon git commit: [MRESOLVER-9] DefaultDependencyCollector does not correctly handle dependency management.

2016-12-14 Thread Robert Scholte
Hi, I read the comment but I'm not sure I follow. The original setup is a widely used pattern: give dependencies which should always have the test-scope this scope in the dependencyManagement of the parent. Considering the case below it must be possible to give easymock the test-scope (I

Re: Jenkins: Modules changed, recalculating dependency graph

2016-12-14 Thread Robert Scholte
Fixed. You should be able to configure the Jenkins jobs Robert On Tue, 13 Dec 2016 18:43:53 +0100, Robert Scholte wrote: As pmc-chair I should be able to grant access[1], but I don't. I've asked infrastructure@a.o for help Robert [1]

Re: Documenting Maven 3.4.0

2016-12-14 Thread Manfred Moser
Yes .. where necessary only though. And NOT going back to 2.x... Manfred Anders Hammar wrote on 2016-12-13 22:18: > Stating any differences campared to older versions would be good as well. > > /Anders (mobile) > > Den 14 dec. 2016 01:41 skrev "Manfred Moser" : >

Re: [VOTE] Release Apache Maven Dependency Plugin version 3.0.0

2016-12-14 Thread Hervé BOUTEMY
+1 Regards, Hervé Le lundi 12 décembre 2016, 23:20:56 CET Robert Scholte a écrit : > Hi, > > We solved 25 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317227 > rsion=12330458=Text > > There are still a couple of issues left in JIRA: >

Re: [VOTE] Release Apache Maven Dependency Plugin version 3.0.0

2016-12-14 Thread Anders Hammar
+1 Verified analyze mojo with Maven 3.3.3, IBM JDK 1.7 on Windows 7. Also checked staged doc site. One small issue with 404 link found (MDEP-547); not a blocker. /Anders On Mon, Dec 12, 2016 at 11:20 PM, Robert Scholte wrote: > Hi, > > We solved 25 issues: >