Re: Understanding MNG-6209 (was: [VOTE] Release Apache Maven 3.5.1)

2017-09-24 Thread Stephen Connolly
Right now I have a successful vote to release 3.5.1 I also have two issues changing classloader behaviours in ways that may surprise people. I am not against releasing what we have as a bug fix release - if these are actual bugs. I am not against fixing inconsistencies with the site

Re: Understanding MNG-6209 (was: [VOTE] Release Apache Maven 3.5.1)

2017-09-24 Thread Igor Fedorenko
Lets decide the agenda first, then who you need to attend (assuming you are driving this discussion/decision), then pick the time that works. >From my side, I still don't understand the problems we are trying to solve. If this is the lacking documentation and general "uncomfort" to mess with

Re: Understanding MNG-6209 (was: [VOTE] Release Apache Maven 3.5.1)

2017-09-24 Thread Anders Hammar
To add to the topic I think that if we fix/change the class loading, we shouldn't do that in a bug fix release. I'd rather see a 3.6.0 with it thought through, fixed and documented (could be in ITs). The arguing being that a bug fix release shouldn't cause new issues in plugins etc. /Anders On

Re: Understanding MNG-6209 (was: [VOTE] Release Apache Maven 3.5.1)

2017-09-24 Thread Stephen Connolly
I wonder should we do a hangout to decide what you do? What times on Monday work best? I can maybe do 8:30-9:30pm Irish time https://www.timeanddate.com/worldclock/meetingdetails.html?year=2017=9=25=19=30=0=78=37=179 But we’d need to decide who we need and an actual agenda. If Monday is too

Re: Understanding MNG-6209 (was: [VOTE] Release Apache Maven 3.5.1)

2017-09-24 Thread Igor Fedorenko
See my answers/comments inline On Sun, Sep 24, 2017, at 12:07 PM, Stephen Connolly wrote: > https://maven.apache.org/guides/mini/guide-maven-classloading.html says: > > > When a build plugin is executed, the thread's context classloader is set > to the plugin classloader. > > So we'll need to

Re: Understanding MNG-6209 (was: [VOTE] Release Apache Maven 3.5.1)

2017-09-24 Thread Robert Scholte
On Sun, 24 Sep 2017 19:36:15 +0200, Stephen Connolly wrote: On Sun 24 Sep 2017 at 17:44, Robert Scholte wrote: Are these questions we can/should answer within a couple of days? I'm not aware of somebody hitting the regression as

Re: Understanding MNG-6209 (was: [VOTE] Release Apache Maven 3.5.1)

2017-09-24 Thread Stephen Connolly
On Sun 24 Sep 2017 at 17:44, Robert Scholte wrote: > Are these questions we can/should answer within a couple of days? > I'm not aware of somebody hitting the regression as caused by MNG-5742 > other than Igor. > However, we've seen a couple of changed behavior clearly

Re: Understanding MNG-6209 (was: [VOTE] Release Apache Maven 3.5.1)

2017-09-24 Thread Robert Scholte
Are these questions we can/should answer within a couple of days? I'm not aware of somebody hitting the regression as caused by MNG-5742 other than Igor. However, we've seen a couple of changed behavior clearly caused by MNG-6209 (not answering if this intended or not) We could also make

Re: Understanding MNG-6209 (was: [VOTE] Release Apache Maven 3.5.1)

2017-09-24 Thread Stephen Connolly
https://maven.apache.org/guides/mini/guide-maven-classloading.html says: > When a build plugin is executed, the thread's context classloader is set to the plugin classloader. So we'll need to fix something somewhere...