[ANN] Apache Maven Assembly Plugin 3.3.0 Released

2020-04-30 Thread Robert Scholte
The Apache Maven team is pleased to announce the release of the Apache Maven Assembly Plugin, version 3.3.0 The Assembly Plugin for Maven enables developers to combine project output into a single distributable archive that also contains dependencies, modules, site documentation, and other

[RESULT] [VOTE] Release Apache Maven Assembly Plugin version 3.3.0

2020-04-30 Thread Robert Scholte
Hi, The vote has passed with the following result: +1 : Robert Scholte, Hervé BOUTEMY, Karl Heinz Marbaise, Eric Lilja PMC quorum: reached I will promote the artifacts to the central repo. On 30-4-2020 20:24:29, Eric Lilja wrote: +1 non-binding Nice to see a release of this plugin! - Eric

Re: [VOTE] Release Apache Maven Assembly Plugin version 3.3.0

2020-04-30 Thread Eric Lilja
+1 non-binding Nice to see a release of this plugin! - Eric Lilja On Thu, Apr 30, 2020 at 8:09 PM Karl Heinz Marbaise wrote: > Hi, > > +1 from me > > > Kind regards > Karl Heinz Marbaise > On 27.04.20 20:19, Robert Scholte wrote: > > Hi, > > > > We solved 10 issues: > > >

Re: [VOTE] Release Apache Maven Assembly Plugin version 3.3.0

2020-04-30 Thread Karl Heinz Marbaise
Hi, +1 from me Kind regards Karl Heinz Marbaise On 27.04.20 20:19, Robert Scholte wrote: Hi, We solved 10 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317220=12344774=Text There are still a couple of issues left in JIRA:

Re: Maven Filtering Plugin should avoid overwriting even when filtering

2020-04-30 Thread Robert Scholte
The main different is the moment you know you have to write the file. If there's zero interpolation/filtering, then there's no need to write the file. As soon as you detect interpolation/filtering you can start overwriting the original file. The challenge is probably to fit this concept in the

Re: source directory layout for multirelease jars

2020-04-30 Thread Robert Scholte
Hi Benjamin, You're confusing me "Sadly, you cannot just add executions to the maven compiler plugin." Why not? The design of the pom contains support of multiple executions within the same plugin "Almost no IDE supports it, ..." I think they all do. And even if they don't, they should. I

Re: Maven Filtering Plugin should avoid overwriting even when filtering

2020-04-30 Thread Rob Oxspring
> On 30 Apr 2020, at 07:38, Robert Scholte wrote: > > I prefer to see an in memory solution. Well if it’s reasonable to assume that filtered files are always small then we could use replace the temporary file in my solution with an in memory buffer... but I’m not sure that’s what you’re

Re: source directory layout for multirelease jars

2020-04-30 Thread Benjamin Marwell
Hi, to make the story a bit shorter - for most libraries it would be sufficient to add a way to include a module descriptor at "META-INF/versions/9/module-info.class" while still staying at java 8. Most libraries will stick to java 8 or even 7 for quite a time. Sadly, you cannot just add

Re: Maven Filtering Plugin should avoid overwriting even when filtering

2020-04-30 Thread Robert Scholte
I prefer to see an in memory solution. Key should be to detect if filtering is applied, which is done in the  MultiDelimiterInterpolatorFilterReaderLineEnding[1] Once a value has been interpolated, you must rewrite the file, otherwise you shouldn't. I hope this is a push in the right direction

Re: [VOTE] Release Apache Maven Assembly Plugin version 3.3.0

2020-04-30 Thread Hervé BOUTEMY
+1 this build is reproducible with JDK 8 and CRLF newlines for example, on my Linux box, extracting from the -source-release.zip archive (to have CRLF newlines on source): rm DEPENDENCIES LICENSE NOTICE && mvn -Papache-release,run-its -Dgpg.skip verify buildinfo:buildinfo

Re: [VOTE] Release Apache Maven Assembly Plugin version 3.3.0

2020-04-30 Thread Robert Scholte
I need more PMC votes. This version contains an improvement to make it easier to keep to maven and maven-wrapper scripts in sync. thanks, Robert On 29-4-2020 20:28:08, Robert Scholte wrote: +1 On 27-4-2020 20:19:41, Robert Scholte wrote: Hi, We solved 10 issues: