Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/161
@slachiewicz I am ready to merge, @rfscholte [requested a unit
test](https://www.mail-archive.com/dev@maven.apache.org/msg116360.html). Can
you add one and I will merge it with a smile
Github user michael-o commented on the issue:
https://github.com/apache/maven-wagon/pull/37
There is bit of a chaos now. I know that the Deploy Plugin supports
something similar and people are requesting the same feature for this problem
area. I'll collect and have a look
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/136
@hboutemy Tested your branch. Great improvement to the PR! +1
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/136
Looks good to me.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/114
I don't might to pick this up, but it won't happen before Sep for personal
priorities.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/127
JIRA issue please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user michael-o commented on the issue:
https://github.com/apache/maven-surefire/pull/141
2.20.1 will go first.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/116
@jdillon Thank you for the contribution anyway!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/116
@jdillon Igor merged his PR contained your fix. This PR is obsolete now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/116
Thanks for the explanation. So it is not a prerequisite directly. I'd still
insist for an JIRA because I need another committer to second this and have
this in our release notes. Do you have
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/116
Just to be clear, Igor's change is s prerequisite to your issue? If so, we
need two tickets. The IT assures that nothing will break your fix -- no more,
no less.
---
If your project is set up
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/116
@jdillon I'd like to merge this but need a JIRA issue. At best, an IT too.
Can you provide a simple one?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/116
@ifedorenko That's the only way w/o INFRA: commit message "This closes
#xy". You cannot manually close via website. That's what I was trying to say.
---
If your project is set up for i
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/116
@ifedorenko Closing PRs requires a ticket with INFRA on JIRA.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/116
@jdillon Such a change is not suitable for a patch version in my opinion.
Please file a JIRA issue for your local branch and push a branch for that.
---
If your project is set up for it, you can
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/115
The diff is huge, you have a line ending issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven-integration-testing/pull/21#discussion_r115065672
--- Diff: core-it-suite/src/test/resources/mng-6127/plugin/pom.xml ---
@@ -0,0 +1,55 @@
+
+
+
+
+http
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven-integration-testing/pull/21#discussion_r115049986
--- Diff: core-it-suite/src/test/resources/mng-6127/plugin/pom.xml ---
@@ -0,0 +1,55 @@
+
+
+
+
+http
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/114
I think yes, grep doesn't do different. Please try the patch thoroughly!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/114
Two issues:
1. Unfortunately, Commons CLI does not offer valid values. If it would, it
would fail if the option value is wrong. I would do so too.
2. You blindly `return` from `always
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/114
They are several issues. People are used to
[GNU](https://www.gnu.org/software/grep/manual/grep.html#General-Output-Control)
and [BSD](https://www.freebsd.org/cgi/man.cgi?query=grep=opensearch
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/114
I will comment shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/101
Created as MNG-6165.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/100
Testing your changes now:
https://builds.apache.org/job/maven-3.x-jenkinsfile/job/MNG-6146/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/100
Testing your PR, two issues:
1. Please resolve the marked conflicts from above
2. One test fails because you missed to rename a directory
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/104
Do this:
git checkout master
git checkout -b MNG-5961
git cherry-pick
git push
Wait for the Jenkins build to finish, get approval
git
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/104
I am fine with this PR. You have to raise the issue on the dev mailing list
to have at least someone who seconds it. If someone does, after your branch
passes all tests, go ahead and merge
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/100
Can you rebase your changes and squash into one commit? I want to pull them
in with
[MNG-6146](https://issues.apache.org/jira/browse/MNG-6146?src=confmacro).
---
If your project is set up
Github user michael-o commented on the issue:
https://github.com/apache/maven-indexer/pull/12
Looking at your changes, they are not really related. They all require
appropriate JIRA issues and seperate PRs.
---
If your project is set up for it, you can reply to this email and have
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/103
So why not named them: excident => `addDependsOn` and incident =>
`addDependenedBy` or similar? Just like JIRA linking: "is dependent upon" and
"depends upon".
---
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/100
You have renamed to `mngt`, but missed to rename physical directories also.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/103
I assume that due to the directed graph nature, it shall decribe all edges
I depent, but have not a common parent vertex (see definition for incident). My
graph theory knowledge is highly rusty
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/103
Incident comes from the graph theory:
https://en.wikipedia.org/wiki/Degree_%28graph_theory%29, but I cannot find
excident as the opposide term for.
---
If your project is set up for it, you can
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/101
This is fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/103
The problem for this word is that it is not even listed in not in the
Oxford nor Merriam-Webster dictionary. Even if you are a native English
speaker, it be quite difficult to understand incident
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/102
This PR cannot be merged until `DAG` from Plexus Utils is fixed. Can you
open a PR overthere?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/100
I am about to mere this PR, but for one commit which has to be undone. Then
I will check the rest.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven/pull/100#discussion_r98353361
--- Diff: maven-core/src/main/resources/META-INF/plexus/components.xml ---
@@ -122,8 +122,8 @@ under the License.
_cipher
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven/pull/100#discussion_r98353293
--- Diff: maven-core/src/main/resources/META-INF/plexus/components.xml ---
@@ -122,8 +122,8 @@ under the License.
_cipher
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/100
@jsoref I am somewhat confused by the new PRs. I wanted two distinct PRs.
Can you do that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/100
Hi Josh, thanks for the PR. I have seen that you did the same for Tomcat.
We should split this into two parts:
1. non-API change
2. API change with deprecations and proper docs
Github user michael-o commented on the issue:
https://github.com/apache/maven-wagon/pull/22
#30 introduced an {{FTPSWagon}}. Is this PR obsolete? I know that FTPS !=
FTP with TLS, isn't it?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user michael-o commented on the issue:
https://github.com/apache/maven-wagon/pull/28
Please create a JIRA issue for that an I will merge the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user michael-o commented on the issue:
https://github.com/apache/maven-wagon/pull/32
Please squash them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven-wagon/pull/32#discussion_r95234762
--- Diff:
wagon-providers/wagon-ssh/src/main/java/org/apache/maven/wagon/providers/ssh/jsch/ScpWagon.java
---
@@ -297,7 +297,7 @@ public void
Github user michael-o commented on the issue:
https://github.com/apache/maven-wagon/pull/32
Is the value in bytes? If though, this truly can fail with intergers.
Please open a JIRA issue for that.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user michael-o commented on the issue:
https://github.com/apache/maven-wagon/pull/18
One could also consider merging both and differentiate only by the URL, if
this is possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user michael-o commented on the issue:
https://github.com/apache/maven-wagon/pull/18
Is this a complete replacement for Jackrabbit for the Wagon provider?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/49
@leonyxb Open a new JIRA issue for this regression. At best with a PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user michael-o commented on the issue:
https://github.com/apache/maven-wagon/pull/27
I do agree, but still think that we can tweak Wagon HTTP to fail faster if
such a case happens. Your proxy is likely to use Apache HttpClient, just like
Wagon does. You could still suffer from
Github user michael-o commented on the issue:
https://github.com/apache/maven-wagon/pull/27
If it is not enough for unstable networks, provide PRs to make it
bullet-proof. Logs can always we enabled with `-X` and by tweaking the logging
configuration. Still not enough?
---
If your
Github user michael-o commented on the issue:
https://github.com/apache/maven-integration-testing/pull/15
@dantran Can you squash? I will have a look and will merge soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user michael-o commented on the issue:
https://github.com/apache/maven-wagon/pull/27
Why is `wagon-http` and `wagon-http-lightweight` not enough?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user michael-o commented on the issue:
https://github.com/apache/maven-wagon/pull/31
Looks very good. Please squash and I will merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/94
@hboutemy Are you waiting for the Jenkins build to close the JIRA issue?
@rpatrick00 Thank you for the contribution.
---
If your project is set up for it, you can reply to this email and have your
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/94
@hboutemy I would at least check for `jvm.config` because this is expanded
in the script itself.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/94
@rpatrick00 Can you shed some light here? What do you to properly picked
up? `extensions.xml`, `maven.config`, and `jvm.config`, right?
---
If your project is set up for it, you can reply
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/94
@hboutemy I am bit confused by the IT. The issue was about having `.mvn`
properly located to expand `maven.config`. I would expect some system property
to be added and retrieved. Am I wrong
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/94
@hboutemy Thanks for helping out!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/94
I would rather see @rpatrick00 providing the IT.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/94
I think this really deserves an IT too. The shell script is fine. Can't
just on the command script, I am virtually illiterate here. I trust @rpatrick00
here. Willing to blindly to merge when
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/96
Hilarious, I had my fun with.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/95
> Should maven-aether-provider be renamed?
From my POM, yes, but in a separate ticket.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven/pull/94#discussion_r86662937
--- Diff: apache-maven/src/bin/mvn.cmd ---
@@ -86,19 +86,65 @@ set MAVEN_CMD_LINE_ARGS=%*
set MAVEN_PROJECTBASEDIR=%MAVEN_BASEDIR
Github user michael-o commented on the issue:
https://github.com/apache/maven-archetype/pull/10
@mryan43 Please close the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user michael-o commented on the issue:
https://github.com/apache/maven-archetype/pull/10
Agreed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user michael-o commented on the issue:
https://github.com/apache/maven-archetype/pull/10
Where is the need for this fix? `O` comes after `J`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/87
Here is the Maven change:
https://github.com/michael-o/maven/commit/fd1f665225cea9cdee84cad3de193f771d82e42d
---
If your project is set up for it, you can reply to this email and have your
reply
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/87
The branch is already in preparation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/87
Here is the Aether change:
https://github.com/michael-o/aether-core/commit/942fc4122d803225c2b465831ef1378bb9946669
---
If your project is set up for it, you can reply to this email and have your
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/87
My patch works:
Downloaded from central:
https://repo.maven.apache.org/maven2/org/sonatype/forge/forge-parent/5/forge-parent-5.pom
(8.4 kB at 55 kB/s)
Downloading from
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/87
You can always watch dev@maven.apache.org.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/87
I just have patched Aether, let's see wether Maven will accept
1.1.0-SNAPSHOT.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/87
@rajivpjs I think I know the spot to fix in Aether, though I am not
familiar with the Aether code. Give me 15 min.
---
If your project is set up for it, you can reply to this email and have your
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/87
> "Since Aether is currently in transition to us" - what do you mean? Is
Aether going to come to Apache When do you think we will be able to fix this?
I think so, we will at
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/87
This is the snapshot: `Downloading from central:
https://repository.apache.org/snapshots/org/apache/maven/maven-embedder/3.4.0-SNAPSHOT/maven-embedder-3.4.0-20160712.211951-154.pom
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/87
Just, it does not work. The list you are using is a static list of ordered
repos to be tried. The first one does not denote the one to be used. From Maven
build:
[INFO
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/87
[Squashing commits](http://stackoverflow.com/a/5189600/696632). We have a
complete test set of IT [here](https://maven.apache.org/core-its/). There is a
[bus
load](https://github.com/apache/maven
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/87
This looks better. Can you squash the commit? Additionally, this requires
an integration test with three repos: central (by default), and two others.
Preferably file-based. We'd see that this works
Github user michael-o commented on the issue:
https://github.com/apache/maven-archetype/pull/11
@AlesRybak Merged. Please close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/87
Unusable. `getLocalRepository()` always gives you *your* local repository
on disk. This is not the remote repository Aether is pulling from or pushing
to. Hence, you will always see `...local
Github user michael-o commented on the issue:
https://github.com/apache/maven-archetype/pull/8
I have found the issue on the line ending. Will elaborate later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user michael-o commented on the issue:
https://github.com/apache/maven-archetype/pull/8
The IT does not pass.
`target\it\build-archetype-and-run-its-with-existing-parent\target\test-classes\projects\basic\project\project\basic\pom.xml`
has mixed line endings while
`target
Github user michael-o commented on the issue:
https://github.com/apache/maven-archetype/pull/8
@kwin Please have a look at the inline comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven-archetype/pull/8#discussion_r70186236
--- Diff:
maven-archetype-plugin/src/main/java/org/apache/maven/archetype/mojos/IntegrationTestMojo.java
---
@@ -84,6 +90,43
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven-archetype/pull/8#discussion_r70186237
--- Diff:
maven-archetype-plugin/src/main/java/org/apache/maven/archetype/mojos/IntegrationTestMojo.java
---
@@ -84,6 +90,43
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven-archetype/pull/8#discussion_r70186234
--- Diff:
maven-archetype-plugin/src/main/java/org/apache/maven/archetype/mojos/IntegrationTestMojo.java
---
@@ -84,6 +90,43
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven-archetype/pull/8#discussion_r70186199
--- Diff:
maven-archetype-plugin/src/it/build-archetype-and-run-its-with-existing-parent/verify.bsh
---
@@ -0,0 +1,46
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven-archetype/pull/8#discussion_r70186193
--- Diff:
maven-archetype-plugin/src/it/build-archetype-and-run-its-with-existing-parent/verify.bsh
---
@@ -0,0 +1,46
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven-archetype/pull/8#discussion_r70186185
--- Diff:
maven-archetype-plugin/src/it/build-archetype-and-run-its-with-existing-parent/verify.bsh
---
@@ -0,0 +1,46
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven-archetype/pull/8#discussion_r70186177
--- Diff:
maven-archetype-plugin/src/it/build-archetype-and-run-its-with-existing-parent/src/test/resources/projects/basic/verify.groovy
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven-archetype/pull/8#discussion_r70186173
--- Diff:
maven-archetype-plugin/src/it/build-archetype-and-run-its-with-existing-parent/src/test/resources/projects/basic/reference/pom.xml
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven-archetype/pull/8#discussion_r70186157
--- Diff:
maven-archetype-plugin/src/it/build-archetype-and-run-its-with-existing-parent/src/test/resources/projects/archetype.pom.properties
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven-archetype/pull/8#discussion_r70186161
--- Diff:
maven-archetype-plugin/src/it/build-archetype-and-run-its-with-existing-parent/src/test/resources/projects/archetype.properties
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/maven-archetype/pull/8#discussion_r70186131
--- Diff:
maven-archetype-plugin/src/it/build-archetype-and-run-its-with-existing-parent/pom.xml
---
@@ -0,0 +1,63
Github user michael-o commented on the issue:
https://github.com/apache/maven-archetype/pull/8
@kwin Please squash your commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user michael-o commented on the issue:
https://github.com/apache/maven-archetype/pull/7
@mryan43 Please close.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user michael-o commented on the issue:
https://github.com/apache/maven-archetype/pull/7
@ptahchiev Merged. Watchout, there is a test error on master, not related
to this merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user michael-o commented on the issue:
https://github.com/apache/maven-archetype/pull/7
@ptahchiev Thanks for pinping, this got lost on my desk. I will have a look
later this day.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user michael-o commented on the issue:
https://github.com/apache/maven-integration-testing/pull/14
@barthel Can you also take care of the file names in the PR? `mng3092` to
`mng-6049`.
---
If your project is set up for it, you can reply to this email and have your
reply
1 - 100 of 293 matches
Mail list logo
