Github user rpatrick00 closed the pull request at:
https://github.com/apache/maven/pull/94
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user rpatrick00 commented on the issue:
https://github.com/apache/maven/pull/94
@hboutemy, sorry but both "==" and "=" seem to work fine on Oracle Linux
and MacOS (where I tested the sh script). Not sure which version of Linux
caused this b
Github user rpatrick00 commented on the issue:
https://github.com/apache/maven/pull/94
If you look at the shell script, it used to compute the "basedir" variable
starting at the current working directory and then search upwards for the .mvn
directory. Th
Github user rpatrick00 commented on the issue:
https://github.com/apache/maven/pull/94
I took a quick look at the MNG-5771 IT and it's not obvious to me exactly
what I need to do so if you can add this in a few minutes, that is probably the
best thing to do. If not, I will try
Github user rpatrick00 commented on the issue:
https://github.com/apache/maven/pull/94
@michael-o, while I have no problem contributing, I have no familiarity
with the maven-integration-test project so it will likely take me some time to
reverse engineer it enough to figure out how
Github user rpatrick00 commented on the issue:
https://github.com/apache/maven/pull/94
OK, addressed both comments from michael-o
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rpatrick00 commented on a diff in the pull request:
https://github.com/apache/maven/pull/94#discussion_r86667117
--- Diff: apache-maven/src/bin/mvn.cmd ---
@@ -86,19 +86,65 @@ set MAVEN_CMD_LINE_ARGS=%*
set MAVEN_PROJECTBASEDIR=%MAVEN_BASEDIR
Github user rpatrick00 commented on a diff in the pull request:
https://github.com/apache/maven/pull/94#discussion_r86667111
--- Diff: apache-maven/src/bin/mvn.cmd ---
@@ -86,19 +86,65 @@ set MAVEN_CMD_LINE_ARGS=%*
set MAVEN_PROJECTBASEDIR=%MAVEN_BASEDIR
Github user rpatrick00 commented on the issue:
https://github.com/apache/maven/pull/94
Pushed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user rpatrick00 commented on the issue:
https://github.com/apache/maven/pull/94
OK, I found and resolved the problem with the --file arg but am not seeing
the other problem you describe (see output below). Maybe my fix for the --file
arg resolved that one too?
Here
Github user rpatrick00 commented on the issue:
https://github.com/apache/maven/pull/93
@Tibor17, have you looked at the pull request? Any issues with merging it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rpatrick00 commented on the issue:
https://github.com/apache/maven/pull/93
Submitting a new pull request...
https://github.com/apache/maven/pull/94
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user rpatrick00 opened a pull request:
https://github.com/apache/maven/pull/94
MNG-5889 - adding logic that looks for the file argument and starts tâ¦
â¦he search for the .mvn directory at the location of the specified POM
when present
You can merge this pull request
Github user rpatrick00 closed the pull request at:
https://github.com/apache/maven/pull/93
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user rpatrick00 commented on the issue:
https://github.com/apache/maven/pull/93
I tested this on both Linux and Windows, but most of the testing was on
Windows simply because Windows CMD scripts are challenging to get right. The
sh script is much simpler...
---
If your
Github user rpatrick00 commented on the issue:
https://github.com/apache/maven/pull/93
Did you not understand what I said?
.mvn/jvm.config might look like this:
-Xmx2048m
-Xms1024m
-XX:MaxPermSize=512m
-Djava.awt.headless=true
If I move
Github user rpatrick00 commented on the issue:
https://github.com/apache/maven/pull/93
Because the maven shell scripts are finding the .mvn directory before
starting java in order to find the relevant .mvn/jvm.config to process any java
command-line options that may be found
GitHub user rpatrick00 reopened a pull request:
https://github.com/apache/maven/pull/93
MNG-5889 - adding logic that looks for the file argument and starts tâ¦
â¦he search for the .mvn directory at the location of the specified POM
when present
You can merge this pull request
Github user rpatrick00 commented on the issue:
https://github.com/apache/maven/pull/93
Fixing a small problem...will resubmit
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rpatrick00 closed the pull request at:
https://github.com/apache/maven/pull/93
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user rpatrick00 opened a pull request:
https://github.com/apache/maven/pull/93
MNG-5889 - adding logic that looks for the file argument and starts tâ¦
â¦he search for the .mvn directory at the location of the specified POM
when present
You can merge this pull request
21 matches
Mail list logo
