[GitHub] maven issue #136: [MNG-6302] logging the module count

Github user stephenc commented on the issue: https://github.com/apache/maven/pull/136 👍 --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven issue #69: MNG-5899 Reactor should use reduced dependency pom

Github user stephenc commented on the issue: https://github.com/apache/maven/pull/69 > If the shaded artifact is built as a submodule with a different artifact > ID, then the shade plugin can specify its DRP as its main POM. It lets > other projects depend on t

[GitHub] maven issue #69: MNG-5899 Reactor should use reduced dependency pom

Github user stephenc commented on the issue: https://github.com/apache/maven/pull/69 I know @jvanzyl claimed he had an alternative solution that allowed the caching but I have not seen that in over a year. I am inclined to agree with removing this hack given the side-effects

[GitHub] maven issue #110: plexus

Github user stephenc commented on the issue: https://github.com/apache/maven/pull/110 s/Not/Bot/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] maven issue #110: plexus

Github user stephenc commented on the issue: https://github.com/apache/maven/pull/110 Not trying to hack by the look of it. I'd heard of these --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] maven-surefire pull request #144: Resource leaks.

Github user stephenc commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/144#discussion_r103110391 --- Diff: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/ConsoleOutputFileReporter.java --- @@ -69,8 +69,8 @@ public

[GitHub] maven issue #104: [MNG-5961] Fix the SLF4J logger factory implementation use...

Github user stephenc commented on the issue: https://github.com/apache/maven/pull/104 > we don't have a CI validation here Yep waiting to get SCM API 2.0.x back into the uc and then pester infra to upgrade --- If your project is set up for it, you can reply to this em

[GitHub] maven-wagon issue #32: [WAGON-485] ScpWagon file size Integer to Long

Github user stephenc commented on the issue: https://github.com/apache/maven-wagon/pull/32 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] maven pull request: [MNG-5840] Parent version is a range hack

Github user stephenc commented on the pull request: https://github.com/apache/maven/pull/60#issuecomment-124128970 After no comments against merging this and with @ifedorenko saying go for it I decided to merge... if people object they can revert it out. I am not in love

[GitHub] maven pull request: [MNG-5840] Parent version is a range hack

Github user stephenc commented on the pull request: https://github.com/apache/maven/pull/60#issuecomment-123696060 @ifedorenko I've simplified this per your comments... still feel that adding the dependency on maven-artifact is not the correct thing... but it is a semi-reasonable fix

[GitHub] maven pull request: [MNG-5840] Parent version is a range hack

GitHub user stephenc opened a pull request: https://github.com/apache/maven/pull/60 [MNG-5840] Parent version is a range hack - I don't like this, but it does let all the integration tests pass: ``` Running org.apache.maven.it.MavenITmng2199ParentVersionRangeTest