[GitHub] maven-surefire issue #146: SUREFIRE-1330: Fix module name in surefire-provid...

2017-06-06 Thread britter
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/146 Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] maven-surefire issue #146: SUREFIRE-1330: Fix module name in surefire-provid...

2017-06-05 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/146 @britter @mgreau Done. https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=70c8843e935882b0a78916894cb9f042964f2717 --- If your project is set up for it, you

[GitHub] maven-surefire issue #146: SUREFIRE-1330: Fix module name in surefire-provid...

2017-06-05 Thread britter
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/146 @Tibor17 I'm currently working on a `JUnitPlattformProviderInfo`. I have some issues with the ITs, which I will bring up on the ML. In the mean time, I need you to merge this PR. The

[GitHub] maven-surefire issue #146: SUREFIRE-1330: Fix module name in surefire-provid...

2017-06-04 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/146 @mgreau @britter Hey guys, let's utilize your power and complete `AbstractSurefireMojo` with `ProviderInfo`, some tests are still in progress. Meanwhile Apache Maven will

[GitHub] maven-surefire issue #146: SUREFIRE-1330: Fix module name in surefire-provid...

2017-06-04 Thread britter
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/146 @Tibor17 the provider is already part of the 3.0-rc1 branch. Please see #142. This just fixes an incorrect module name. > It's not legal to introduce incomplete feature.

[GitHub] maven-surefire issue #146: SUREFIRE-1330: Fix module name in surefire-provid...

2017-04-11 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/146 Not on the same version. It's not legal to introduce incomplete feature. The acceptable way would be to introduce junit5 in 3.0-alpha-1. --- If your project is set up for it, you can reply

[GitHub] maven-surefire issue #146: SUREFIRE-1330: Fix module name in surefire-provid...

2017-04-11 Thread mgreau
Github user mgreau commented on the issue: https://github.com/apache/maven-surefire/pull/146 Hi, Ok, thanks for the information. This PR just fixes an oversight when #142 was merged on the 3.0-rc1 branch, nothing more. > Then we will integrate support for Jigsaw Java

[GitHub] maven-surefire issue #146: SUREFIRE-1330: Fix module name in surefire-provid...

2017-04-11 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/146 @mgreau The time has not yet come for 3.0 and junit5. We are in progress. Both branches are not mergable. I should cherry pick changes and fix a failing IT in 3.0-rc1. First of all