Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/168
@eolivelli
Thx for contributing. Close this PR. It was pushed to master.
---
-
To unsubscribe, e-mail:
Github user eolivelli commented on the issue:
https://github.com/apache/maven-surefire/pull/168
@Tibor17 Ihave squashed the commits and reworded the commit msg.
---
-
To unsubscribe, e-mail:
Github user eolivelli commented on the issue:
https://github.com/apache/maven-surefire/pull/168
Ok, will do this afternoon. Thanks
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/168
The comment `[SUREFIRE-1424] javax.transaction.TransactionManager not
visible with Java9` should be in commit.
---
-
To
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/168
If you could squash these two commits in one, it would be great.
---
-
To unsubscribe, e-mail:
Github user eolivelli commented on the issue:
https://github.com/apache/maven-surefire/pull/168
@Tibor17 please check it out
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands,
Github user eolivelli commented on the issue:
https://github.com/apache/maven-surefire/pull/168
Oh, got it, I have to run "mvn site" on the root of the project not only on
maven-surefire-plugin
---
-
To
Github user eolivelli commented on the issue:
https://github.com/apache/maven-surefire/pull/168
@Tibor17 I am trying to update the site, how can I rebuild the site locally
?
I am trying with "mvn site" but it fails
---
Github user eolivelli commented on the issue:
https://github.com/apache/maven-surefire/pull/168
@Tibor17 ok I will do this change. Will send tomorrow.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/168
@eolivelli
We need to add a new chapter on the top in
https://github.com/apache/maven-surefire/blob/master/maven-surefire-plugin/src/site/markdown/java9.md
and add the following API.
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/168
@eolivelli
I will have a look. I was busy last week.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
Github user eolivelli commented on the issue:
https://github.com/apache/maven-surefire/pull/168
@Tibor17 I have rewritten the patch and address your comment of not
altering the docs.
Tell me the next step in your vision, I will be happy to move forward and
finish this important
Github user eolivelli commented on the issue:
https://github.com/apache/maven-surefire/pull/168
Ok will do asap
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail:
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/168
@eolivelli
I have finished my changes in master. Can you continue?
---
-
To unsubscribe, e-mail:
Github user eolivelli commented on the issue:
https://github.com/apache/maven-surefire/pull/168
No problem, the change was minimal, I will start from scratch
---
-
To unsubscribe, e-mail:
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/168
It was done. But I don't think you can easily rebase it since some classes
were deleted or methods moved.
---
-
To
Github user eolivelli commented on the issue:
https://github.com/apache/maven-surefire/pull/168
Sure, I will rebase once you merged your big changes
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For
17 matches
Mail list logo
