also your view as a first-time plugin contributor!
>>
>> -Ursprüngliche Nachricht-
>> Von: Sandra Parsick [mailto:spars...@web.de]
>> Gesendet: Dienstag, 22. Dezember 2020 14:34
>> An: dev@maven.apache.org
>> Betreff: [Idea] Coding Guidelines for Maven Contribution N
> I am aware of editor-config, but it has one huge problem: you cannot refer to
> a centralized file.
> This means that IF we would use them, we need to keep them in sync for all
> ~100 repositories, which is a big no for me.
I understand your rejection. I solved this problem in one of my
On Sun, Dec 27, 2020 at 10:24 AM Benjamin Marwell wrote:
>
> Hi Sandra,
> hi everyone,
>
> here’s another subtopic:
>
> I recently added a comment like this: // [issue-##]: Do call method x
> because of side effect x
> But I got a review "the comment is redundant because of the git log".
> Is
Hi Sandra,
hi everyone,
here’s another subtopic:
I recently added a comment like this: // [issue-##]: Do call method x
because of side effect x
But I got a review "the comment is redundant because of the git log".
Is there a policy on where and how to put comments in the code?
Reference:
AFAIK the eclipse one is not outdated.
I suggest to update these.
I am aware of editor-config, but it has one huge problem: you cannot refer to a
centralized file.
This means that IF we would use them, we need to keep them in sync for all ~100
repositories, which is a big no for me.
Updating
> those are outdated – not everything you need is included, at least for
> IntelliJ.
> YMMV when using those.
If those are already outdated and those need an update, maybe it is a
good point to introduce editorconfig [1]. The advantage of editorconfig
is that you have one config file for "all"
ick [mailto:spars...@web.de]
> Gesendet: Dienstag, 22. Dezember 2020 14:34
> An: dev@maven.apache.org
> Betreff: [Idea] Coding Guidelines for Maven Contribution Newbies
>
> Hello dev-list,
>
> some weeks ago, I have started creating some Pull Requests for the Maven
> JLin
Hi Anders,
those are outdated – not everything you need is included, at least for
IntelliJ.
YMMV when using those.
There is a lot which could be done.
E.g. updating those files, some general code guidelines (like: do not use
guard statements, rather use an else), etc., when (not) to use
. Dezember 2020 14:34
An: dev@maven.apache.org
Betreff: [Idea] Coding Guidelines for Maven Contribution Newbies
Hello dev-list,
some weeks ago, I have started creating some Pull Requests for the Maven JLink
Plugin [1]. There were many hints about coding rules or decision which version
/ libs etc
There are settings files here:
http://maven.apache.org/developers/conventions/code.html
/Anders
On Tue, Dec 22, 2020 at 2:47 PM Gary Gregory wrote:
> It would be great if one could download Eclipse or Idea settings files, or
> better yet, include them in each repo.
>
> Gary
>
> On Tue, Dec 22,
It would be great if one could download Eclipse or Idea settings files, or
better yet, include them in each repo.
Gary
On Tue, Dec 22, 2020, 08:34 Sandra Parsick wrote:
> Hello dev-list,
>
> some weeks ago, I have started creating some Pull Requests for the Maven
> JLink Plugin [1]. There were
Hello dev-list,
some weeks ago, I have started creating some Pull Requests for the Maven
JLink Plugin [1]. There were many hints about coding rules or decision
which version / libs etc should be used and more. So I need some
iterations till a trivial (IMHO) PR was accepted or in one case to find
12 matches
Mail list logo
