Re: [Maven-Shade-plugin] Support for Multi Release Jars (JEP-238): Feedback needed

2023-11-12 Thread Romain Manni-Bucau
Le dim. 12 nov. 2023 à 10:44, Niels Basjes a écrit : > Hi, > > > Looking quickly the drop of the conditional read of the manifest seems > the > > issue for tests. > > Yes it was. Must have been late when I wrote that ... > I have fixed this silly error of mine and now it all works. > > > In

Re: [Maven-Shade-plugin] Support for Multi Release Jars (JEP-238): Feedback needed

2023-11-12 Thread Niels Basjes
Hi, > Looking quickly the drop of the conditional read of the manifest seems the > issue for tests. Yes it was. Must have been late when I wrote that ... I have fixed this silly error of mine and now it all works. > In terms of impl my 2cts would be that we shouldnt have had jdependency in >

Re: [Maven-Shade-plugin] Support for Multi Release Jars (JEP-238): Feedback needed

2023-11-11 Thread Romain Manni-Bucau
Hi Niels, Looking quickly the drop of the conditional read of the manifest seems the issue for tests. In terms of impl my 2cts would be that we shouldnt have had jdependency in this plugin IMHO so better to stay off it (in particular cause there it is really not needed, probably saner to read

[Maven-Shade-plugin] Support for Multi Release Jars (JEP-238): Feedback needed

2023-11-11 Thread Niels Basjes
Hi, I've been working on trying to make the shade plugin support jars that are Multi Release Jars (JEP-238) https://issues.apache.org/jira/browse/MSHADE-406 A Multi Release Jar simply means you can have a single class in a single jar with multiple implementations (and thus multiple class files in