Re: [CANCELLED] [VOTE] Release Apache Maven 3.5.1

It's a pity these two didn't make it in: https://issues.apache.org/jira/browse/MNG-6261 https://issues.apache.org/jira/browse/MNG-6262 These are true showstoppers for Windows users (like us). Dawid On Tue, Oct 17, 2017 at 8:15 PM, Stephen Connolly wrote: >

[CANCELLED] [VOTE] Release Apache Maven 3.5.1

This vote, despite being successful, is being cancelled. As release manager for this vote I have made the decision is that releasing with the two issues: MNG-6275 MNG-6209 Would present an unnecessary risk to users. We're going to revert those to allow for less risky fixes to be developed.

Re: [VOTE] Release Apache Maven 3.5.1

Hi, On 12/10/17 08:21, Stephen Connolly wrote: Ok as release manager I am cancelling this vote. I’ll see about spinning 3.5.2 could we make such thing a little bit more obvious like prefixing the subject with "[CANCELED]..." so it becomes more clear that the VOTE has been canceled...it's

Re: [VOTE] Release Apache Maven 3.5.1

Ok as release manager I am cancelling this vote. I’ll see about spinning 3.5.2 On Thu 12 Oct 2017 at 02:51, Hervé BOUTEMY wrote: > Le mercredi 11 octobre 2017, 23:47:54 CEST Robert Scholte a écrit : > > I think the conclusion is: 3.5.1 is not correct > > > > it should

Re: [VOTE] Release Apache Maven 3.5.1

Le mercredi 11 octobre 2017, 23:47:54 CEST Robert Scholte a écrit : > I think the conclusion is: 3.5.1 is not correct > > it should either be: > 3.5.2 without the 2 classloader related issues. ideally with an option to activate the classloader changes (for people knowing what they are doing or

Re: [VOTE] Release Apache Maven 3.5.1

I think the conclusion is: 3.5.1 is not correct it should either be: 3.5.2 without the 2 classloader related issues. or 3.6.0 including the classloader related issues, but probably improved with a system property to switch back to the 3.5.0-behavior. We also need to improve ITs and

Re: [VOTE] Release Apache Maven 3.5.1

I’d really like if somebody could draft the release notes for the two different classloader changes. It will make it easier to decide whether to roll with this or bump minor with (if I recall correctly) the corresponding drop of Java 7 per our policy on JVMs with minor version bump On Wed 11 Oct

Re: [VOTE] Release Apache Maven 3.5.1

+1 eventually adding a flag or system property to activate the new behaviour this remembers me of the idea regarding flags to support new beta features Regards, Hervé Le mercredi 11 octobre 2017, 08:13:13 CEST Anders Hammar a écrit : > I'm feeling stronger and stronger about not having this

Re: [VOTE] Release Apache Maven 3.5.1

I'm feeling stronger and stronger about not having this change in a bugfix release. Why not go for v3.6.0 if we decide that the class loading change is the way to go? And keep bugfix releases for just bugfixes. /Anders On Wed, Oct 11, 2017 at 3:43 AM, Hervé BOUTEMY wrote:

Re: [VOTE] Release Apache Maven 3.5.1

perhaps we should create a Wiki page for java.lang.ClassNotFoundException and list the plugins with known issues and minimum fixed version to be added in https://cwiki.apache.org/confluence/display/MAVEN/Errors+and+Solutions Regards, Hervé Le mercredi 11 octobre 2017, 02:52:53 CEST Hervé

Re: [VOTE] Release Apache Maven 3.5.1

IIUC, it's MDEPLOY-221 about net.flexmojos.oss:flexmojos-maven-plugin https://issues.apache.org/jira/browse/MDEPLOY-221 Regards, Hervé Le mardi 10 octobre 2017, 20:48:13 CEST Robert Scholte a écrit : > FYI, MDEPLOY-121 mentions another plugin being hit by the classloader > changes. > > Robert

Re: [VOTE] Release Apache Maven 3.5.1

FYI, MDEPLOY-121 mentions another plugin being hit by the classloader changes. Robert On Tue, 03 Oct 2017 20:22:18 +0200, Arnaud Héritier wrote: Thanks Stephen On Tue, Oct 3, 2017 at 8:18 PM, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: I am hoping

Re: [VOTE] Release Apache Maven 3.5.1

Thanks Stephen On Tue, Oct 3, 2017 at 8:18 PM, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > I am hoping I can find some time to do a final round of experiments and > then close the vote with success and publish. > > > On Tue 3 Oct 2017 at 11:13, Arnaud Héritier

Re: [VOTE] Release Apache Maven 3.5.1

I am hoping I can find some time to do a final round of experiments and then close the vote with success and publish. On Tue 3 Oct 2017 at 11:13, Arnaud Héritier wrote: > @Stephen What should we do now ? > > > On Tue, Sep 19, 2017 at 3:14 AM, Olivier Lamy

Re: [VOTE] Release Apache Maven 3.5.1

@Stephen What should we do now ? On Tue, Sep 19, 2017 at 3:14 AM, Olivier Lamy wrote: > Hi > Sorry a bit out of time ATM for testing this. > Well I trust Arnaud testing that especially if this improve the performance > of this very great/awesome/users oriented plugin :P > >

Re: Understanding MNG-6209 (was: [VOTE] Release Apache Maven 3.5.1)

See inline On Sun, Sep 24, 2017, at 03:37 PM, Stephen Connolly wrote: > Right now I have a successful vote to release 3.5.1 > [snip] > Now I see 6209 changing the classloader for plugins that are also build > extensions... the question here is two fold: > > 1. Is the new behaviour *correct*

Re: Understanding MNG-6209 (was: [VOTE] Release Apache Maven 3.5.1)

Right now I have a successful vote to release 3.5.1 I also have two issues changing classloader behaviours in ways that may surprise people. I am not against releasing what we have as a bug fix release - if these are actual bugs. I am not against fixing inconsistencies with the site

Re: Understanding MNG-6209 (was: [VOTE] Release Apache Maven 3.5.1)

Lets decide the agenda first, then who you need to attend (assuming you are driving this discussion/decision), then pick the time that works. >From my side, I still don't understand the problems we are trying to solve. If this is the lacking documentation and general "uncomfort" to mess with

Re: Understanding MNG-6209 (was: [VOTE] Release Apache Maven 3.5.1)

To add to the topic I think that if we fix/change the class loading, we shouldn't do that in a bug fix release. I'd rather see a 3.6.0 with it thought through, fixed and documented (could be in ITs). The arguing being that a bug fix release shouldn't cause new issues in plugins etc. /Anders On

Re: Understanding MNG-6209 (was: [VOTE] Release Apache Maven 3.5.1)

I wonder should we do a hangout to decide what you do? What times on Monday work best? I can maybe do 8:30-9:30pm Irish time https://www.timeanddate.com/worldclock/meetingdetails.html?year=2017=9=25=19=30=0=78=37=179 But we’d need to decide who we need and an actual agenda. If Monday is too

Re: Understanding MNG-6209 (was: [VOTE] Release Apache Maven 3.5.1)

See my answers/comments inline On Sun, Sep 24, 2017, at 12:07 PM, Stephen Connolly wrote: > https://maven.apache.org/guides/mini/guide-maven-classloading.html says: > > > When a build plugin is executed, the thread's context classloader is set > to the plugin classloader. > > So we'll need to

Re: Understanding MNG-6209 (was: [VOTE] Release Apache Maven 3.5.1)

On Sun, 24 Sep 2017 19:36:15 +0200, Stephen Connolly wrote: On Sun 24 Sep 2017 at 17:44, Robert Scholte wrote: Are these questions we can/should answer within a couple of days? I'm not aware of somebody hitting the regression as

Re: Understanding MNG-6209 (was: [VOTE] Release Apache Maven 3.5.1)

On Sun 24 Sep 2017 at 17:44, Robert Scholte wrote: > Are these questions we can/should answer within a couple of days? > I'm not aware of somebody hitting the regression as caused by MNG-5742 > other than Igor. > However, we've seen a couple of changed behavior clearly

Re: Understanding MNG-6209 (was: [VOTE] Release Apache Maven 3.5.1)

Are these questions we can/should answer within a couple of days? I'm not aware of somebody hitting the regression as caused by MNG-5742 other than Igor. However, we've seen a couple of changed behavior clearly caused by MNG-6209 (not answering if this intended or not) We could also make

Re: Understanding MNG-6209 (was: [VOTE] Release Apache Maven 3.5.1)

https://maven.apache.org/guides/mini/guide-maven-classloading.html says: > When a build plugin is executed, the thread's context classloader is set to the plugin classloader. So we'll need to fix something somewhere...

Re: Understanding MNG-6209 (was: [VOTE] Release Apache Maven 3.5.1)

Real-world scm or wagon won't trigger maven2-compat code path [1]. To avoid that obscure code path we can either make the test more elaborate (i.e. add dependencies to extjar1/extjar2) or we can use extensions . Either way I don't think we should spend time on the code path unlikely to be used in

Re: Understanding MNG-6209 (was: [VOTE] Release Apache Maven 3.5.1)

Just to be clear, while I agree the documentation is lacking, neither special-casing "simple" nor META-INF/maven/extension.xml is new behaviour in 3.5.1, both existed since 3.0 alphas iirc. Also, Hervé did add some extension.xml documentation couple of years ago.

Re: Understanding MNG-6209 (was: [VOTE] Release Apache Maven 3.5.1)

On Wed, 20 Sep 2017 09:12:47 +0200, Stephen Connolly wrote: On Wed 20 Sep 2017 at 01:29, Igor Fedorenko wrote: In that case, can I suggest couple of changes to the test project * I thinks it makes more sense to configure extjar1 and

Re: Understanding MNG-6209 (was: [VOTE] Release Apache Maven 3.5.1)

On Wed 20 Sep 2017 at 01:29, Igor Fedorenko wrote: > In that case, can I suggest couple of changes to the test project > > * I thinks it makes more sense to configure extjar1 and extjar2 as > extensions elements in probleN pom.xml files. First, there is > no meaningful

Re: Understanding MNG-6209 (was: [VOTE] Release Apache Maven 3.5.1)

In that case, can I suggest couple of changes to the test project * I thinks it makes more sense to configure extjar1 and extjar2 as extensions elements in probleN pom.xml files. First, there is no meaningful order between and elements. More importantly, though, simple are treated in special

Re: Understanding MNG-6209 (was: [VOTE] Release Apache Maven 3.5.1)

Yes, the expectations are key. Depending on what they are we may either drop 3.5.1 or go ahead as it depends on whether this is more correct than 3.5.0 or swapping one fix for a bug On Tue 19 Sep 2017 at 21:39, Igor Fedorenko wrote: > Just to confirm I understand what we

Re: Understanding MNG-6209 (was: [VOTE] Release Apache Maven 3.5.1)

Just to confirm I understand what we are trying to establish here. We want to decide the expected/desired component injection behaviour and classpath visibility in the absence of package and artifact export configuration (i.e. META-INF/maven/extension.xml file). Did I get this right? -- Regards,

Re: Understanding MNG-6209 (was: [VOTE] Release Apache Maven 3.5.1)

Let's do it like this: https://cwiki.apache.org/confluence/download/attachments/2329841/classrealms.pdf?api=v2 Robert On Tue, 19 Sep 2017 21:08:39 +0200, Stephen Connolly wrote: I think you will need a link to the PDF as attachments are stripped from the

Re: Understanding MNG-6209 (was: [VOTE] Release Apache Maven 3.5.1)

I think you will need a link to the PDF as attachments are stripped from the ML On Tue 19 Sep 2017 at 19:57, Robert Scholte wrote: > Attached a single page overview. > > Per block you'll see in the upper left corner the executed plugin > The left column contains the

Re: Understanding MNG-6209 (was: [VOTE] Release Apache Maven 3.5.1)

Attached a single page overview. Per block you'll see in the upper left corner the executed plugin The left column contains the extensions and plugin in orderas specified in the pom.xml In every classloadercolumn you'll see numbers which represent the order. I hope I didn't make any

Re: Understanding MNG-6209 (was: [VOTE] Release Apache Maven 3.5.1)

TL;DR your test project exposed two existing bugs, one change in behaviour and one quirk I can't explain * Build `` are loaded by two classloaders, which is a bug in DefaultProjectBuildingHelper#createProjectRealm and explains why you see extjar1/extjar2 in the output * ClassRealm does not allow

Re: [VOTE] Release Apache Maven 3.5.1

Hi Sorry a bit out of time ATM for testing this. Well I trust Arnaud testing that especially if this improve the performance of this very great/awesome/users oriented plugin :P On 13 September 2017 at 22:19, Arnaud Héritier wrote: > Damned, can't we be anonymous on Github

Re: Understanding MNG-6209 (was: [VOTE] Release Apache Maven 3.5.1)

Oh if only... there is some subtleties going on here. Classes are managed by the "plexus" / "classworlds" stuff, so you cannot override core classes etc. The problem is what extensions are visible and from which classloader On 18 September 2017 at 08:42, Charles Honton wrote:

Re: Understanding MNG-6209 (was: [VOTE] Release Apache Maven 3.5.1)

From a security perspective, I would expect that core classes can not be overridden by extensions or plugins. Likewise, extension classes can not be overridden by plugins. Given the use case of defaulting resources, I would expect that the plugin resources are first, followed by plugin

Re: Understanding MNG-6209 (was: [VOTE] Release Apache Maven 3.5.1)

Hmmm, so I did some experiments: If you want to ride along, the experiments are at: https://github.com/stephenc/mng-6209 So basically I have a plugin that does three different tests: getLog().info("Injected by @Component:"); for (Lifecycle l : lifecycles) { if

Re: [VOTE] Release Apache Maven 3.5.1

On Sat 16 Sep 2017 at 10:51, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > On Sat 16 Sep 2017 at 04:07, Igor Fedorenko wrote: > >> I don't really have much to add, but let me answer anyways :-) >> >> 1) I am reasonably confident we can compensate for the new

Re: [VOTE] Release Apache Maven 3.5.1

On Sat 16 Sep 2017 at 04:07, Igor Fedorenko wrote: > I don't really have much to add, but let me answer anyways :-) > > 1) I am reasonably confident we can compensate for the new classloader > arrangement in m2e without much problems. The new setup does make plugin > runtime

Re: [VOTE] Release Apache Maven 3.5.1

I don't really have much to add, but let me answer anyways :-) 1) I am reasonably confident we can compensate for the new classloader arrangement in m2e without much problems. The new setup does make plugin runtime classpath less stable, so there are likely other scenarios where plugins will

Re: [VOTE] Release Apache Maven 3.5.1

I'm going to hold off closing the vote over the weekend to give Igor a chance to: 1. comment on whether we need an alternative fix for MNG-6275 (and indeed ideally provide one ;- ); 2. comment on whether the fix for MNG-6209 is exposing bugs in plugins that made incorrect assumptions about TCCL,

Re: [VOTE] Release Apache Maven 3.5.1

Has anyone tried wiring jvm extensions ClassLoader as foreign import to plugin/extensions realms? Jvm extensions classloader is little tricky to get to (see how this is done in java.util.ServiceLoader.loadInstalled), but I think this will solve ServiceLoader/MNG-6275 without polluting plugin

Re: [VOTE] Release Apache Maven 3.5.1

Would it be possible to handle this in a somewhat similar way to threadSafe mojos - some form of plugin flag that says "extensionSafe" [1], that if the plugin has true declared and doesn't declare itself as being extensionSafe/extensionAware then we log a build warning - it wouldn't solve

Re: [VOTE] Release Apache Maven 3.5.1

Based on Igor's feedback I'm changing my vote to +1. Having this class loader change in a bug fix release is probably not (semver) ideal though. /Anders On Fri, Sep 15, 2017 at 2:12 PM, Igor Fedorenko wrote: > I answered in more details on m2e-dev, but I believe we can

Re: [VOTE] Release Apache Maven 3.5.1

I answered in more details on m2e-dev, but I believe we can compensate for the change from m2e end. In the worst case we'll bundle hacked version of DefaultClassRealmManager with m2e, not ideal, but not the end of the world either. -- Regards, Igor On Fri, Sep 15, 2017, at 07:21 AM, Anders

Re: [VOTE] Release Apache Maven 3.5.1

On Fri, Sep 15, 2017 at 8:29 AM, Anders Hammar wrote: > Reporting back from tests of m2e with embedded Maven 3.5.1, we see problem > with the jaxws-maven-plugin mojo. We're two people seeing the issue > independently, but unfortunately Fred Bricon hasn't been able to

Re: [VOTE] Release Apache Maven 3.5.1

Just to reply to my self and to add +1 (non-binding). My two cents on regression (https://issues.apache.org/jira/browse/MNG-6282): ticket is still open and we (that is: Hervé Boutemy and me) are narrowing the gap (no ETA at the moment). IMHO this issue is not a show-stopper; I volunteer to

Re: [VOTE] Release Apache Maven 3.5.1

On 14 September 2017 at 23:55, Michael Osipov wrote: > Am 2017-09-15 um 00:50 schrieb Petr Široký: > >> I was able to easily fix our plugin by e.g. replacing >> "Thread.currentThread().getContextClassLoader()" with >> "this.getClass().getClassLoader()" (in the Mojo class) to

Re: [VOTE] Release Apache Maven 3.5.1

Am 2017-09-15 um 00:50 schrieb Petr Široký: I was able to easily fix our plugin by e.g. replacing "Thread.currentThread().getContextClassLoader()" with "this.getClass().getClassLoader()" (in the Mojo class) to get the plugin classloader. I don't know though if the

Re: [VOTE] Release Apache Maven 3.5.1

Reporting back from tests of m2e with embedded Maven 3.5.1, we see problem with the jaxws-maven-plugin mojo. We're two people seeing the issue independently, but unfortunately Fred Bricon hasn't been able to reproduce. So currently I'm 0 on the voting but I'll investigate some more. /Anders On

Re: [VOTE] Release Apache Maven 3.5.1

I was able to easily fix our plugin by e.g. replacing "Thread.currentThread().getContextClassLoader()" with "this.getClass().getClassLoader()" (in the Mojo class) to get the plugin classloader. I don't know though if the "Thread.currentThread().getContextClassLoader()" is just misuse on our side

Re: [VOTE] Release Apache Maven 3.5.1

Argh, I forgot to link the plugin source: https://github.com/kiegroup/droolsjbpm-integration/tree/7.3.0.Final/kie-maven-plugin On Thu, Sep 14, 2017 at 2:41 PM Petr Široký wrote: > Hello, > > I am seeing a (probably) similar issue with our custom plugin. > > See the

Re: [VOTE] Release Apache Maven 3.5.1

Hello, I am seeing a (probably) similar issue with our custom plugin. See the reproducer: https://github.com/psiroky/reproducers/tree/mvn351-kie-maven-plugin (works fine with maven 3.5.0, but fails with NPE with the RC of maven 3.5.1). I am not yet sure if the plugin is just doing something

Re: [VOTE] Release Apache Maven 3.5.1

On 14 September 2017 at 04:43, Mark Derricutt wrote: > > +2 non-binding from Mark! > > I was discussing this with a coworker and he made the comment that if this > change could break Mojos, maybe it shouldn't be in a point release - whats > the policy on changes that may

Re: [VOTE] Release Apache Maven 3.5.1

> +2 non-binding from Mark! I was discussing this with a coworker and he made the comment that if this change could break Mojos, maybe it shouldn't be in a point release - whats the policy on changes that may potentially break existing plugins? -- "Great artists are extremely selfish and

Re: [VOTE] Release Apache Maven 3.5.1

+1 works well in everything I tested, colour on Windows with GitBash or Cygwin or any other Unix layer taken apart (in fact anything on WIndows that provides "TERM=xterm") workaround for those Windows users: add -Djansi.force=true to MAVEN_OPTS the only drawback will only be if you redirect

Re: [VOTE] Release Apache Maven 3.5.1

On Wed 13 Sep 2017 at 23:30, Mark Derricutt wrote: > On 14 Sep 2017, at 10:26, Mark Derricutt wrote: > > Calling -2 for vote if not too late. > > Actually - looking at the commit diff, I see in our code we did have > true for the jasmine-maven-plugin which we don't > actually

Re: [VOTE] Release Apache Maven 3.5.1

On 14 Sep 2017, at 10:26, Mark Derricutt wrote: > Calling -2 for vote if not too late. Actually - looking at the commit diff, I see in our code we did have `true` for the `jasmine-maven-plugin` which we don't actually need. Removing that from the mojo definition and running my build with the

Re: [VOTE] Release Apache Maven 3.5.1

Calling -2 for vote if not too late. Have git bisected from 3.5.0 to HEAD and found the commit that introduced the behaviour: ec629f7d511eb910b4e80112a9fbe85ed8786f10 is the first bad commit commit ec629f7d511eb910b4e80112a9fbe85ed8786f10 Author: Igor Fedorenko Date:

Re: [VOTE] Release Apache Maven 3.5.1

17 10:05 (GMT+01:00) Aan: > Maven Developers List <dev@maven.apache.org> Onderwerp: Re: [VOTE] Release > Apache Maven 3.5.1 > On 13 September 2017 at 00:26, Anders Hammar <and...@hammar.net> wrote: > >> On Tue, Sep 12, 2017 at 8:54 PM, Stephen Connolly < >> st

Re: [VOTE] Release Apache Maven 3.5.1

Maven Developers List <dev@maven.apache.org> Onderwerp: Re: [VOTE] Release Apache Maven 3.5.1 On 13 September 2017 at 00:26, Anders Hammar <and...@hammar.net> wrote: > On Tue, Sep 12, 2017 at 8:54 PM, Stephen Connolly < > stephen.alan.conno...@gmail.com> wrote: >

Re: [VOTE] Release Apache Maven 3.5.1

Maven Developers List <dev@maven.apache.org> Onderwerp: Re: [VOTE] Release Apache Maven 3.5.1 On 13 September 2017 at 00:26, Anders Hammar <and...@hammar.net> wrote: > On Tue, Sep 12, 2017 at 8:54 PM, Stephen Connolly < > stephen.alan.conno...@gmail.com> wrote: >

Re: [VOTE] Release Apache Maven 3.5.1

Damned, can't we be anonymous on Github ? I maintain it is a big word, I'm trying to fix more bugs than I add new ones I added Oleg in the loop as he contributed a lot on it too I did a quick test to build on Jenkins 2.60.3 our maven core with the Evil Maven plugin 2.17 on a local SSH agent and it

Re: [VOTE] Release Apache Maven 3.5.1

On 13 September 2017 at 01:05, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > On 13 September 2017 at 00:26, Anders Hammar wrote: > >> On Tue, Sep 12, 2017 at 8:54 PM, Stephen Connolly < >> stephen.alan.conno...@gmail.com> wrote: >> >> > Have we got any feedback

Re: [VOTE] Release Apache Maven 3.5.1

On 13 September 2017 at 00:26, Anders Hammar wrote: > On Tue, Sep 12, 2017 at 8:54 PM, Stephen Connolly < > stephen.alan.conno...@gmail.com> wrote: > > > Have we got any feedback from the embedder integrations yet? > > > > I haven't heard anything from the m2e people. Maybe we

Re: [VOTE] Release Apache Maven 3.5.1

On Tue, Sep 12, 2017 at 8:54 PM, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > Have we got any feedback from the embedder integrations yet? > I haven't heard anything from the m2e people. Maybe we need to ping them directly. I can contact Fred Bricon. /Anders > > On Mon 11 Sep

Re: [VOTE] Release Apache Maven 3.5.1

+1 - go for it. 2017-09-13 9:04 GMT+03:00 Grzegorz Grzybek : > Hello > > +1 (non-binding) - tested Fuse/Karaf/OSGi projects > > regards > Grzegorz Grzybek > > 2017-09-13 8:00 GMT+02:00 Thomas Collignon : > > > Hello > > > > +1 for me > > > >

Re: [VOTE] Release Apache Maven 3.5.1

Hello +1 (non-binding) - tested Fuse/Karaf/OSGi projects regards Grzegorz Grzybek 2017-09-13 8:00 GMT+02:00 Thomas Collignon : > Hello > > +1 for me > > 2017-09-12 20:54 GMT+02:00 Stephen Connolly com > >: > > > Have we got any feedback

Re: [VOTE] Release Apache Maven 3.5.1

Hello +1 for me 2017-09-12 20:54 GMT+02:00 Stephen Connolly : > Have we got any feedback from the embedder integrations yet? > > On Mon 11 Sep 2017 at 22:57, Hervé BOUTEMY wrote: > > > just for the records: it is Windows + Git Bash

Re: [VOTE] Release Apache Maven 3.5.1

Have we got any feedback from the embedder integrations yet? On Mon 11 Sep 2017 at 22:57, Hervé BOUTEMY wrote: > just for the records: it is Windows + Git Bash (MINGW64) only > > and there is a chance that adding -Djansi.force=true can force JAnsi > activation (even if

Re: [VOTE] Release Apache Maven 3.5.1

just for the records: it is Windows + Git Bash (MINGW64) only and there is a chance that adding -Djansi.force=true can force JAnsi activation (even if JAnsi fails to detect that it should auto-activate) details on issue in https://issues.apache.org/jira/browse/MNG-6282 , and a future JAnsi

Re: [VOTE] Release Apache Maven 3.5.1

+1 On Sun, 10 Sep 2017 17:39:12 +0200, Stephen Connolly wrote: Hi, We solved 25 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12338964=Text=12316922 There are 350 issues left in JIRA for Maven core:

Re: [VOTE] Release Apache Maven 3.5.1

Nice fix On Mon, 11 Sep 2017 11:31:34 +0200, Stephen Connolly wrote: http://git-wip-us.apache.org/repos/asf/maven/diff/542a7a89 to defang the test going forward, with that change on Azul's Zulu JDK 7 I get: Linux ddf0318b698b 4.9.46-moby #1 SMP Thu Sep 7

Re: [VOTE] Release Apache Maven 3.5.1

+1 S. On Sun, Sep 10, 2017 at 5:39 PM, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > Hi, > > We solved 25 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > version=12338964=Text=12316922 > > There are 350 issues left in JIRA for Maven core: >

Re: [VOTE] Release Apache Maven 3.5.1

So that is windows only, or were they lost on other OSes for you. I have colours on linux (via docker) and os-x On 11 September 2017 at 12:35, dejan2...@gmail.com wrote: > +1 (conditionally). > > Tested via project that includes dozen of plugins: 1st tier, MojoHaus and >

Re: [VOTE] Release Apache Maven 3.5.1

+1 (conditionally). Tested via project that includes dozen of plugins: 1st tier, MojoHaus and few 3rd party plugins (so to say). Everything looks good with one notable regression: https://issues.apache.org/jira/browse/MNG-6282 Console output has no colors (regression in Maven 3.5.1) Regards,

Re: [VOTE] Release Apache Maven 3.5.1

On 11 Sep 2017, at 18:10, Stephen Connolly wrote: > I wonder if mng-6275 is affecting that plugin Didn't manage to get a chance to look into this tonight :( Tho that ticket mentions nashorn, phantonjs is a C/native headless browser library, so it doesn't feel like it could be related. If

Re: [VOTE] Release Apache Maven 3.5.1

http://git-wip-us.apache.org/repos/asf/maven/diff/542a7a89 to defang the test going forward, with that change on Azul's Zulu JDK 7 I get: Linux ddf0318b698b 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3;

Re: [VOTE] Release Apache Maven 3.5.1

So Azul's Zulu 7 does not have com.sun.script.javascript.RhinoScriptEngineFactory or any ScriptEngineFactory in the base classloader... Zulu 8 has jdk.nashorn.api.scripting.NashornScriptEngineFactory So at this point in time, my analysis is that the DefaultClassRealmManagerTest is not a valid

Re: [VOTE] Release Apache Maven 3.5.1

With https://github.com/apache/maven-integration-testing/commit/a08d65bfb5fedec9f684c13bf5a0dccb96f5cc56 I was able to get Michael's test failures: Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3; 2017-09-10T12:42:54Z) Maven home: /work/bin Java version: 1.7.0_154, vendor: Azul

Re: [VOTE] Release Apache Maven 3.5.1

Building the source bundles with the binary bundles in the staging repo using the Dockerfile environments in https://github.com/apache/maven-integration-testing/tree/master/environments Debian JDK 7 === Linux 65fb832dfe43 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64 GNU/Linux

Re: [VOTE] Release Apache Maven 3.5.1

False alarm, I missed configure global settings.xml, it is missing the default repository setup -D On Sun, Sep 10, 2017 at 11:47 PM, Tibor Digana wrote: > +1: > 3.5.1 works in my project like a charm ;-) > > On Sun, Sep 10, 2017 at 5:39 PM, Stephen Connolly < >

Re: [VOTE] Release Apache Maven 3.5.1

+1: 3.5.1 works in my project like a charm ;-) On Sun, Sep 10, 2017 at 5:39 PM, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > Hi, > > We solved 25 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > version=12338964=Text=12316922 > > There are 350 issues left in

Re: [VOTE] Release Apache Maven 3.5.1

I have no issue build maven 3.5.2-SNAPSHOT with clean verify at top level, but the following build fails mvn clean verify -f apache-maven C:\views\dev\maven\maven>mvn clean verify -f apache-maven [INFO] Scanning for projects... [INFO] [INFO]

Re: [VOTE] Release Apache Maven 3.5.1

I wonder if mng-6275 is affecting that plugin On Mon 11 Sep 2017 at 01:00, Mark Derricutt wrote: > +0 non-commital - > > Tested on our tiles/osgi based projects and all seems to work, but for > some reason - one project that uses the >

Re: [VOTE] Release Apache Maven 3.5.1

just tested "mvn verify" on Maven (did not build it previously, then no 3.5.2- SNAPSHOT artifact in my local repo), and works like a charm (as expected since artifacts are resolved from reactor) I can't reproduce the issue: does anybody else have same problems? Regards, Hervé Le dimanche 10

Re: [VOTE] Release Apache Maven 3.5.1

+0 non-commital - Tested on our tiles/osgi based projects and all seems to work, but for some reason - one project that uses the org.openqa.selenium.phantomjs.PhantomJSDriverService seems to blowing up when using 3.5.1 - need to do some more digging and see if I can spot whats going on. Will

Re: [VOTE] Release Apache Maven 3.5.1

Looks like 3.5.1 not able to resolve snapshot dependencies i just clone out apache-maven and, change directory to apache-maven and build from there here is error [ERROR] Failed to execute goal on project apache-maven: Could not resolve dependencies for project

Re: [VOTE] Release Apache Maven 3.5.1

Tested on several projects +1 On Sun, Sep 10, 2017 at 5:39 PM, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > Hi, > > We solved 25 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > version=12338964=Text=12316922 > > There are 350 issues left in JIRA for Maven

Re: [VOTE] Release Apache Maven 3.5.1

Analyzer... stagingUrl: https://repository.apache.org/content/repositories/maven-1364 groupId: org.apache.maven artifactId: apache-maven version: 3.5.1 Source ZIP url exists.

[VOTE] Release Apache Maven 3.5.1

Hi, We solved 25 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12338964=Text=12316922 There are 350 issues left in JIRA for Maven core: