Re: [VOTE] Release Apache Maven Release Plugin version 2.5.1

2014-09-20 Thread Karl Heinz Marbaise
Hi Robert, I'm pretty sure this is still an issue for every project. IIRC this is exactly the reason why Stephen thought of including/moving the mock repository manager to the maven-invoker-plugin. That much better to maintain than including all the extraArtifacts. Sounds good... btw,

Re: [VOTE] Release Apache Maven Release Plugin version 2.5.1

2014-09-19 Thread Robert Scholte
Op Thu, 18 Sep 2014 23:00:16 +0200 schreef Karl Heinz Marbaise khmarba...@gmx.de: Hi, I have admit the setting of M2_HOME did the trick...which looks a little bit strange for me... So maven 3.0.5 worked...but I have checked Maven 2.2.1 where integration tests of maven-release-plugin

Re: [VOTE] Release Apache Maven Release Plugin version 2.5.1

2014-09-19 Thread Robert Scholte
-1 due to the failure with M2.2.1 as reported by Karl-Heinz (great catch!) The fix is trivial[1], and worth including in this release. Robert ps. I was amazed that the invalid hint-attribute was accepted Sure we should move to Annotations, but that requires MRELEASE-703 to be fixed

Re: [VOTE] Release Apache Maven Release Plugin version 2.5.1

2014-09-19 Thread Benson Margulies
Can you commit the fix? I am on a train. On Sep 19, 2014 11:44 AM, Robert Scholte rfscho...@apache.org wrote: -1 due to the failure with M2.2.1 as reported by Karl-Heinz (great catch!) The fix is trivial[1], and worth including in this release. Robert ps. I was amazed that the invalid

Re: [VOTE] Release Apache Maven Release Plugin version 2.5.1

2014-09-19 Thread Dan Tran
is it a bug to file? Thanks -D On Thu, Sep 18, 2014 at 4:55 PM, Benson Margulies bimargul...@gmail.com wrote: I thought it was strange, too. Background: I checked out the trunk of maven-release, built, and got that error. I scratched my head for a day, and then a vague memory caused me to

Re: [VOTE] Release Apache Maven Release Plugin version 2.5.1

2014-09-19 Thread Karl Heinz Marbaise
Hi, after diving a little bit more i found the following issues... prerequisites: Offline (no internet connection) and a clean local repository: mvn -Prun-its clean verify so you got failures within the intergration test based on missing artifacts like: [ERROR] The following builds

Re: [VOTE] Release Apache Maven Release Plugin version 2.5.1

2014-09-19 Thread Benson Margulies
I made a JIRA to cover Robert's commit. On Fri, Sep 19, 2014 at 2:19 PM, Dan Tran dant...@gmail.com wrote: is it a bug to file? Thanks -D On Thu, Sep 18, 2014 at 4:55 PM, Benson Margulies bimargul...@gmail.com wrote: I thought it was strange, too. Background: I checked out the trunk of

Re: [VOTE] Release Apache Maven Release Plugin version 2.5.1

2014-09-19 Thread Robert Scholte
I'm pretty sure this is still an issue for every project. IIRC this is exactly the reason why Stephen thought of including/moving the mock repository manager to the maven-invoker-plugin. That much better to maintain than including all the extraArtifacts. btw, with Offline (no internet

Re: [VOTE] Release Apache Maven Release Plugin version 2.5.1

2014-09-18 Thread Karl Heinz Marbaise
Hi Benson, Checksum Ok. Site looks ok. Just a question: Do i need a special setup to run tests etc. of the package cause i got the following: tried via mvn -Prun-its clean verify Environment: Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19 14:51:28+0100) Maven

Re: [VOTE] Release Apache Maven Release Plugin version 2.5.1

2014-09-18 Thread Benson Margulies
You need to set M2 HOME. I have no longer underscore on my phone. On Sep 18, 2014 3:48 PM, Karl Heinz Marbaise khmarba...@gmx.de wrote: Hi Benson, Checksum Ok. Site looks ok. Just a question: Do i need a special setup to run tests etc. of the package cause i got the following: tried via

Re: [VOTE] Release Apache Maven Release Plugin version 2.5.1

2014-09-18 Thread Dan Tran
Strange M2_HOME implicitly set at mvn.bat/mvn startup scripts. -D On Thu, Sep 18, 2014 at 1:14 PM, Benson Margulies bimargul...@gmail.com wrote: You need to set M2 HOME. I have no longer underscore on my phone. On Sep 18, 2014 3:48 PM, Karl Heinz Marbaise khmarba...@gmx.de wrote: Hi

Re: [VOTE] Release Apache Maven Release Plugin version 2.5.1

2014-09-18 Thread Karl Heinz Marbaise
Hi, I have admit the setting of M2_HOME did the trick...which looks a little bit strange for me... So maven 3.0.5 worked...but I have checked Maven 2.2.1 where integration tests of maven-release-plugin failed: [DEBUG] (f) waitBeforeTagging = 0 [DEBUG] -- end configuration -- [INFO]

Re: [VOTE] Release Apache Maven Release Plugin version 2.5.1

2014-09-18 Thread Benson Margulies
I thought it was strange, too. Background: I checked out the trunk of maven-release, built, and got that error. I scratched my head for a day, and then a vague memory caused me to try setting M2_HOME. Bingo! So, since it was that way before I changed anything, and I'm pretty sure, in fact, that it

Re: [VOTE] Release Apache Maven Release Plugin version 2.5.1

2014-09-17 Thread Benson Margulies
+1 from me. On Wed, Sep 17, 2014 at 1:37 PM, Benson Margulies bimargul...@gmail.com wrote: Hi, We solved 4 issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11144version=20578 There are still a couple of issues left in JIRA: