[RESULT] [VOTE] Release Maven Checkstyle Plugin version 3.3.0

2023-05-22 Thread Michael Osipov
Hi, The vote has passed with the following result: +1: Slawomir Jaranowski, Sylwester Lachiewicz, Tamás Cservenák, Guillaume Nodet PMC quorum: reached I will promote the artifacts to the central repo, the source release ZIP file and add this release the board report.

Re: [VOTE] Release Maven Checkstyle Plugin version 3.3.0

2023-05-20 Thread Gary Gregory
Ah, I was misled by the PR title then. Thank you for the clarification! Gary On Sat, May 20, 2023, 12:53 Elliotte Rusty Harold wrote: > On Sat, May 20, 2023 at 3:33 PM Gary Gregory > wrote: > > > > Please don't change the default behavior to exclude test sources! > > Non-binding -1 from me. >

Re: [VOTE] Release Maven Checkstyle Plugin version 3.3.0

2023-05-20 Thread Elliotte Rusty Harold
On Sat, May 20, 2023 at 3:33 PM Gary Gregory wrote: > > Please don't change the default behavior to exclude test sources! > Non-binding -1 from me. > If you're referring to #76, that's not what it does. Test sources are still checked. What changes is that **generated code**, test and non-test

Re: [VOTE] Release Maven Checkstyle Plugin version 3.3.0

2023-05-20 Thread Gary Gregory
Please don't change the default behavior to exclude test sources! Non-binding -1 from me. Some tests serve as nice examples. I also want to enforce checkstyle for PR sources consistently whether the changes are in main or test. Please don't accepting this as is and make me edit dozens and dozens

Re: [VOTE] Release Maven Checkstyle Plugin version 3.3.0

2023-05-20 Thread Elliotte Rusty Harold
https://github.com/apache/maven-checkstyle-plugin/pull/76 is in progress from an external developer and is, IMHO, a quite nice improvement. Might be worth waiting for this to be finished up. Otherwise, I found some minor issues in dependencies and the tests, but nothing blocking. On Fri, May 19,

Re: [VOTE] Release Maven Checkstyle Plugin version 3.3.0

2023-05-20 Thread Guillaume Nodet
+1 Le ven. 19 mai 2023 à 15:49, Michael Osipov a écrit : > Hi, > > we solved 4 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317223=12353164 > > There are still a couple of issues left in JIRA: > >

Re: [VOTE] Release Maven Checkstyle Plugin version 3.3.0

2023-05-19 Thread Sylwester Lachiewicz
+1 pt., 19 maj 2023, 19:11 użytkownik Tamás Cservenák napisał: > +1 > > On Fri, May 19, 2023 at 3:49 PM Michael Osipov > wrote: > > > Hi, > > > > we solved 4 issues: > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317223=12353164 > > > > There are still a couple of

Re: [VOTE] Release Maven Checkstyle Plugin version 3.3.0

2023-05-19 Thread Tamás Cservenák
+1 On Fri, May 19, 2023 at 3:49 PM Michael Osipov wrote: > Hi, > > we solved 4 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317223=12353164 > > There are still a couple of issues left in JIRA: > >

Re: [VOTE] Release Maven Checkstyle Plugin version 3.3.0

2023-05-19 Thread Slawomir Jaranowski
+1 pt., 19 maj 2023 o 15:49 Michael Osipov napisał(a): > Hi, > > we solved 4 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317223=12353164 > > There are still a couple of issues left in JIRA: > >

[VOTE] Release Maven Checkstyle Plugin version 3.3.0

2023-05-19 Thread Michael Osipov
Hi, we solved 4 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317223=12353164 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project+%3D+MCHECKSTYLE+AND+resolution+%3D+Unresolved Staging repo: