Re: [massembly] code question

2019-12-19 Thread Romain Manni-Bucau
If we can still log included deps are empty (agree it should be real deps and not these ones) elsewhere +1 (think otherwise it looks something went wrong in debug mode, no log does not mean empty if you follow me) Le jeu. 19 déc. 2019 à 16:43, Anders Hammar a écrit : > I agree. It's strange and

Re: [massembly] code question

2019-12-19 Thread Anders Hammar
I agree. It's strange and the debug log output is actually technically wrong. So I'd say remove it. /Anders On Thu, Dec 19, 2019 at 2:39 PM Mark Struberg wrote: > Hi! > > Feeling a bit rusty, so I thought I better ask for a 2nd opinion. > > To me it looks like the following code block is

Re: [massembly] code question

2019-12-19 Thread Mark Struberg
Well, the project dependencies may or may not be used depending on your assembly setup. The only data which is used in this scenario is List dependencySets; So it might probably be fine to add a logging if the dependencySets is empty. The only part where the project dependencies are really used

Re: [massembly] code question

2019-12-19 Thread Romain Manni-Bucau
@Mark: likely studid but do you get the debug insight removing it on a project without dependencies? Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github

[massembly] code question

2019-12-19 Thread Mark Struberg
Hi! Feeling a bit rusty, so I thought I better ask for a 2nd opinion. To me it looks like the following code block is really obsolete and did not make anything useful ever since