Re: Modernizing plugin dependencies

2020-05-13 Thread Benson Margulies
Would it make sense to branch from 2.1 and do a controlled update? What version of maven core are we willing to require? On Wed, May 13, 2020 at 1:41 PM Benson Margulies wrote: > 2.1 has a terrible bug; it does not compensate for long-ago changes in > which ArtifactItem.getClassifier() returns

Re: Modernizing plugin dependencies

2020-05-13 Thread Benson Margulies
2.1 has a terrible bug; it does not compensate for long-ago changes in which ArtifactItem.getClassifier() returns null instead of "". I think then perhaps branching it and making a 2.1.1 is called for. On Wed, May 13, 2020 at 5:52 AM Karl Heinz Marbaise wrote: > Hi, > > On 13.05.20 01:59,

Re: Modernizing plugin dependencies

2020-05-13 Thread Elliotte Rusty Harold
maven-plugin-testing-harness 2.1 should work for most cases, and many of our plugins are not that far up to date yet. But yes, we do have a major issue with failing to update deep dependencies like plexus, aether, sisu, maven core, and the testing harness across all the repos. On Wed, May 13,

Re: Modernizing plugin dependencies

2020-05-13 Thread Sylwester Lachiewicz
Right I saw this problems, maven testing plugin next version 3.3.0 ( released 2014) requires Maven core 3.2.5 - so it will not be useful for long time .. Sylwester śr., 13 maj 2020, 14:52 użytkownik Karl Heinz Marbaise napisał: > Hi, > > On 13.05.20 01:59, Benson Margulies wrote: > > What's

Re: Modernizing plugin dependencies

2020-05-13 Thread Karl Heinz Marbaise
Hi, On 13.05.20 01:59, Benson Margulies wrote: What's current best practice for updating the versions of the test harness and other bits and bobs? the problem with Test harness is that it brings more recent versions of maven-core with it which is from my point of view a no go for test

Re: Modernizing plugin dependencies

2020-05-13 Thread Elliotte Rusty Harold
It's a very good thing to do. That said, updating the test harness is usually a lot more difficult than it looks. It tends to pull in incompatible versions of Plexus, Sisu, and Aether requiring a lot of code changes throughout the plugin. On Tue, May 12, 2020 at 8:00 PM Benson Margulies wrote:

Re: Modernizing plugin dependencies

2020-05-12 Thread Maarten Mulders
There has been a (short) discussion on this topic recently in this list [1]. Although it contained no formal vote, my provisional conclusion would be to create a JIRA ticket and then provide a merge request. Thanks, Maarten [1]

Modernizing plugin dependencies

2020-05-12 Thread Benson Margulies
What's current best practice for updating the versions of the test harness and other bits and bobs?