Re: Please review maven-assembly-plugin site documentation

2006-09-06 Thread Dennis Lundberg
berndq wrote: Edwin Punzalan wrote: A staging site is currently available at http://people.apache.org/~epunzalan/maven-assembly-plugin. Thank you for taking some time to review it. - Binding to package phase: in the example there is phasepackaging/phase Works for me only with

Re: Please review maven-assembly-plugin site documentation

2006-08-31 Thread berndq
Edwin Punzalan wrote: A staging site is currently available at http://people.apache.org/~epunzalan/maven-assembly-plugin. Thank you for taking some time to review it. - Binding to package phase: in the example there is phasepackaging/phase Works for me only with phasepackage/phase -

Re: Please review maven-assembly-plugin site documentation

2006-07-31 Thread Edwin Punzalan
staging site updated with a patch from MASSEMBLY-130 applied. Again, thanks for the reviewers. ^_^ Edwin Punzalan wrote: Hi, I've made some changes to the documentation of the Assembly plugin and would like to hear your inputs about it. - made the plugin docck-compliant - edited the

Re: Please review maven-assembly-plugin site documentation

2006-07-31 Thread Barrie Treloar
On 7/31/06, Edwin Punzalan [EMAIL PROTECTED] wrote: staging site updated with a patch from MASSEMBLY-130 applied. Did I stuff up the patch? * http://people.apache.org/~epunzalan/maven-assembly-plugin/examples/index.html is missing a link to the include-and-exclude.html (It is included in the

Re: Please review maven-assembly-plugin site documentation

2006-07-30 Thread Edwin Punzalan
Hi, Thanks for the review. Please see my inline comments below... Dennis Lundberg wrote: Hi Edwin I have committed a fix for a few typos. Here are some additional comments om the assembly plugin documentation: assembly-mojo.html - archiverManager, artifactResolver and repositoryAssembler

Re: Please review maven-assembly-plugin site documentation

2006-07-28 Thread Dennis Lundberg
Edwin Punzalan wrote: Hi, I've made some changes to the documentation of the Assembly plugin and would like to hear your inputs about it. - made the plugin docck-compliant - edited the descriptions inside the modello files - edited some of the parameter descriptions - added an faq page

Re: Please review maven-assembly-plugin site documentation

2006-07-28 Thread Barrie Treloar
Any chance i can get MASSEMBLY-118, 119, 130 looked at the same time? 130 is a doc patch - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Please review maven-assembly-plugin site documentation

2006-07-26 Thread Edwin Punzalan
Hi, I've made some changes to the documentation of the Assembly plugin and would like to hear your inputs about it. - made the plugin docck-compliant - edited the descriptions inside the modello files - edited some of the parameter descriptions - added an faq page - added some single

Re: Please review maven-assembly-plugin site documentation

2006-07-26 Thread Milos Kleint
when you clink on Using repositories in navigation bar, you don't get any page. There is a typo in the path, it's using single instead of simple or vice versa.. Milos On 7/26/06, Edwin Punzalan [EMAIL PROTECTED] wrote: Hi, I've made some changes to the documentation of the Assembly plugin

RE: Please review maven-assembly-plugin site documentation

2006-07-26 Thread Cabasson Denis
:[EMAIL PROTECTED] Envoyé : mercredi 26 juillet 2006 13:34 À : Maven Developers List Objet : Please review maven-assembly-plugin site documentation Hi, I've made some changes to the documentation of the Assembly plugin and would like to hear your inputs about it. - made the plugin docck

Re: Please review maven-assembly-plugin site documentation

2006-07-26 Thread Vincent Siveton
Hi Edwin, Great job! Thanks. Here my comments: Navbar: Missing goals link to be in line with the standard As already said, review links. index.html Missing usage part as usual. features.html What is the current version? Maybe add a link to /project-summary.html faq.html is ran = is run

Re: Please review maven-assembly-plugin site documentation

2006-07-26 Thread Andreas Hochsteger
http://people.apache.org/~epunzalan/maven-assembly-plugin/index.html: * tar.bz - tar.gz * tar.gz2 - tar.bz2 http://people.apache.org/~epunzalan/maven-assembly-plugin/descriptor-refs.html In the 'src' section there is a sentence which starts with The bin descriptorId produces which should be

Re: Please review maven-assembly-plugin site documentation

2006-07-26 Thread Edwin Punzalan
Changes applied and deployed in the same staging site. - fixed simple links to single - added an faq on using javadoc to jar javadoc files docs - added goals in the navigation bar - added link to the project summary page in features.html - fixed some typos and grammatical errors - removed