Re: maven git commit: [MNG-6069] Migrate to non deprecated parts of Commons CLI

I think I have fixed this issue with b424af57a56a4059763000b87bbe5e4331329b36 On 19 March 2017 at 20:24, Stephen Connolly wrote: > Tests are failing because system properties are not being parsed correctly > with the new builder based options. > > It seems

Re: maven git commit: [MNG-6069] Migrate to non deprecated parts of Commons CLI

Tests are failing because system properties are not being parsed correctly with the new builder based options. It seems that we get for `-Drevision=1.3.0 -Dmaven.local.repo=/foo/bar` when on MavenCli line 1676 we get defStrs == { "revision", "1.3.0", "maven.local.repo", "/foo/bar"} This results

Re: maven git commit: [MNG-6069] Migrate to non deprecated parts of Commons CLI

If the tests are not working by Monday then it's out on its ear ;-) On Sun 19 Mar 2017 at 18:11, Karl Heinz Marbaise wrote: > Hi, > > I'm not sure if this for 3.5.0 beta or what ever we call it...at the > moment the tests are not working...and I need to dive into it why are >

Re: maven git commit: [MNG-6069] Migrate to non deprecated parts of Commons CLI

Hi, I'm not sure if this for 3.5.0 beta or what ever we call it...at the moment the tests are not working...and I need to dive into it why are failing..it looks there are missing some dependencies..but I'm note sure about it... But it looks you have already decided what to do... Kind

Re: maven git commit: [MNG-6069] Migrate to non deprecated parts of Commons CLI

Hervé and I were discussing this on IRC... perhaps we can merge this for 3.5.0-beta-1 and if it causes issues then we can revert for 3.5.0 As these are public static final String and char constants, it should not break binary compatibility as javac inlines static final constants... it may break

Re: maven git commit: [MNG-6069] Migrate to non deprecated parts of Commons CLI

Are you *really* sure these public static final fields are only used here? On Sat, 18 Mar 2017 18:19:05 +0100, wrote: Repository: maven Updated Branches: refs/heads/MNG-6069 [created] b8efec709 [MNG-6069] Migrate to non deprecated parts of Commons CLI Project: