Re: svn commit: r1763929 - /maven/shared/trunk/maven-artifact-transfer/src/main/java/org/apache/maven/shared/project/install/internal/DefaultProjectInstaller.java

2016-10-09 Thread Karl Heinz Marbaise
Hi Guillaume, This is already used in other locations of the maven-artifact-transfer... Maven30ArtifactRepositoryAdapter, Maven31ArtifactRepositoryAdapter, Maven30ArtifactDeployer, Maven31ArtifactDeployer...only to mention a few... org.apache.maven.repository.legacy.metadata.ArtifactMetadata

Re: svn commit: r1763929 - /maven/shared/trunk/maven-artifact-transfer/src/main/java/org/apache/maven/shared/project/install/internal/DefaultProjectInstaller.java

2016-10-09 Thread Guillaume Boué
The only quirk is that org.apache.maven.artifact.metadata.ArtifactMetadata is deprecated... so this would add usage of the deprecated interface in RepositoryManager. What is the alternative for this? Le 09/10/2016 à 14:36, Karl Heinz Marbaise a écrit : Hi Buillaume, On 09/10/16 14:28,

Re: svn commit: r1763929 - /maven/shared/trunk/maven-artifact-transfer/src/main/java/org/apache/maven/shared/project/install/internal/DefaultProjectInstaller.java

2016-10-09 Thread Karl Heinz Marbaise
Hi Buillaume, On 09/10/16 14:28, Guillaume Boué wrote: If the caller needs to force a different local repository than the one in the Maven session, they can already call "repositoryManager.setLocalRepositoryBasedir" on the building request that is passed to ProjectInstaller. This is what the

Re: svn commit: r1763929 - /maven/shared/trunk/maven-artifact-transfer/src/main/java/org/apache/maven/shared/project/install/internal/DefaultProjectInstaller.java

2016-10-09 Thread Guillaume Boué
If the caller needs to force a different local repository than the one in the Maven session, they can already call "repositoryManager.setLocalRepositoryBasedir" on the building request that is passed to ProjectInstaller. This is what the plugins using ArtifactInstaller are already doing, and

Re: svn commit: r1763929 - /maven/shared/trunk/maven-artifact-transfer/src/main/java/org/apache/maven/shared/project/install/internal/DefaultProjectInstaller.java

2016-10-09 Thread Karl Heinz Marbaise
Hi, Yes it has been introduced by me...and yes not all plugins are using it cause I would like to have some tests before spreading it to the "world" of plugins.. Kind regards Karl Heinz On 09/10/16 11:07, Robert Scholte wrote: Hi, IIRC ProjectInstaller has been introduced recently, I can

Re: svn commit: r1763929 - /maven/shared/trunk/maven-artifact-transfer/src/main/java/org/apache/maven/shared/project/install/internal/DefaultProjectInstaller.java

2016-10-09 Thread Robert Scholte
Hi, IIRC ProjectInstaller has been introduced recently, I can imagine it hasn't been pushed to all plugins which should use it instead of the ArtifactInstaller. While implementing maven-artifact-transfer and using it in several plugins I just hit these edge cases where the local repo is

Re: svn commit: r1763929 - /maven/shared/trunk/maven-artifact-transfer/src/main/java/org/apache/maven/shared/project/install/internal/DefaultProjectInstaller.java

2016-10-08 Thread Guillaume Boué
Hi, From what I checked, I don't think those plugins should be impacted since they use the ArtifactInstaller directly, and not the ProjectInstaller. But I can add an overload taking an ArtifactRepository which would get the path to the artifact with "artifactRepository.pathOf(artifact)". And

Re: svn commit: r1763929 - /maven/shared/trunk/maven-artifact-transfer/src/main/java/org/apache/maven/shared/project/install/internal/DefaultProjectInstaller.java

2016-10-08 Thread Robert Scholte
Hi Guillaume, although this is often true, there are some plugins which create their own local repository, for instance maven-invoker-plugin and maven-dependency-plugin. In those cases you should pass the ArtifactRepository. So we will need those versions too, either as overloaded method