Re: errors reported by Checkstyle

2014-10-26 Thread Kristian Rosenvold
I dont mind the checkstyle stuff, but we have /not/ had a vote that mandates this to be a requirement. Until we do so I think we should safely just add skip to checkstyle where it's inappropriate, or ignore more stuff. Kristian 2014-10-25 20:36 GMT+02:00 Andreas Gudian andreas.gud...@gmail.com:

Re: errors reported by Checkstyle

2014-10-26 Thread Dennis Lundberg
Hi, My personal preference is to have all annotations first, i.e. before the visibility modifier. I checked the JLS, but couldn't find any recommendation. The examples in chapter 9.7 use the order that Checkstyle suggests. -- Dennis Lundberg Den 25 okt 2014 20:38 skrev Andreas Gudian

Re: errors reported by Checkstyle

2014-10-26 Thread Dennis Lundberg
I agree, and believe that it was Hervè's intention for this to be a soft rule, at least to start with. -- Dennis Lundberg Den 26 okt 2014 07:47 skrev Kristian Rosenvold kristian.rosenv...@gmail.com: I dont mind the checkstyle stuff, but we have /not/ had a vote that mandates this to be a

Re: errors reported by Checkstyle

2014-10-26 Thread Karl Heinz Marbaise
Hi, i have a question for this topic: checkstyle reported that the license header is not correct... [INFO] There are 5 checkstyle errors. [ERROR] JavaCodeTransform.java[4] (header) RegexpHeader: Line does not match expected header line of '^ \* Licensed to the Apache Software Foundation

Re: errors reported by Checkstyle

2014-10-26 Thread Hervé BOUTEMY
in general, annotations on a method are about the method: actual recomendation is ok for that but JSR 305 annotations are about the return type: IMHO, these annotations are best like proposed by Andreas this would require Checkstyle new feature and consensus in the Maven team to use it let's

Re: errors reported by Checkstyle

2014-10-25 Thread Andreas Gudian
I've started switching on maven-parent 25 in surefire now and I see literary hundreds of checkstyle errors (I ignore the warnings for now). Most of the stuff is fine with me and I'm on fixing them for a couple of days already. But there's one thing that struck me and that I'm a bit reluctant to

Re: errors reported by Checkstyle

2014-10-14 Thread Hervé BOUTEMY
Le mardi 14 octobre 2014 09:28:21 Olivier Lamy a écrit : On 14 October 2014 05:01, Hervé BOUTEMY herve.bout...@free.fr wrote: 2. if we configured Checkstyle to report an error, this means check should fail: if you find that it should not fail, please help improve Checkstyle configuration by

Re: errors reported by Checkstyle

2014-10-13 Thread Hervé BOUTEMY
BOUTEMY herve.bout...@free.fr wrote: Log: - Fixed several Checkstyle errors. notice that these are errors *reported by* Checkstyle, not really Checkstyle errors Checkstyle should add don't shoot the messenger disclaimer ;) I report here because next maven-parent version

Re: errors reported by Checkstyle

2014-10-13 Thread Olivier Lamy
that these are errors *reported by* Checkstyle, not really Checkstyle errors Checkstyle should add don't shoot the messenger disclaimer ;) I report here because next maven-parent version will enable Checkstyle check on every build: we must all know that we chose the rules that Checkstyle will report

Re: errors reported by Checkstyle

2014-10-13 Thread Stephen Connolly
conventions on daily operations: nothing really hard Regards, Hervé On 11 October 2014 18:00, Hervé BOUTEMY herve.bout...@free.fr javascript:; wrote: Log: - Fixed several Checkstyle errors. notice that these are errors *reported by* Checkstyle, not really Checkstyle errors

Re: errors reported by Checkstyle

2014-10-13 Thread Olivier Lamy
. notice that these are errors *reported by* Checkstyle, not really Checkstyle errors Checkstyle should add don't shoot the messenger disclaimer ;) I report here because next maven-parent version will enable Checkstyle check on every build: we must all know that we chose

Re: errors reported by Checkstyle

2014-10-13 Thread Benson Margulies
Members of this PMC are not shy about demanding that code style conform. I would rather fail a build because I forgot the stupid spaces around the stupid parameters than have to scramble and fix something when someone complains. Let's get checkstyle to enforce what seems we enforce anyway, and

Re: errors reported by Checkstyle

2014-10-12 Thread Olivier Lamy
errors. notice that these are errors *reported by* Checkstyle, not really Checkstyle errors Checkstyle should add don't shoot the messenger disclaimer ;) I report here because next maven-parent version will enable Checkstyle check on every build: we must all know that we chose the rules

errors reported by Checkstyle

2014-10-11 Thread Hervé BOUTEMY
Log: - Fixed several Checkstyle errors. notice that these are errors *reported by* Checkstyle, not really Checkstyle errors Checkstyle should add don't shoot the messenger disclaimer ;) I report here because next maven-parent version will enable Checkstyle check on every build: we must

Re: errors reported by Checkstyle

2014-10-11 Thread Karl Heinz Marbaise
Hi Hervé, On 10/11/14 9:00 AM, Hervé BOUTEMY wrote: Log: - Fixed several Checkstyle errors. notice that these are errors *reported by* Checkstyle, not really Checkstyle errors Checkstyle should add don't shoot the messenger disclaimer ;) I don't shoot the messagernever..already