Re: migrating Surefire to 3.0-RC1

Hi Tibor, Those mentioned are real components, they are injected as if they were annoted with @Inject. I don't think you need metadatasource, while refactoring other plugins I could get rid of it. Robert Op Sun, 07 Feb 2016 13:44:59 +0100 schreef Tibor Digana

Re: migrating Surefire to 3.0-RC1

Thx and it seems the deprecated ArtifactFactory can be substituted with RepositorySystem as well. There's the last failing IT which needs to be resolved Surefire141PluggableProvidersIT. And then we need to fix the maven-surefire-common with maven-artifact-transfer, because I avoided relocation in

Re: migrating Surefire to 3.0-RC1

Hi Robert, I already updated some @Component-s with @Parameter. Few components still remain. How these can be used with @Parameter? @Component private ArtifactResolver artifactResolver; @Component private ToolchainManager toolchainManager; @Component private RepositorySystem repositorySystem;

Re: migrating Surefire to 3.0-RC1

I used transformer which threw exception in maven-surefire-plugin runtime : *[WARNING] Error injecting: org.apache.maven.surefire.shade.org.apache.maven.shared.artifact.resolve.internal.DefaultArtifactResolverjava.lang.TypeNotPresentException: Type

Re: migrating Surefire to 3.0-RC1

Hi Robert, I fixed the transitive artifact resolution. See the branch 3.0-rc1. The only remaining to fix is Java packages relocation of *-shared artifacts in maven-surefire-common. Cheers Tibor On Sun, Jan 17, 2016 at 8:09 PM, Tibor Digana wrote: > I used

Re: migrating Surefire to 3.0-RC1

Hi Robert, A new problem with maven-artifact-transfer. Should we really shade it? Not able to inject ArtifactResolver as it seems: [INFO] --- maven-surefire-plugin:2.19.2-SNAPSHOT:test (default-test) @ child --- [WARNING] Error injecting: org.apache.maven.plugin.surefire.SurefirePlugin

Re: migrating Surefire to 3.0-RC1

Hi Tibor, I actually had the same question about the other dependencies which are shaded. Based on the exception I would expect that you need a transformer[1], based on the excepted I would say the PluginXmlResourceTransformer (otherwise ComponentsXmlResourceTransformer). The other option

Re: migrating Surefire to 3.0-RC1

Hi Robert and devs, I fixed artifact resolution issues we spoke about last time, see the branch 3.0-rc1, you may now have a look in surefire project. but there is the last issue. I should exclude org .apache.maven.shared.artifact.resolve.ArtifactResolverException from reallocation in

Re: migrating Surefire to 3.0-RC1

Hi Tibor, Regarding the artifactResolver.resolveTransitively, this has been replaced with dependencyResolver. The reason is that an artifact is basically a coordinate with a file, it is not aware of dependencies. I've traced one down for you:

Re: migrating Surefire to 3.0-RC1

I would recommend that you instead update the existing wiki page that we use to gather "tips" about migrating plugins: https://cwiki.apache.org/confluence/display/MAVEN/Plugin+migration+to+Maven3+dependencies Kristian 2016-01-08 1:18 GMT+01:00 Tibor Digana : > Hi

Re: migrating Surefire to 3.0-RC1

Adding maven-compat for the test did the trick for now in my case. If only I had read that wiki page before, because it actually describes this already... :-D 2016-01-08 14:55 GMT+01:00 Tibor Digana : > Hi Kristian, > > I do not have edit permissions in confluence. Who

Re: migrating Surefire to 3.0-RC1

Hi Kristian, I do not have edit permissions in confluence. Who can grant me? On Fri, Jan 8, 2016 at 9:41 AM, Kristian Rosenvold-4 [via Maven] < ml-node+s40175n5858379...@n5.nabble.com> wrote: > I would recommend that you instead update the existing wiki page that we > use to gather "tips" about

Re: migrating Surefire to 3.0-RC1

Hi Andreas, See Robert's change. This maybe helps https://github.com/apache/maven-surefire/commit/9cb143414134a2c8f0bfec5b84f01571875a26fe On Thu, Jan 7, 2016 at 9:54 PM, Andreas Gudian wrote: > Hey, > > funny, I ran into the very same problem when working on

Re: migrating Surefire to 3.0-RC1

Hi Tibor, so this is not how it should be done. Compat contains classes which Maven2 classes which have been replaced by Maven3 or are not used anymore. Only plugins which need to stay compatible with Maven2 should include this dependency. I'll update the page, because we've decided to

Re: migrating Surefire to 3.0-RC1

Hey, funny, I ran into the very same problem when working on MCOMIPLER-203 and after updating to Maven 3.0 dependencies: I'm getting the very same exception when running the CompilerMojoTestCase. I'm all ears on how to solve that, so if anyone has a hint... :) I pushed a branch on github, and,

Re: migrating Surefire to 3.0-RC1

Hi Tibor, Bullet 4: Remove maven-compat (or give it the test-scope if it is required by the maven-plugin-testing-harness) Now I think you're at a state where Maven2 classes must be replaced with Maven3 solutions. Robert Op Thu, 07 Jan 2016 18:54:06 +0100 schreef Tibor Digana

Re: migrating Surefire to 3.0-RC1

Now I removed maven-compat completely. org.apache.maven.shared maven-artifact-transfer 3.0-SNAPSHOT It seems release version is not available. I should resolve compilation error after new 3.0 AtrifactResolver and I will come back to you. return artifactResolver.resolveTransitively(

Re: migrating Surefire to 3.0-RC1

Thx Andreas. It seems all todo 3.0 plugins are quietly in progress. If we are going to struggle with the same issue, we should use this thread and post solutions. LGTM On Thu, Jan 7, 2016 at 9:54 PM, Andreas Gudian [via Maven] < ml-node+s40175n5858345...@n5.nabble.com> wrote: > Hey, > > funny, I

migrating Surefire to 3.0-RC1

I missing this import in MOJO after migrating plugin to 3.0 import org.apache.maven.shared.artifact.resolve.ArtifactResolver; The doc [1] says that maven-artifact-transfer should be used but it does not have yet a release version, or? org.apache.maven.shared maven-artifact-transfer

Re: migrating Surefire to 3.0-RC1

P=NP maven-compat made the trick org.apache.maven maven-compat On Thu, Jan 7, 2016 at 12:09 AM, Tibor Digana-2 [via Maven] < ml-node+s40175n5858124...@n5.nabble.com> wrote: > I missing this import in MOJO after migrating plugin to 3.0 > > > import