Re: [GitHub] maven-plugins pull request #91: MCHANGES-373

Hello Mikael, Michael Osipov has asked two times why the change set shows the whole class as changed. So there has been feedback. Regards, Benedikt Mikael Petterson schrieb am Mi., 7. Sep. 2016 um 08:08 Uhr: > Hi, > > Is there no one that can help out with my pull request or is the > maven-cha

Re: MNG-5889 fix available

Hello Robert, you can either create a git diff and attach it as txt file to the jira issue or you submit a pull request using the GitHub mirror at https://github.com/apache/maven. Regards, Benedikt Robert Patrick schrieb am Mi., 7. Sep. 2016 um 00:04 Uhr: > I have fixed for Bug HYPERLINK " > h

RE: [GitHub] maven-plugins pull request #91: MCHANGES-373

Hi, My mistake :-) Br, //mikael -Original Message- From: Benedikt Ritter [mailto:brit...@apache.org] Sent: den 7 september 2016 11:36 To: Maven Developers List Subject: Re: [GitHub] maven-plugins pull request #91: MCHANGES-373 Hello Mikael, Michael Osipov has asked two times why t

Re: [GitHub] maven-plugins pull request #91: MCHANGES-373

Hi, all of the maven committers are doing work on Maven in their spare time... So it takes as long as it takes... Kind regards Karl Heinz Marbaise On 07/09/16 08:08, Mikael Petterson wrote: Hi, Is there no one that can help out with my pull request or is the maven-changes plugin "dead"? We

Re: MNG-5889 fix available

Thanks, I submitted the pull request. > On Sep 7, 2016, at 4:37 AM, Benedikt Ritter wrote: > > Hello Robert, > > you can either create a git diff and attach it as txt file to the jira > issue or you submit a pull request using the GitHub mirror at > https://github.com/apache/maven. > > Regards

[GitHub] maven-surefire pull request #118: Add basic integration test for JUnit 5

Github user britter commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/118#discussion_r77858530 --- Diff: surefire-integration-tests/src/test/resources/junit5/src/test/java/junit5/JUnit4Test.java --- @@ -0,0 +1,67 @@ +package junit5; +

[GitHub] maven-surefire pull request #118: Add basic integration test for JUnit 5

Github user britter commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/118#discussion_r77860110 --- Diff: surefire-integration-tests/src/test/resources/junit5/src/test/java/junit5/JUnit4Test.java --- @@ -0,0 +1,67 @@ +package junit5; +

[GitHub] maven-surefire issue #118: Add basic integration test for JUnit 5

Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/118 @Tibor17 thank you for the input. I'd like to take have small PRs, so my proposal is to introduce this first PR and merge it to the code base after your comments have been resolved and then w

Code Style for IntelliJ 2016.2

Hi maven devs, which code style file do you use for IntelliJ 2016.2? I've imported the file from http://maven.apache.org/developers/committer-environment.html but is does not work properly (for example is does not place curly braces on new lines) Thank you! Benedikt

[SUREFIRE] How does Junit4VersionsIT work?

Hi surefire devs, I don't understand how the Junit4VersionsIT sets the JUnit version to use during testing. The version is set as sysProp "junit.version" on mavenLauncher, but the test pom.xml in the resources/junit4 folder uses ${junitVersion} to set the JUnit version. How does this work? Does ma

[GitHub] maven-surefire issue #118: Add basic integration test for JUnit 5

Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/118 @Tibor17 worked through all your comments. Can this be merged as a first starter for JUnit 5 ITs? --- If your project is set up for it, you can reply to this email and have your reply appear