Re: [SUREFIRE] Hangout with Marc Philipp

2016-10-11 Thread Tibor Digana
Hi Benedikt, I do not have any problem with SNAPSHOT version in the branch junit5. Even this can be very easily accomplished. Let's put property, e.g. version.junit5, into [1] and reference to this POM via parent declaration in your root POM of particular IT having JUnit5 tests. [1]

[GitHub] maven-surefire issue #127: [SUREFIRE-1293] Simplify org.apache.maven.plugin....

2016-10-11 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/127 After we are done with all commits, would you be able to safely squash them in one single commit? --- If your project is set up for it, you can reply to this email and have your reply

RE: upgrade maven plugin to run with asm 6?

2016-10-11 Thread Martin Gainty
i find throwing everything in the kitchen sink and hoping all the dishes get cleaned doesnt workpick one variable such as maven-plugin-plugin and introduce each new version by a point release3.0 causes exception3.1 causes exception...3.5 works with asm6 and JDK 1.9 eventually you'll determine

Re: Cannot build current master.

2016-10-11 Thread Christian Schulte
Am 10/11/16 um 21:50 schrieb Karl Heinz Marbaise: > Hi Guillaue, > > On 11/10/16 21:21, Guillaume Boué wrote: >> Regarding this failure, I think it is caused by a capitalization >> issue... The test is looking for >> "missing-artifactid-pluginManagement.xml" (lowercase "i" at artifactid) >> while

Re: [SUREFIRE] Hangout with Marc Philipp

2016-10-11 Thread Tibor Digana
Sorry for my typos, again: *Maybe we should setup second trigger in Jenkins build for junir5 branch and run ASF build if any change is pushed to ASF or JUnit Git repository.* On Tue, Oct 11, 2016 at 7:48 PM, Tibor Digana wrote: > We can follow already existing principle

Re: [SUREFIRE] Hangout with Marc Philipp

2016-10-11 Thread Tibor Digana
We can follow already existing principle and declare JUnit5 version in [1]. There is already such good example: ${project.version} ${testng.version} [1] https://github.com/apache/maven-surefire/blob/master/surefire-integration-tests/pom.xml Regarding Surefire JUnit5 Provider, you can integrate

[GitHub] maven-surefire pull request #126: Make Junit4VersionsIT parameterized

2016-10-11 Thread britter
Github user britter closed the pull request at: https://github.com/apache/maven-surefire/pull/126 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] maven-surefire issue #126: Make Junit4VersionsIT parameterized

2016-10-11 Thread britter
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/126 Okay, this is reintegrated. I will fix it in another PR. Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Re: Cannot build current master.

2016-10-11 Thread Guillaume Boué
Regarding this failure, I think it is caused by a capitalization issue... The test is looking for "missing-artifactid-pluginManagement.xml" (lowercase "i" at artifactid) while the file on disk is called "missing-artifactId-pluginManagement.xml" (uppercase "i"). I don't have the issue on

Re: Cannot build current master.

2016-10-11 Thread Karl Heinz Marbaise
Hi Guillaue, On 11/10/16 21:21, Guillaume Boué wrote: Regarding this failure, I think it is caused by a capitalization issue... The test is looking for "missing-artifactid-pluginManagement.xml" (lowercase "i" at artifactid) while the file on disk is called

[GitHub] maven-surefire issue #127: [SUREFIRE-1293] Simplify org.apache.maven.plugin....

2016-10-11 Thread britter
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/127 Hello @Tibor17, I'll fix the checkstyle violations and squash everything into one single commit! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] maven-surefire issue #125: Consistently rename JUnit 4.x integration tests

2016-10-11 Thread britter
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/125 @Tibor17 rebased with master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] maven-surefire pull request #124: Fix formatting, convert tabs to spaces

2016-10-11 Thread britter
Github user britter closed the pull request at: https://github.com/apache/maven-surefire/pull/124 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: [SUREFIRE] Parameterized Tests for Junit 4 and Junit 5? (Was: [SUREFIRE] JUnit 5 support - how to move things forward?)

2016-10-11 Thread Tibor Digana
Both old Jenkins builds [1] already use JDK 8. So this should not be a problem. [1] https://builds.apache.org/job/maven-surefire/ https://builds.apache.org/job/maven-surefire-windows/ On Mon, Oct 10, 2016 at 7:03 PM, Benedikt Ritter [via Maven] < ml-node+s40175n5882750...@n5.nabble.com> wrote: