Re: maven-3.x-jenkinsfile/embedded-ITs - build #3 - UNSTABLE

2017-03-28 Thread Igor Fedorenko
Good point! .mvn/maven.config is handled by MavenCli and should not require forked execution. .mvn/jvm.config is handled by mvn shell script and does require forked execution. Verifier "auto" mode does not currently consider presence of .mvn/jvm.config, so we'll either need fix Verifier or force

Re: maven-3.x-jenkinsfile/embedded-ITs - build #3 - UNSTABLE

2017-03-28 Thread Hervé BOUTEMY
ok, no issue found, then embedded mode merged to master later switching back to non-embedded is easy if necessary Regards, Hervé Le samedi 25 mars 2017, 17:32:38 CEST Hervé BOUTEMY a écrit : > thanks for the complements > FTR, I checked and added pointers to code > > Regards, > > Hervé > >

Re: maven-3.x-jenkinsfile/embedded-ITs - build #3 - UNSTABLE

2017-03-28 Thread Stephen Connolly
Does it force a fork if there is a .mvn/maven.config file to be picked up? On Tue 28 Mar 2017 at 07:07, Hervé BOUTEMY wrote: > ok, no issue found, then embedded mode merged to master > > later switching back to non-embedded is easy if necessary > > Regards, > > Hervé > >

Re: maven-3.x-jenkinsfile/embedded-ITs - build #3 - UNSTABLE

2017-03-28 Thread Stephen Connolly
On 28 March 2017 at 11:56, Igor Fedorenko wrote: > Good point! > > .mvn/maven.config is handled by MavenCli and should not require forked > execution. > > .mvn/jvm.config is handled by mvn shell script and does require forked > execution. Verifier "auto" mode does not

Re: What to do with the 6 issues left as 3.5.0-candidates?

2017-03-28 Thread Stephen Connolly
Looked fine to me when I found it just after writing my version! Merge away! On Tue 28 Mar 2017 at 20:31, Robert Scholte wrote: > I've created a branch for MNG-6185, ready to be merged. > > Robert > > On Fri, 24 Mar 2017 11:45:14 +0100, Stephen Connolly >

[GitHub] maven issue #110: plexus

2017-03-28 Thread ifedorenko
Github user ifedorenko commented on the issue: https://github.com/apache/maven/pull/110 spam? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] maven pull request #110: plexus

2017-03-28 Thread devopsharish
GitHub user devopsharish opened a pull request: https://github.com/apache/maven/pull/110 plexus You can merge this pull request into a Git repository by running: $ git pull https://github.com/devopsharish/maven master Alternatively you can review and apply these changes as

Re: Review request

2017-03-28 Thread Robert Scholte
Just to confirm: on Windows in all three cases the tests are skipped when following the steps to reproduce MNG-6198 Robert On Mon, 27 Mar 2017 22:08:06 +0200, Stephen Connolly wrote: Found another issue with the shell script: MNG-6198 (would be good if

Re: Review request

2017-03-28 Thread Michael Osipov
Am 2017-03-27 um 19:58 schrieb Stephen Connolly: My mng-6195 branch is passing all ITs https://builds.apache.org/view/Maven/job/maven-3.x-jenkinsfile/job/mng-6195/ Can somebody test it on FreeBSD (check that .mvn folder is resolved correctly when using -f to specify a path outside the current

Re: What to do with the 6 issues left as 3.5.0-candidates?

2017-03-28 Thread Robert Scholte
I've created a branch for MNG-6185, ready to be merged. Robert On Fri, 24 Mar 2017 11:45:14 +0100, Stephen Connolly wrote:

Re: Review request

2017-03-28 Thread Stephen Connolly
Thanks. My analysis was correct on the Windows mvn.cmd then ;-) On Tue 28 Mar 2017 at 19:09, Robert Scholte wrote: > Just to confirm: on Windows in all three cases the tests are skipped when > following the steps to reproduce MNG-6198 > > Robert > > On Mon, 27 Mar 2017