Re: [VOTE] Release Apache Maven Shade Plugin version 3.5.2

+1 On Sun, 18 Feb 2024 at 04:00, Hervé Boutemy wrote: > > Hi, > > We solved 6 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317921=12352505=Text > > Staging repo: > https://repository.apache.org/content/repositories/maven-2065/ >

Re: [VOTE] Release Apache Maven Shade Plugin version 3.5.2

Hi, +1 form my side. Kind regards Karl Heinz Marbaise On 17.02.24 19:00, Hervé Boutemy wrote: Hi, We solved 6 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317921=12352505=Text Staging repo: https://repository.apache.org/content/repositories/maven-2065/

Re: Using .git-blame-ignore-revs with reordered lines

On 1/24/24 6:31 AM, Konrad Windszus wrote: Ping, does anyone have any input on this? Would be much appreciated, Thanks, Konrad On 8. Jan 2024, at 19:16, Konrad Windszus wrote: Hi, According to https://maven.apache.org/pom/maven/#the-format-profile the git commits created through applying

Re: [VOTE] Release Apache Maven Shade Plugin version 3.5.2

-1 https://github.com/apache/maven-shade-plugin/pull/193 from an external contributor is open and unreviewed, although it seems to meet the criteria for merging if it's correct. It's helpful to triage open PRs and issues before cutting a release. On Sat, Feb 17, 2024 at 1:01 PM Hervé Boutemy

Re: [VOTE] Release Apache Maven Shade Plugin version 3.5.2

+1 * building is ok * test successfully * release note is ok Romain Manni-Bucau 于2024年2月18日周日 16:48写道： > > +1, project ok, downstream projects ok, tested on mvn 3.9.2 & java 11 > > Romain Manni-Bucau > @rmannibucau | Blog > |

Re: [VOTE] Release Apache Maven Shade Plugin version 3.5.2

+1 Reproducible Build ok: reference build done with JDK 11 on *nix see https://github.com/jvm-repo-rebuild/reproducible-apache/blob/master/wip/maven-shade-plugin-3.5.2.buildspec anybody should be able to rebuild locally with ./rebuild.sh wip/maven-shade-plugin-3.5.2.buildspec Regards,

Re: [VOTE] Release Apache Maven Shade Plugin version 3.5.2

+1, project ok, downstream projects ok, tested on mvn 3.9.2 & java 11 Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn

Re: [VOTE] Release Apache Maven Shade Plugin version 3.5.2

+1 Every next release even with a few fixes is step forward. Every time we can review / merge more PR and start the next release. sob., 17 lut 2024 o 19:00 Hervé Boutemy napisał(a): > Hi, > > We solved 6 issues: > >

Re: [VOTE] Release Apache Maven Shade Plugin version 3.5.2

+1 With Herve fully here. BUT I agree somewhat with Eliotte as well: We need to get rid of our habit of neglecting PRs. At least _some_ feedback on PR would be welcome, as leaving PRs hanging without ANY response is the worst way of treating contributors, and we do lack them. T On Sun, Feb 18,

Re: [VOTE] Release Apache Maven Shade Plugin version 3.5.2

FYI I reviewed PRs and merged what I was confident with I can't say if this one can be merged: I don't know the feature sufficiently I understand the good intent of the feedback, even if I find -1 a little bit strong: I did what I could, believe in my good intent too doing that release Regards,

Re: [VOTE] Release Apache Maven Shade Plugin version 3.5.2

+1 And fwiw, I fully support what Hervé said. A release is a best effort from the one who decides to start it and if Hervé was not confident in merging the other PRs, that's fine with me. Guillaume Le dim. 18 févr. 2024 à 17:12, Hervé Boutemy a écrit : > > FYI I reviewed PRs and merged what I

Re: [VOTE] Release Apache Maven Shade Plugin version 3.5.2

Hi Eliotte, Is the -1 only motivated by the fact there is a PR opened? If so please consider two things: * it is always the case for most releases (maven, asf, living projects ;)) so not sure when it became a hard criteria but if so we should probably think to be more open if we want to release

Re: [VOTE] Release Apache Maven Shade Plugin version 3.5.2

+1 sob., 17 lut 2024, 19:01 użytkownik Hervé Boutemy napisał: > Hi, > > We solved 6 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317921=12352505=Text > > Staging repo: > https://repository.apache.org/content/repositories/maven-2065/ > >

Re: [VOTE] Release Apache Maven Shade Plugin version 3.5.2

On Sun, Feb 18, 2024 at 8:43 AM Romain Manni-Bucau wrote: > > Hi Eliotte, > > Is the -1 only motivated by the fact there is a PR opened? That there is an unaddressed PR that looks worthy of review and has been open for months without a reply. 13 others are open. One of them is not ready for

Re: [VOTE] Release Apache Maven Shade Plugin version 3.5.2

+1 for the release as it is +100 with the way Tamás put it. - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org