Github user carlspring commented on a diff in the pull request:
https://github.com/apache/maven-indexer/pull/17#discussion_r130204917
--- Diff: indexer-core/pom.xml ---
@@ -84,21 +84,25 @@ under the License.
org.apache.lucene
lucene-core
Github user carlspring commented on a diff in the pull request:
https://github.com/apache/maven-indexer/pull/17#discussion_r130101051
--- Diff:
indexer-core/src/main/java/org/apache/maven/index/FieldTypeFactory.java ---
@@ -0,0 +1,19 @@
+package org.apache.maven.index
Github user carlspring commented on the issue:
https://github.com/apache/maven-indexer/pull/17
@scela ,
You can file a new issue under
[MINDEXER](https://issues.apache.org/jira/browse/MINDEXER) Jira.
Cheers,
Martin
---
If your project is set up
Github user carlspring commented on the issue:
https://github.com/apache/maven-indexer/pull/17
The changes, (despite my minor remarks), look good! Thanks for this pull! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user carlspring commented on a diff in the pull request:
https://github.com/apache/maven-indexer/pull/17#discussion_r130087375
--- Diff:
indexer-core/src/test/java/org/apache/maven/index/FullIndexNexusIndexerTest.java
---
@@ -1,26 +1,8 @@
package
Github user carlspring commented on a diff in the pull request:
https://github.com/apache/maven-indexer/pull/17#discussion_r130086143
--- Diff:
indexer-core/src/main/java/org/apache/maven/index/FieldTypeFactory.java ---
@@ -0,0 +1,19 @@
+package org.apache.maven.index
Github user carlspring commented on a diff in the pull request:
https://github.com/apache/maven-indexer/pull/17#discussion_r130085893
--- Diff: indexer-core/pom.xml ---
@@ -84,21 +84,25 @@ under the License.
org.apache.lucene
lucene-core
Github user carlspring commented on the issue:
https://github.com/apache/maven-indexer/pull/15
@sesuncedu,
One thing to mention though -- (nothing critical, just cosmetic) -- you
don't seem to be following convention, which is making the checkstyle plugin
complain
Github user carlspring commented on the issue:
https://github.com/apache/maven-indexer/pull/13
Hi,
Shouldn't this be applied to the `master` branch and be included in `6.0`
instead?
@cstamas : What do you think?
Cheers,
Martin
Github user carlspring commented on the issue:
https://github.com/apache/maven-indexer/pull/12
@cstamas : Would you mind reviewing this and maybe merging it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user carlspring commented on the pull request:
https://github.com/apache/maven-indexer/pull/11#issuecomment-69730289
Hi,
This code change looks good to me, thanks!
Kind regards,
Martin
---
If your project is set up for it, you
Github user carlspring commented on the pull request:
https://github.com/apache/maven-indexer/pull/8#issuecomment-54604972
Hi @olamy, @cstamas,
Thanks for accepting the contribution! However, I don't see this reflected
on the Github apache/maven-indexer repository. I believe
GitHub user carlspring opened a pull request:
https://github.com/apache/maven-indexer/pull/8
MINDEXER-91: Add a Spring based example
Restructured the examples and added an illustration of how to do things
with Spring.
You can merge this pull request into a Git repository
Github user carlspring commented on the pull request:
https://github.com/apache/maven-indexer/pull/6#issuecomment-53860583
Closing this pull, as discussed with Tamas. We'll do it a different way.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user carlspring closed the pull request at:
https://github.com/apache/maven-indexer/pull/6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user carlspring opened a pull request:
https://github.com/apache/maven-indexer/pull/7
MINDEXER-89: Use a more uncommon port for Jetty in the
DefaultIndexUpdaterEmbeddingIT to avoid Address already in use
Applied fix suggested by Tamas.
You can merge this pull request
GitHub user carlspring opened a pull request:
https://github.com/apache/maven-indexer/pull/6
MINDEXER-89: Use a more uncommon port for Jetty in the
DefaultIndexUpdaterEmbeddingIT to avoid Address already in use
Applied fix using the build-helper-maven-plugin.
You can merge
Github user carlspring commented on the pull request:
https://github.com/apache/maven-indexer/pull/5#issuecomment-48323441
+1: This looks good to me, especially MINDEXER-41 and being able to search
by extensions.
---
If your project is set up for it, you can reply to this email
Github user carlspring commented on the pull request:
https://github.com/apache/maven-indexer/pull/3#issuecomment-47673144
I've applied the changes you mentioned concerning limiting the execution of
the tests.
---
If your project is set up for it, you can reply to this email
GitHub user carlspring opened a pull request:
https://github.com/apache/maven-indexer/pull/4
Mindexer 80
@Tamas,
I've re-applied the fixes from your branch, as discussed and the tests now
all pass! :-)
Two things to note:
- I haven't applied your fixes
GitHub user carlspring opened a pull request:
https://github.com/apache/maven-indexer/pull/1
MINDEXER-75: Squash indexer-artifact into indexer-core
Hi Tamas,
Please see the attached changes as discussed.
Kind regards,
Martin
You can
21 matches
Mail list logo
