[GitHub] maven-shared pull request #22: Add color support auto detection in MessageUt...

2017-08-16 Thread mryan43
Github user mryan43 closed the pull request at: https://github.com/apache/maven-shared/pull/22 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] maven pull request #114: MNG-6220 add color CLI option

2017-08-16 Thread mryan43
Github user mryan43 closed the pull request at: https://github.com/apache/maven/pull/114 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] maven issue #114: MNG-6220 add color CLI option

2017-08-16 Thread mryan43
Github user mryan43 commented on the issue: https://github.com/apache/maven/pull/114 Great thanks @rfscholte ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] maven issue #114: MNG-6220 add color CLI option

2017-08-09 Thread mryan43
Github user mryan43 commented on the issue: https://github.com/apache/maven/pull/114 I feel stuck until someone with more experience of the maven code base update the version of maven-shared-utils to 3.2.1-SNAPSHOT on the default branch, anyone up to the task ? --- If your project

[GitHub] maven-shared pull request #22: Add color support auto detection in MessageUt...

2017-04-21 Thread mryan43
GitHub user mryan43 opened a pull request: https://github.com/apache/maven-shared/pull/22 Add color support auto detection in MessageUtils Linked to PR https://github.com/apache/maven/pull/114 and task https://issues.apache.org/jira/browse/MNG-6220 You can merge this pull request

[GitHub] maven issue #114: MNG-6220 add color CLI option

2017-04-20 Thread mryan43
Github user mryan43 commented on the issue: https://github.com/apache/maven/pull/114 I applied solution B. I have added an auto-detection method in MessageUtils in my fork of maven-shared-utils (https://github.com/mryan43/maven-shared) based on the corresponding code

[GitHub] maven issue #114: MNG-6220 add color CLI option

2017-04-18 Thread mryan43
Github user mryan43 commented on the issue: https://github.com/apache/maven/pull/114 Unfortunately, the system property is read only once in a static init block in the JansiConsole class before the cli main method is invoked, so my change doesn't work. We have a kind

[GitHub] maven issue #114: MNG-6220 add color CLI option

2017-04-18 Thread mryan43
Github user mryan43 commented on the issue: https://github.com/apache/maven/pull/114 I will test with less and jenkins and comment again with results. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] maven issue #114: MNG-6220 add color CLI option

2017-04-18 Thread mryan43
Github user mryan43 commented on the issue: https://github.com/apache/maven/pull/114 Good idea to align the name of choices with grep, I just changed it. About "isatty", do you think we should set the jansi.force system property when --color is set to "a

[GitHub] maven pull request #114: MNG-6220 add color CLI option

2017-04-18 Thread mryan43
GitHub user mryan43 opened a pull request: https://github.com/apache/maven/pull/114 MNG-6220 add color CLI option https://issues.apache.org/jira/browse/MNG-6220 You can merge this pull request into a Git repository by running: $ git pull https://github.com/mryan43/maven master

[GitHub] maven-archetype pull request #7: ARCHETYPE-487 Add input validation for requ...

2016-08-19 Thread mryan43
Github user mryan43 closed the pull request at: https://github.com/apache/maven-archetype/pull/7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] maven-archetype issue #7: ARCHETYPE-487 Add input validation for required pr...

2016-08-19 Thread mryan43
Github user mryan43 commented on the issue: https://github.com/apache/maven-archetype/pull/7 thx --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] maven-archetype pull request #10: Fix import order in ArchetypeConfiuration

2016-07-17 Thread mryan43
Github user mryan43 closed the pull request at: https://github.com/apache/maven-archetype/pull/10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] maven-archetype issue #10: Fix import order in ArchetypeConfiuration

2016-07-17 Thread mryan43
Github user mryan43 commented on the issue: https://github.com/apache/maven-archetype/pull/10 I just want to make it coherent with other source files in this project so that contributors can configure their IDE to order the imports properly and avoid unrelated changes due

[GitHub] maven-archetype issue #7: ARCHETYPE-487 Add input validation for required pr...

2016-06-03 Thread mryan43
Github user mryan43 commented on the issue: https://github.com/apache/maven-archetype/pull/7 squashed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] maven-archetype pull request: Fix import order in ArchetypeConfiuration

2016-06-01 Thread mryan43
GitHub user mryan43 opened a pull request: https://github.com/apache/maven-archetype/pull/10 Fix import order in ArchetypeConfiuration You can merge this pull request into a Git repository by running: $ git pull https://github.com/mryan43/maven-archetype fix-imports

[GitHub] maven-archetype pull request: ARCHETYPE-487 Add input validation for require...

2016-06-01 Thread mryan43
Github user mryan43 commented on a diff in the pull request: https://github.com/apache/maven-archetype/pull/7#discussion_r65342161 --- Diff: maven-archetype-plugin/src/main/java/org/apache/maven/archetype/ui/ArchetypeConfiguration.java --- @@ -19,12 +19,15 @@ * under

[GitHub] maven-archetype pull request: ARCHETYPE-487 Add input validation for require...

2016-06-01 Thread mryan43
Github user mryan43 commented on the pull request: https://github.com/apache/maven-archetype/pull/7 Hi @stain, I have integrated the feedback from @michael-o, let me know if you need anything else. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] maven-archetype pull request: ARCHETYPE-487 Add input validation for require...

2016-06-01 Thread mryan43
Github user mryan43 commented on a diff in the pull request: https://github.com/apache/maven-archetype/pull/7#discussion_r65317792 --- Diff: maven-archetype-plugin/src/main/java/org/apache/maven/archetype/ui/ArchetypeConfiguration.java --- @@ -19,12 +19,15 @@ * under

[GitHub] maven-archetype pull request: ARCHETYPE-487 Add input validation f...

2015-10-19 Thread mryan43
Github user mryan43 commented on the pull request: https://github.com/apache/maven-archetype/pull/7#issuecomment-149202034 Any news on this one ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] maven-archetype pull request: ARCHETYPE-487 Add input validation f...

2015-09-25 Thread mryan43
Github user mryan43 commented on the pull request: https://github.com/apache/maven-archetype/pull/7#issuecomment-143346538 21 days and nobody replied... is this project dead ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub