[GitHub] maven issue #153: [MNG-6069] Migrate to non deprecated parts of Commons CLI

2018-01-07 Thread rfscholte
Github user rfscholte commented on the issue: https://github.com/apache/maven/pull/153 I don't see that piece of code, but if it works, that's fine. Jason added a comment about exposing them as System properties. I don't think we should remove that right now, but with a major version

[GitHub] maven-plugin-testing issue #4: Added support for plugins without configurati...

2017-10-29 Thread rfscholte
Github user rfscholte commented on the issue: https://github.com/apache/maven-plugin-testing/pull/4 Do you know the reason why somebody implemented the `ConfigurationException` being thrown? --- - To unsubscribe, e

[GitHub] maven issue #87: [MNG-5457] Added the repository id to show which repository...

2017-08-25 Thread rfscholte
Github user rfscholte commented on the issue: https://github.com/apache/maven/pull/87 @rajivpjs can you close this pullrequest? This open PR causes warnings for https://issues.apache.org/jira/browse/MNG-5457 on the release page. --- If your project is set up for it, you can reply

[GitHub] maven issue #114: MNG-6220 add color CLI option

2017-08-09 Thread rfscholte
Github user rfscholte commented on the issue: https://github.com/apache/maven/pull/114 Here's my proposal: https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=fd57754218e749305be1dd745fda9407960cf985 --- If your project is set up for it, you can reply to this email

[GitHub] maven issue #89: [MNG-5995] Removed maven-compat as it not required anymore ...

2016-07-27 Thread rfscholte
Github user rfscholte commented on the issue: https://github.com/apache/maven/pull/89 Based on the recent messages on the mailing thread I assumed you are an active Maven user who wants to use the most recent version of Maven. My guess was right :) --- If your project is set up

[GitHub] maven issue #89: [MNG-5995] Removed maven-compat as it not required anymore ...

2016-07-27 Thread rfscholte
Github user rfscholte commented on the issue: https://github.com/apache/maven/pull/89 Looks to me you're still testing with the installed version of Maven( e.g. 3.3.9), not your own fresh build. Instead try `/Users/rajivpjs/Desktop/Apache/Maven/rajivpjs/maven/mavenfixtarget/bin/mvn

[GitHub] maven-scm issue #31: SCM-706 finer-grained handling of file rename status fo...

2016-06-23 Thread rfscholte
Github user rfscholte commented on the issue: https://github.com/apache/maven-scm/pull/31 > What scares me is that this code appears to be quite sensitive to changes I totally agree. I tested with making changedFiles relative to repo instead of working directory and all unitte

[GitHub] maven-scm issue #31: SCM-706 finer-grained handling of file rename status fo...

2016-06-21 Thread rfscholte
Github user rfscholte commented on the issue: https://github.com/apache/maven-scm/pull/31 https://github.com/apache/maven-scm/blob/master/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/test/java/org/apache/maven/scm/provider/git/gitexe/command/status

[GitHub] maven-scm issue #31: SCM-706 finer-grained handling of file rename status fo...

2016-06-21 Thread rfscholte
Github user rfscholte commented on the issue: https://github.com/apache/maven-scm/pull/31 I think we missed something. `GitStatusConsumer` says /** * Entries are relative to working directory, not to the repositoryroot */ private List changedFiles

[GitHub] maven-scm pull request: SCM-714 fix git commit when command line g...

2015-12-19 Thread rfscholte
Github user rfscholte commented on the pull request: https://github.com/apache/maven-scm/pull/41#issuecomment-165988127 This might be an interesting solution, but I really want the current behavior to be the default. Pattern based files might not select the correct set of files. I

[GitHub] maven pull request: - logging configuration now no longer overwrit...

2014-06-18 Thread rfscholte
Github user rfscholte commented on the pull request: https://github.com/apache/maven/pull/22#issuecomment-46476155 I read about the failing test. I'm looking for the differences. I've tried it with 1.7.0_55 as well, still that test succeeds. So it failure is either caused by the OS

[GitHub] maven pull request: - logging configuration now no longer overwrit...

2014-06-17 Thread rfscholte
Github user rfscholte commented on the pull request: https://github.com/apache/maven/pull/22#issuecomment-46347052 Works fine on my system: Apache Maven 3.2.1 (ea8b2b07643dbb1b84b6d16e1f08391b666bc1e9; 2014-02-14T18:37:52+01:00) Maven home: D:\apache-maven-3.2.1