[GitHub] maven-surefire issue #127: [SUREFIRE-1293] Simplify org.apache.maven.plugin....

2016-10-13 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/127 @britter No big problem. Can you always run build locally? AFAIK your PC is running the build two hours. Normally 45 minutes in Jenkins and my PC Intel i7 4Core 3GHz SSD disk. --- If your

[GitHub] maven-surefire issue #127: [SUREFIRE-1293] Simplify org.apache.maven.plugin....

2016-10-13 Thread britter
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/127 > I fixed this issue where I removed [1] Thank you! > Because of one method in commons-lang3 we should not pass such a big library. ACK > Instead I created

[GitHub] maven-surefire issue #127: [SUREFIRE-1293] Simplify org.apache.maven.plugin....

2016-10-12 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/127 I fixed this issue where I removed [1]. The reason behind is the `IsolatedClassLoader` in plugin process which did not have shaded `commons-lang3` in original jar file of `surefire-common`.

[GitHub] maven-surefire issue #127: [SUREFIRE-1293] Simplify org.apache.maven.plugin....

2016-10-12 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/127 @britter After using one integration tests only `org/apache/**/JUnit47ParallelIT.java` I got same errors as in Jenkins. I think the dependency `commons-lang3` is not

[GitHub] maven-surefire issue #127: [SUREFIRE-1293] Simplify org.apache.maven.plugin....

2016-10-12 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/127 Try to clone Surefire master and just run "mvn test" Caused by: java.lang.NoClassDefFoundError: org/apache/commons/lang3/ObjectUtils at

[GitHub] maven-surefire issue #127: [SUREFIRE-1293] Simplify org.apache.maven.plugin....

2016-10-12 Thread britter
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/127 @Tibor17 I don't understand. `mvn clean compile` works. Why does this fail on Jenkins? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] maven-surefire issue #127: [SUREFIRE-1293] Simplify org.apache.maven.plugin....

2016-10-12 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/127 @britter It seems you forgot to add `ASF commons` dependency. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] maven-surefire issue #127: [SUREFIRE-1293] Simplify org.apache.maven.plugin....

2016-10-12 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/127 @britter The build failed [1]. Did you run a local build on your side? [1] https://builds.apache.org/job/maven-surefire/1638/console --- If your project is set up for it, you can

[GitHub] maven-surefire issue #127: [SUREFIRE-1293] Simplify org.apache.maven.plugin....

2016-10-12 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/127 @britter Done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] maven-surefire issue #127: [SUREFIRE-1293] Simplify org.apache.maven.plugin....

2016-10-12 Thread britter
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/127 @Tibor17 fixed checkstyle issues, moved creation of null objects to DefaultRepoterFactory and squasched everything into one commit. Hope you like it! :-) --- If your project is set up for

[GitHub] maven-surefire issue #127: [SUREFIRE-1293] Simplify org.apache.maven.plugin....

2016-10-11 Thread britter
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/127 Hello @Tibor17, I'll fix the checkstyle violations and squash everything into one single commit! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] maven-surefire issue #127: [SUREFIRE-1293] Simplify org.apache.maven.plugin....

2016-10-11 Thread Tibor17
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/127 After we are done with all commits, would you be able to safely squash them in one single commit? --- If your project is set up for it, you can reply to this email and have your reply