Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/34#issuecomment-68680709
Tibor,
Empirically on the daily basis I work on a 900 module build using 8 threads
with 1500+ developers and there aren't many concurrency issues. I'm not keen on
Github user Tibor17 commented on the pull request:
https://github.com/apache/maven/pull/34#issuecomment-68697988
Hi Jason,
the point of this patch is to force the devs to write `safe` code.
Immediately as I have seen the code I recognized, same as Herve stated in my
email,
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/34#issuecomment-68700367
Apache is resource constrained so we have what we have. Please feel free to
work with Stephen on the dev list to have something better setup. I'm open to
improvement.
Github user Tibor17 closed the pull request at:
https://github.com/apache/maven/pull/34
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/34#issuecomment-68701512
Does the patch apply for you? I just tried:
Applying: Improved visibility of collections and variables across multiple
threads
error: patch failed:
Github user Tibor17 commented on the pull request:
https://github.com/apache/maven/pull/34#issuecomment-68702414
Jason,
Don't worry about this patch, I'll close it - since I have private copy and
the diff.
I will wait for you patch, and then I'll go through the diff and I
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/34#issuecomment-68705017
Sounds like a plan.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
yes, we should probably enhance the documentation: I had a look at it,
and it seems we have:
1. confusion bewteen Guide to Developing Maven [1] and Guide to Building
Maven [2],
2. confusion in these between Maven as Maven core only and any Maven
component, ie core or plugin or ...
I'm
Github user Tibor17 commented on the pull request:
https://github.com/apache/maven/pull/34#issuecomment-68554366
@hboutemy
@jvanzyl
Any objections to push this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
On 2 January 2015 at 22:27, Tibor17 g...@git.apache.org wrote:
Github user Tibor17 commented on the pull request:
https://github.com/apache/maven/pull/34#issuecomment-68568625
The link should be in README.md.
Look at README file @ JUnit and JavaHamcrest projects, where the most
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/34#issuecomment-68555131
As a check did you run the ITs? There are a few collections that are
expected to be mutable unfortunately. I haven't looked at the patch in detail
to check but I can look
Github user Tibor17 commented on the pull request:
https://github.com/apache/maven/pull/34#issuecomment-68561294
@jvanzyl
My ant build says BUILD SUCCESS.
I saw your TODO comments moreless related to immutable objects.
Currently the code is not ready for immutable objects
Github user Tibor17 commented on the pull request:
https://github.com/apache/maven/pull/34#issuecomment-68568625
The link should be in README.md.
Look at README file @ JUnit and JavaHamcrest projects, where the most
important is build status @ CloudBees and Travis
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/34#issuecomment-68562504
Ant build? The ITs are in a separate repository. This may be helpful:
http://takari.io/2014/06/01/contributing-to-maven-core.html
There are are 700+
in context:
http://maven.40175.n5.nabble.com/GitHub-maven-pull-request-Improved-visibility-of-collections-and-variabl-tp5821775p5822205.html
Sent from the Maven Developers mailing list archive at Nabble.com.
-
To unsubscribe, e
of a clear promotions page (I.e. Ribbon banners, etc)
I wanted to have Surefire on CloudBees, but now won't be possible, and I
really don't need top fast machines in Maven projects.
--
View this message in context:
http://maven.40175.n5.nabble.com/GitHub-maven-pull-request-Improved
Github user Tibor17 commented on the pull request:
https://github.com/apache/maven/pull/34#issuecomment-68440499
@jvanzyl
That's clear we must not break current users.
You kow my problem is, as always when i design any API, how much open the
interfaces should be.
Here I
GitHub user Tibor17 opened a pull request:
https://github.com/apache/maven/pull/34
Improved visibility of collections and variables across multiple threads
Upon our discussion with Karl in
Github user Tibor17 commented on the pull request:
https://github.com/apache/maven/pull/34#issuecomment-68410326
I wante to have final field o `MavenProject#dependencyArtifacts`, but in
that case two tests would fail due to
`DefaultProjectDependenciesResolver#process()` iterates over
Github user hboutemy commented on the pull request:
https://github.com/apache/maven/pull/34#issuecomment-68425530
The worst is that open implementation can change the status of objects by
any plugin: yes, the API wasn't meant to be defensive when it was created, we
could simply tell
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/34#issuecomment-68426777
Much of the shitiness stems from leaving things in such a way that nothing
was broken between Maven 2.x and 3.x. There are many weird interactions but the
overriding goal
21 matches
Mail list logo
