Re: [MNG-6130] Loss of profile information in workaround for MNG-4900

2017-07-02 Thread Michael Osipov 

Am 2017-07-02 um 20:13 schrieb Robert Scholte:

So it's back to us, which means we should write the UT/IT if we want to
apply the patch.

As long as there's no proof that this patch is required, I'm -1


Sharing the view. I will reask the reporter.


On Sun, 02 Jul 2017 18:57:07 +0200, Michael Osipov 
wrote:


Am 2017-05-15 um 22:29 schrieb Michael Osipov:

Am 2017-05-15 um 22:10 schrieb Robert Scholte:

I think I miss a unittest or integration-test, just to be sure.


The reporter says: "It's very tricky and hopefully not necessary, since
the 1-line fix is provided"


The issue reporter isn't able to provide an IT and there is only the
patch, but no sample project for this issue.

What to do? Merge this oneline fix anyway?


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org





-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [MNG-6130] Loss of profile information in workaround for MNG-4900

2017-07-02 Thread Robert Scholte 
So it's back to us, which means we should write the UT/IT if we want to  
apply the patch.


As long as there's no proof that this patch is required, I'm -1

Robert

On Sun, 02 Jul 2017 18:57:07 +0200, Michael Osipov   
wrote:



Am 2017-05-15 um 22:29 schrieb Michael Osipov:

Am 2017-05-15 um 22:10 schrieb Robert Scholte:

I think I miss a unittest or integration-test, just to be sure.


The reporter says: "It's very tricky and hopefully not necessary, since
the 1-line fix is provided"


The issue reporter isn't able to provide an IT and there is only the  
patch, but no sample project for this issue.


What to do? Merge this oneline fix anyway?


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [MNG-6130] Loss of profile information in workaround for MNG-4900

2017-07-02 Thread Michael Osipov 

Am 2017-05-15 um 22:29 schrieb Michael Osipov:

Am 2017-05-15 um 22:10 schrieb Robert Scholte:

I think I miss a unittest or integration-test, just to be sure.


The reporter says: "It's very tricky and hopefully not necessary, since
the 1-line fix is provided"


The issue reporter isn't able to provide an IT and there is only the 
patch, but no sample project for this issue.


What to do? Merge this oneline fix anyway?


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [MNG-6130] Loss of profile information in workaround for MNG-4900

2017-05-15 Thread Michael Osipov 

Am 2017-05-15 um 22:10 schrieb Robert Scholte:

I think I miss a unittest or integration-test, just to be sure.


The reporter says: "It's very tricky and hopefully not necessary, since 
the 1-line fix is provided"


But you are right. This needs some verification.


On Mon, 15 May 2017 21:55:38 +0200, Michael Osipov 
wrote:


Who seconds 6130 for 3.5.1?

This is a one-line fix and all ITs pass.

Michael

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org





-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [MNG-6130] Loss of profile information in workaround for MNG-4900

2017-05-15 Thread Robert Scholte 

I think I miss a unittest or integration-test, just to be sure.

On Mon, 15 May 2017 21:55:38 +0200, Michael Osipov   
wrote:



Who seconds 6130 for 3.5.1?

This is a one-line fix and all ITs pass.

Michael

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[MNG-6130] Loss of profile information in workaround for MNG-4900

2017-05-15 Thread Michael Osipov 

Who seconds 6130 for 3.5.1?

This is a one-line fix and all ITs pass.

Michael

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org