Re: .isSnapshot changes version

2007-06-26 Thread Hervé BOUTEMY
Le vendredi 22 juin 2007, Hervé BOUTEMY a écrit : Le vendredi 22 juin 2007, Kenney Westerhof a écrit : * There are multiple methods for version modification/retrieval: * resolved version (setter only - sets version) * version (sets version, baseversion, and versionrange; gets version)

Re: .isSnapshot changes version

2007-06-22 Thread Kenney Westerhof
Hervé BOUTEMY wrote: Le mercredi 20 juin 2007, Kenney Westerhof a écrit : Also see https://svn.apache.org/repos/asf/maven/surefire/trunk/maven-surefire-plugin /src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java line 494. I tried to fix this a while back but it's a big mess

Re: .isSnapshot changes version

2007-06-22 Thread Mark Hobson
On 22/06/07, Kenney Westerhof [EMAIL PROTECTED] wrote: Well, just looked at the code and it's a mess. Here are the problems: * The isSnapshot method does a regexp on the version for the timestamp, and if it matches, replaces the baseversion with -SNAPSHOT. If it doesn't match, checks for

Re: .isSnapshot changes version

2007-06-22 Thread Hervé BOUTEMY
Le vendredi 22 juin 2007, Kenney Westerhof a écrit : * There are multiple methods for version modification/retrieval: * resolved version (setter only - sets version) * version (sets version, baseversion, and versionrange; gets version) * base version (sets base version, gets baseversion

Re: .isSnapshot changes version

2007-06-20 Thread Hervé BOUTEMY
Le mercredi 20 juin 2007, Brian E. Fox a écrit : I discovered http://jira.codehaus.org/browse/MNG-2961 while working on mdep a while back. same for me while working on http://jira.codehaus.org/browse/MANTTASKS-18 It should be an easy fix but I'm pondering what the least intrusive fix is.

Re: .isSnapshot changes version

2007-06-20 Thread Kenney Westerhof
Also see https://svn.apache.org/repos/asf/maven/surefire/trunk/maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java line 494. I tried to fix this a while back but it's a big mess and has a lot of unwanted side effects. Accessors shouldn't change a property,

Re: .isSnapshot changes version

2007-06-20 Thread Hervé BOUTEMY
Le mercredi 20 juin 2007, Kenney Westerhof a écrit : Also see https://svn.apache.org/repos/asf/maven/surefire/trunk/maven-surefire-plugin /src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java line 494. I tried to fix this a while back but it's a big mess and has a lot of

.isSnapshot changes version

2007-06-19 Thread Brian E. Fox
I discovered http://jira.codehaus.org/browse/MNG-2961 while working on mdep a while back. It should be an easy fix but I'm pondering what the least intrusive fix is. Clearly calling a Boolean method shouldn't result in a change to some other variable so we should do something. Changing it to