Re: Review Request 15190: Create Latch in Future Lazily.

2013-11-04 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15190/#review28114 --- Ship it! Ship It! - Benjamin Hindman On Nov. 2, 2013, 12:01

[jira] [Created] (MESOS-795) ZooKeeperTest.MasterDetectorTimedoutSession test is flaky

2013-11-04 Thread Vinod Kone (JIRA)
Vinod Kone created MESOS-795: Summary: ZooKeeperTest.MasterDetectorTimedoutSession test is flaky Key: MESOS-795 URL: https://issues.apache.org/jira/browse/MESOS-795 Project: Mesos Issue Type:

Re: Review Request 15200: refactor mesos-ps to display used/allocated cpu and memory

2013-11-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15200/#review28124 --- Hey Shingo, this is really cool! However, usage.json is deprecated

Re: Review Request 15193: Use $CC compiler instead of 'gcc' for version dump.

2013-11-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15193/#review28125 --- Ship it! Can you easily guard that whole check to occur only for

Re: Review Request 15193: Use $CC compiler instead of 'gcc' for version dump.

2013-11-04 Thread Niklas Nielsen
On Nov. 4, 2013, 6:23 p.m., Ben Mahler wrote: Can you easily guard that whole check to occur only for gcc? (When using clang we don't want the same version check). Good point. Clang will claim to be a GCC 4.2.1 with dumpversion. We could have something as simple as: gcc --version|grep

[jira] [Commented] (MESOS-498) ZooKeeperTest.MasterDetectorTimedoutSession is flaky

2013-11-04 Thread Yan Xu (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13813191#comment-13813191 ] Yan Xu commented on MESOS-498: -- I have revised the test along with the contender change, the

[jira] [Commented] (MESOS-789) Make link to times in the webui clickable

2013-11-04 Thread Ross Allen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13813203#comment-13813203 ] Ross Allen commented on MESOS-789: -- Gotcha, so a faster way to reveal the full timestamp,

[jira] [Commented] (MESOS-793) AllocatorZooKeeperTest/0.FrameworkReregistersFirst hangs.

2013-11-04 Thread Bernardo Gomez Palacio (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13813211#comment-13813211 ] Bernardo Gomez Palacio commented on MESOS-793: -- Adding cyrus-sasl-md5 as part

[jira] [Closed] (MESOS-793) AllocatorZooKeeperTest/0.FrameworkReregistersFirst hangs.

2013-11-04 Thread Bernardo Gomez Palacio (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bernardo Gomez Palacio closed MESOS-793. Resolution: Fixed I changed my spec file to include cyrus-sasl-md5 and

Re: Review Request 14847: Added --hostname flag to slave and removed webui_hostname.

2013-11-04 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14847/#review28134 --- include/mesos/mesos.proto

Re: Review Request 14669: launchTasks on list of offers

2013-11-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14669/#review28129 --- Cool! Sorry for taking so long to look at this! We should dogfood

Reverting https://reviews.apache.org/r/14847/

2013-11-04 Thread Vinod Kone
Hey folks, I think there are some backwards compatibility issues with https://reviews.apache.org/r/14847/. I've added my comment on the review for those that are interested. I would like to revert this commit for now until we have a proper fix. Niklas: Are there any other commits that depend on

Re: Review Request 14631: Catch-up Replicated Log 1: decoupled coordinator logics and made them asynchronous.

2013-11-04 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14631/#review27506 --- It would be great to include some documentation that lists all

Re: Review Request 14847: Added --hostname flag to slave and removed webui_hostname.

2013-11-04 Thread Benjamin Hindman
On Nov. 4, 2013, 8:24 p.m., Vinod Kone wrote: include/mesos/mesos.proto, lines 179-180 https://reviews.apache.org/r/14847/diff/2/?file=370571#file370571line179 Sorry didn't review this earlier but there are couple of issues with this. SlaveInfo is checkpointed, so

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #1749

2013-11-04 Thread Apache Jenkins Server
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/1749/ -- [...truncated 130 lines...] Started by an SCM change Started by an SCM change Started by an SCM change Started by an SCM change Started by an SCM change Started by

Review Request 15214: Re-deprecated 'webui_hostname' as optional (from required).

2013-11-04 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15214/ --- Review request for mesos and Vinod Kone. Repository: mesos-git Description

Re: Review Request 15214: Re-deprecated 'webui_hostname' as optional (from required).

2013-11-04 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15214/#review28143 --- Ship it! src/slave/slave.cpp

[jira] [Created] (MESOS-796) org.apache.mesos.Log isn't mockable

2013-11-04 Thread Suman Karumuri (JIRA)
Suman Karumuri created MESOS-796: Summary: org.apache.mesos.Log isn't mockable Key: MESOS-796 URL: https://issues.apache.org/jira/browse/MESOS-796 Project: Mesos Issue Type: Bug

Review Request 15215: Support displaying some charts in mesos webui

2013-11-04 Thread Shingo Omura
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15215/ --- Review request for mesos, Benjamin Hindman, Ben Mahler, Ross Allen, and Vinod

[jira] [Commented] (MESOS-797) Support displaying some charts in mesos webui

2013-11-04 Thread Shingo Omura (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13813399#comment-13813399 ] Shingo Omura commented on MESOS-797: I implemented bar charts with d3. I opened

Re: Reverting https://reviews.apache.org/r/14847/

2013-11-04 Thread Vinod Kone
To close the loop, we decided to fix the issue rather than revert. Thanks BenH for the quick fix! https://reviews.apache.org/r/15214/ On Mon, Nov 4, 2013 at 1:04 PM, Benjamin Hindman b...@eecs.berkeley.eduwrote: Hey Vinod, Unless I'm missing something, I don't see any incompatibilities

Re: Review Request 14457: Added default constructor and ==, != operators for Result. (Stout)

2013-11-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14457/#review28150 --- Ship it!

Re: Review Request 15016: Added local timeout to Group.

2013-11-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15016/#review28151 --- Any chance you can split apart the move of GroupProcess and the

Re: Review Request 14631: Catch-up Replicated Log 1: decoupled coordinator logics and made them asynchronous.

2013-11-04 Thread Jie Yu
On Nov. 4, 2013, 8:45 p.m., Benjamin Hindman wrote: It would be great to include some documentation that lists all possible proposers for the replicas. Done. Added a paragraph in src/log/consensus.hpp. - Jie --- This is an

Re: Review Request 14631: Catch-up Replicated Log 1: decoupled coordinator logics and made them asynchronous.

2013-11-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14631/ --- (Updated Nov. 5, 2013, 12:02 a.m.) Review request for mesos and Benjamin

Re: Review Request 14631: Catch-up Replicated Log 1: decoupled coordinator logics and made them asynchronous.

2013-11-04 Thread Jie Yu
Ben, FYI, your last review is not for the latest version. I addressed all your comments accordingly in the newest version. - Jie On Mon, Nov 4, 2013 at 12:45 PM, Benjamin Hindman b...@berkeley.edu wrote: This is an automatically generated e-mail. To reply, visit:

Re: Review Request 14457: Added default constructor and ==, != operators for Result. (Stout)

2013-11-04 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14457/ --- (Updated Nov. 5, 2013, 12:18 a.m.) Review request for mesos, Benjamin Hindman,

Review Request 15221: Moved GroupProcess into group.hpp and made it a public member of Group for testing.

2013-11-04 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15221/ --- Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.

Re: Review Request 14951: mesos-cat and mesos-tail

2013-11-04 Thread Ben Mahler
On Oct. 26, 2013, 9:01 p.m., Jason Dusek wrote: Hey Shingo, can you mark these open issues as resolved or dropped? - Ben --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14951/#review27576

Re: Review Request 15016: Added local timeout so that Group operations fail after we locally determine that the session is timed out.

2013-11-04 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15016/ --- (Updated Nov. 5, 2013, 12:39 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 15221: Moved GroupProcess into group.hpp and made it a public member of Group for testing.

2013-11-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15221/#review28159 --- Ship it! src/zookeeper/group.hpp

Re: Review Request 14951: mesos-cat and mesos-tail

2013-11-04 Thread OMURA, Shingo
sorry, Ben. I marked all issues as fixed. Thanks. -- Shingo Omura everpe...@gmail.com http://everpeace.github.io/ 2013/11/4 Ben Mahler benjamin.mah...@gmail.com This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14951/ Hey Shingo, can you mark

Re: Review Request 14457: Added default constructor and ==, != operators for Result. (Stout)

2013-11-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14457/#review28160 --- 3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp

Re: Review Request 14902: Catch-up Replicated Log 2: libprocessify the coordinator.

2013-11-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14902/ --- (Updated Nov. 5, 2013, 12:50 a.m.) Review request for mesos and Benjamin

Re: Review Request 14946: Catch-up Replicated Log 3: added recover process.

2013-11-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14946/ --- (Updated Nov. 5, 2013, 12:52 a.m.) Review request for mesos and Benjamin

Re: Review Request 15016: Added local timeout so that Group operations fail after we locally determine that the session is timed out.

2013-11-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15016/#review28161 --- src/zookeeper/group.cpp

Re: Review Request 13086: Added Zookeeper leader contender and detector abstractions.

2013-11-04 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13086/ --- (Updated Nov. 5, 2013, 1:09 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 13087: Added Master contender and detector abstractions.

2013-11-04 Thread Jiang Yan Xu
On Nov. 1, 2013, 6:51 p.m., Vinod Kone wrote: src/tests/master_contender_detector_tests.cpp, line 422 https://reviews.apache.org/r/13087/diff/10/?file=374220#file374220line422 Inducing lost connections this way is a bit weird because the connections are actually alive on the

Re: Review Request 13087: Added Master contender and detector abstractions.

2013-11-04 Thread Jiang Yan Xu
On Oct. 31, 2013, 7:25 p.m., Vinod Kone wrote: src/tests/authentication_tests.cpp, lines 382-383 https://reviews.apache.org/r/13087/diff/10/?file=374215#file374215line382 Consider a constructor that just takes a scheduler and master and uses DEFAULT_FRAMEWORK_INFO,

Re: Review Request 13087: Added Master contender and detector abstractions.

2013-11-04 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13087/ --- (Updated Nov. 5, 2013, 1:20 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 13087: Added Master contender and detector abstractions.

2013-11-04 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13087/ --- (Updated Nov. 5, 2013, 1:22 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 13087: Added Master contender and detector abstractions.

2013-11-04 Thread Jiang Yan Xu
On Nov. 1, 2013, 6:51 p.m., Vinod Kone wrote: src/tests/master_contender_detector_tests.cpp, lines 289-290 https://reviews.apache.org/r/13087/diff/10/?file=374220#file374220line289 Why are these 2 timeouts different? Jiang Yan Xu wrote: They are not now but could be.

Re: Review Request 14383: Added the registrar.

2013-11-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14383/#review28166 --- src/master/registrar.cpp

Re: Review Request 15099: Cleaned up the Registrar.

2013-11-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15099/ --- (Updated Nov. 5, 2013, 2:34 a.m.) Review request for mesos, Benjamin Hindman

Review Request 15226: Added a performance test for the Registrar.

2013-11-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15226/ --- Review request for mesos, Benjamin Hindman and Vinod Kone. Repository:

Review Request 15227: Improved performance of the Registrar.

2013-11-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15227/ --- Review request for mesos, Benjamin Hindman and Vinod Kone. Repository:

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #1750

2013-11-04 Thread Apache Jenkins Server
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/1750/ -- [...truncated 205 lines...] Started by an SCM change Started by an SCM change Started by an SCM change Started by an SCM change Started by an SCM change Started by

[jira] [Created] (MESOS-798) ExamplesTest.PythonFramework failing

2013-11-04 Thread Bernardo Gomez Palacio (JIRA)
Bernardo Gomez Palacio created MESOS-798: Summary: ExamplesTest.PythonFramework failing Key: MESOS-798 URL: https://issues.apache.org/jira/browse/MESOS-798 Project: Mesos Issue

[jira] [Created] (MESOS-799) Mesos python egg is faulty on OS X Mavericks

2013-11-04 Thread Niklas Quarfot Nielsen (JIRA)
Niklas Quarfot Nielsen created MESOS-799: Summary: Mesos python egg is faulty on OS X Mavericks Key: MESOS-799 URL: https://issues.apache.org/jira/browse/MESOS-799 Project: Mesos