Re: Review Request 22313: MESOS-886: Prevented slave from launching tasks before containerize's update completes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22313/ --- (Updated Aug. 12, 2014, 6:10 a.m.) Review request for mesos, Ian Downes and

Review Request 24593: Updated Docker::run to look for entrypoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24593/ --- Review request for mesos and Timothy Chen. Repository: mesos-git Description

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2309

See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2309/changes

Re: Review Request 24464: Redirect docker logs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24464/ --- (Updated Aug. 12, 2014, 7:44 a.m.) Review request for mesos, Benjamin Hindman

Build failed in Jenkins: mesos-reviewbot #1316

See https://builds.apache.org/job/mesos-reviewbot/1316/changes Changes: [benjamin.hindman] Added missing 'defer' helpers. -- [...truncated 5571 lines...] rm -f state/.dirstamp rm -f log/tool/*.lo rm -f tests/.deps/.dirstamp rm -f logging/*.o rm -f

Jenkins build is back to normal : Mesos-Ubuntu-distcheck #264

See https://builds.apache.org/job/Mesos-Ubuntu-distcheck/264/changes

Re: Review Request 24475: Add new Docker configurations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24475/ --- (Updated Aug. 12, 2014, 8:45 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 22313: MESOS-886: Prevented slave from launching tasks before containerize's update completes.

On Aug. 11, 2014, 10:56 p.m., Vinod Kone wrote: src/tests/slave_tests.cpp, line 1097 https://reviews.apache.org/r/22313/diff/24/?file=653349#file653349line1097 I think you can get rid of 'runTask' future and just work with 'updateCall' future. Any reason to need both? Thanks!

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2330

See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2330/changes Changes: [benjamin.hindman] Added missing 'defer' helpers. -- [...truncated 4015 lines...] [ RUN ] IntervalTest.Subtraction [ OK ]

Re: Review Request 24349: Add ContainerInfo and Volumes proto defs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24349/#review50308 --- Patch looks great! Reviews applied: [24349] All tests passed. -

Jenkins build is back to normal : mesos-reviewbot #1317

See https://builds.apache.org/job/mesos-reviewbot/1317/

Re: Review Request 24264: Installed python libraries during make install.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24264/#review50315 --- Bad patch! Reviews applied: [24264] Failed command: git apply

Build failed in Jenkins: mesos-reviewbot #1319

See https://builds.apache.org/job/mesos-reviewbot/1319/ -- [...truncated 5570 lines...] rm -f state/.dirstamp rm -f tests/.deps/.dirstamp rm -f tests/.dirstamp rm -f usage/.deps/.dirstamp rm -f log/tool/*.lo rm -f usage/.dirstamp rm -f logging/*.o rm -f

Re: Review Request 24464: Redirect docker logs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24464/#review50333 --- Ship it! Looks good! Thanks for the cleanup!

Re: Review Request 24588: Added Docker::pull.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24588/#review50341 --- Probably worth adding some tests. src/docker/docker.cpp

Re: Review Request 24194: Fixed bug in io::poll.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24194/#review50346 --- Ben, can you commit this patch? Thanks! - Jie Yu On Aug. 1,

Re: Review Request 24475: Add new Docker configurations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24475/#review50347 --- flying by review:) src/docker/docker.hpp

Re: Review Request 22313: MESOS-886: Prevented slave from launching tasks before containerize's update completes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22313/ --- (Updated Aug. 12, 2014, 7:28 p.m.) Review request for mesos, Ian Downes and

Re: Review Request 22313: MESOS-886: Prevented slave from launching tasks before containerize's update completes.

On Aug. 11, 2014, 10:56 p.m., Vinod Kone wrote: src/slave/slave.cpp, line 1338 https://reviews.apache.org/r/22313/diff/24/?file=653348#file653348line1338 I think you also want to return immediately if executor is in TERMINATING/TERMINATED state. Yifan Gu wrote: Thanks!

Re: Review Request 24194: Fixed bug in io::poll.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24194/#review50363 --- Ship it! Also curious about calling ev_async_send after the

Re: Review Request 22066: Added timeout to rescind unused offers

Hey Kapil, it looks like Tim had been following up with a separate review for this: https://reviews.apache.org/r/22796/ On Mon, Aug 11, 2014 at 8:09 PM, Mesos ReviewBot dev@mesos.apache.org wrote: --- This is an automatically generated

Re: Review Request 24576: Some Master cleanups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24576/#review50366 --- Ship it! src/master/master.cpp

Re: Review Request 24563: MESOS-1693: enable build against non-x86 arch

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24563/#review50368 --- Patch looks great! Reviews applied: [24563] All tests passed. -

Jenkins build is back to normal : mesos-reviewbot #1321

See https://builds.apache.org/job/mesos-reviewbot/1321/

Re: Review Request 24515: Model pending tasks in the Master's metrics and JSON.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24515/#review50367 --- Ship it! src/common/http.cpp

Re: Review Request 22066: Added timeout to rescind unused offers

Hi Ben, Kapil is continuing where I left off and finish the patch (that he originally started himself). So the one he posted should have all my changes plus addressing your comments. Tim Sent from my iPhone On Aug 12, 2014, at 2:18 PM, Benjamin Mahler benjamin.mah...@gmail.com wrote:

Re: Review Request 24516: Expose pending tasks during reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24516/#review50371 --- Ship it! src/master/master.cpp

4.8.0 Cxx11 compilation issue

Hello Guys: I am trying to build mesos on Centos6.5 and 4.8.0 g++ and am hitting the following issue, help is appreciated. Thanks! ake[6]: Entering directory `/home/chinmaya/work/mesos.old/build/3rdparty/libprocess/3rdparty/stout' make[6]: Nothing to be done for `all'. make[6]: Leaving

Re: Review Request 22066: Added timeout to rescind unused offers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22066/ --- (Updated Aug. 12, 2014, 6:14 p.m.) Review request for mesos, Adam B, Ben

Re: Review Request 24464: Redirect docker logs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24464/ --- (Updated Aug. 12, 2014, 10:28 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 22066: Added timeout to rescind unused offers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22066/#review50377 --- Thanks Kapil, looks great, just some minor cleanups for the tests.

Re: 4.8.0 Cxx11 compilation issue

Just curious, do you see this with gcc 4.8.1 / 4.8.2 or only with 4.8.0? On Tue, Aug 12, 2014 at 3:07 PM, Chinmaya Manjunath chinm...@hedviginc.com wrote: Hello Guys: I am trying to build mesos on Centos6.5 and 4.8.0 g++ and am hitting the following issue, help is appreciated. Thanks!

Re: Review Request 22313: MESOS-886: Prevented slave from launching tasks before containerize's update completes.

On Aug. 11, 2014, 10:56 p.m., Vinod Kone wrote: src/slave/slave.cpp, line 1338 https://reviews.apache.org/r/22313/diff/24/?file=653348#file653348line1338 I think you also want to return immediately if executor is in TERMINATING/TERMINATED state. Yifan Gu wrote: Thanks!

Re: Review Request 22313: MESOS-886: Prevented slave from launching tasks before containerize's update completes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22313/ --- (Updated Aug. 12, 2014, 11:07 p.m.) Review request for mesos, Ian Downes and

Review Request 24619: Made value in CommandInfo optional and added argv.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24619/ --- Review request for mesos and Benjamin Hindman. Repository: mesos-git

Re: Review Request 24619: Made value in CommandInfo optional and added argv.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24619/#review50386 --- Ship it! Ship It! - Timothy Chen On Aug. 12, 2014, 11:21 p.m.,

Re: 4.8.0 Cxx11 compilation issue

I just tried it with 4.8.0 and got this. Would think that it could happen with 4.8.1 as well. This error disappears if I configure without cxx11 support, but I see that it is a deprecated setting. Benjamin Mahler mailto:benjamin.mah...@gmail.com August 12, 2014 4:05 PM Just curious, do

Re: 4.8.0 Cxx11 compilation issue

Can you try it with 4.8.2? I ask because most of the developers and many of the CI jobs compile with 4.8.1 or 4.8.2, so it would be nice to rule out an issue with 4.8.0. On Tue, Aug 12, 2014 at 4:35 PM, Chinmaya Manjunath chinm...@hedviginc.com wrote: I just tried it with 4.8.0 and got this.

Re: Review Request 24562: ZK URL Parsing Consolidation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24562/#review50390 --- Patch looks great! Reviews applied: [24562] All tests passed. -

Review Request 24628: MESOS-1171: unbundle gmock

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24628/ --- Review request for mesos, Jie Yu and Vinod Kone. Bugs: MESOS-1171

Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23086/#review50395 --- Patch looks great! Reviews applied: [23086] All tests passed. -

Re: Review Request 24576: Some Master cleanups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24576/#review50396 --- Ship it! Modulo Vinod's comments. Looks good otherwise!

Re: Review Request 24475: Add new Docker configurations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24475/ --- (Updated Aug. 13, 2014, 2:59 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 24555: MESOS-1169: unbundle distribute

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24555/#review50399 --- Patch looks great! Reviews applied: [24555] All tests passed. -

Re: Review Request 24475: Add new Docker configurations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24475/#review50404 --- Ship it! src/slave/containerizer/docker.cpp

Review Request 24631: Refactored the protobuf message comparison logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24631/ --- Review request for mesos and Benjamin Hindman. Repository: mesos-git

Review Request 24632: Updated health check to use the new CommandInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24632/ --- Review request for mesos and Benjamin Hindman. Summary (updated)

Re: Review Request 24632: Updated health check to use the new CommandInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24632/#review50405 --- src/health-check/main.cpp

Review Request 24633: Updated mesos containerizer launcher to use the new CommandInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24633/ --- Review request for mesos and Benjamin Hindman. Repository: mesos-git

Review Request 24634: Updated slave http to use the new CommmandInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24634/ --- Review request for mesos and Benjamin Hindman. Repository: mesos-git

Review Request 24635: Updated command executor to use the new CommandInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24635/ --- Review request for mesos and Benjamin Hindman. Repository: mesos-git

Re: Review Request 24632: Updated health check to use the new CommandInfo.

On Aug. 13, 2014, 5:23 a.m., Timothy Chen wrote: src/health-check/main.cpp, line 171 https://reviews.apache.org/r/24632/diff/1/?file=659122#file659122line171 Thanks for the update! Do you mind adding a test for the shell path? I think the shell path should have already been tested

Re: Review Request 24631: Refactored the protobuf message comparison logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24631/#review50407 --- Ship it! Not exactly the most efficient way of doing this, but

Re: Review Request 24593: Updated Docker::run to look for entrypoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24593/#review50408 --- Patch looks great! Reviews applied: [24588, 24593] All tests

Re: Review Request 24632: Updated health check to use the new CommandInfo.

On Aug. 13, 2014, 5:23 a.m., Timothy Chen wrote: src/health-check/main.cpp, line 171 https://reviews.apache.org/r/24632/diff/1/?file=659122#file659122line171 Thanks for the update! Do you mind adding a test for the shell path? Jie Yu wrote: I think the shell path should have

Re: Review Request 24632: Updated health check to use the new CommandInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24632/#review50410 --- Ship it! Ship It! - Benjamin Hindman On Aug. 13, 2014, 5:21

Re: Review Request 24633: Updated mesos containerizer launcher to use the new CommandInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24633/#review50411 --- Ship it! Ship It! - Benjamin Hindman On Aug. 13, 2014, 5:25

Re: Review Request 24634: Updated slave http to use the new CommmandInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24634/#review50412 --- Ship it! Ship It! - Benjamin Hindman On Aug. 13, 2014, 5:25

Re: Review Request 24635: Updated command executor to use the new CommandInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24635/#review50413 --- Ship it! src/launcher/executor.cpp

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2331

See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2331/changes Changes: [benjamin.hindman] Add ContainerInfo and Volumes protobufs. -- [...truncated 1596 lines...] /bin/bash ./libtool --tag=CXX --mode=link g++ -Wall

Re: Review Request 24475: Add new Docker configurations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24475/ --- (Updated Aug. 13, 2014, 5:47 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 24516: Expose pending tasks during reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24516/#review50416 --- Bad patch! Reviews applied: [24582, 24583, 24576, 24515, 24516]