Re: Review Request 24673: Used new CommandInfo with Docker::run.

2014-08-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24673/#review50558 --- Bad patch! Reviews applied: [24673] Failed command: git apply

Re: Review Request 22313: MESOS-886: Prevented slave from launching tasks before containerize's update completes.

2014-08-14 Thread Yifan Gu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22313/ --- (Updated Aug. 14, 2014, 6:54 a.m.) Review request for mesos, Ian Downes and

Re: Review Request 22313: MESOS-886: Prevented slave from launching tasks before containerize's update completes.

2014-08-14 Thread Yifan Gu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22313/ --- (Updated Aug. 14, 2014, 6:56 a.m.) Review request for mesos, Ian Downes and

Re: Review Request 22313: MESOS-886: Prevented slave from launching tasks before containerize's update completes.

2014-08-14 Thread Yifan Gu
On Aug. 11, 2014, 10:56 p.m., Vinod Kone wrote: src/slave/slave.cpp, line 1338 https://reviews.apache.org/r/22313/diff/24/?file=653348#file653348line1338 I think you also want to return immediately if executor is in TERMINATING/TERMINATED state. Yifan Gu wrote: Thanks!

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2314

2014-08-14 Thread Apache Jenkins Server
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2314/changes

Re: Review Request 24677: Add Docker::pull

2014-08-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24677/#review50568 --- Bad patch! Reviews applied: [24677] Failed command: git apply

Re: Review Request 24687: Added support for disabling glog initialization.

2014-08-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24687/#review50578 --- Patch looks great! Reviews applied: [24687] All tests passed. -

Re: Review Request 24628: MESOS-1171: unbundle gmock

2014-08-14 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24628/ --- (Updated Aug. 14, 2014, 1:48 p.m.) Review request for mesos, Jie Yu and Vinod

Re: Review Request 24555: MESOS-1169: unbundle distribute

2014-08-14 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24555/ --- (Updated Aug. 14, 2014, 2:45 p.m.) Review request for mesos, Adam B, Jie Yu,

Review Request 24700: Log the user id when receiving a SIGTERM.

2014-08-14 Thread Alexandra Sava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24700/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-1567

Re: Review Request 24563: MESOS-1693: enable build against non-x86 arch

2014-08-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24563/#review50590 --- 3rdparty/libprocess/include/process/internal.hpp

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2316

2014-08-14 Thread Vinod Kone
On Thu, Aug 14, 2014 at 9:40 AM, Apache Jenkins Server jenk...@builds.apache.org wrote: configure: error: conditional WITH_BUNDLED_DISTRIBUTE was never defined. Usually this means the macro was only invoked conditionally. @tim: can you take a look?

Re: Review Request 24673: Used new CommandInfo with Docker::run.

2014-08-14 Thread Benjamin Hindman
On Aug. 13, 2014, 10:20 p.m., Jie Yu wrote: src/docker/docker.cpp, line 266 https://reviews.apache.org/r/24673/diff/1/?file=659614#file659614line266 I would probably rename it to argv as subprocess's signature uses argv. Great idea! Thanks Jie! - Benjamin

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2316

2014-08-14 Thread Tim St Clair
looking. - Original Message - From: Vinod Kone vinodk...@gmail.com To: dev dev@mesos.apache.org Cc: Timothy St. Clair tstcl...@redhat.com Sent: Thursday, August 14, 2014 11:50:27 AM Subject: Re: Build failed in Jenkins:

Re: RB 2.0.5

2014-08-14 Thread Benjamin Mahler
Thanks Jake! On Wed, Aug 13, 2014 at 9:07 PM, Vinod Kone vinodk...@gmail.com wrote: Thanks to Jake Farrell, we now have an upgraded RB server (1.6.x to 2.0.x)! Apart from the UI flourishes, the thing I'm excited about is that this should fix our long standing problem of review updates

Re: Review Request 24673: Used new CommandInfo with Docker::run.

2014-08-14 Thread Benjamin Hindman
On Aug. 13, 2014, 10:22 p.m., Timothy Chen wrote: Ship It! Timothy Chen wrote: Ben you will need to update this rb with the new commandInfo argv - arguments renamed. Yup, done, thanks. - Benjamin --- This is an

Build failed in Jenkins: mesos-reviewbot #1342

2014-08-14 Thread Apache Jenkins Server
See https://builds.apache.org/job/mesos-reviewbot/1342/ -- [...truncated 4514 lines...] /usr/bin/install -c -m 644 ../../../../../../3rdparty/libprocess/3rdparty/stout/include/stout/os/execenv.hpp

Re: Review Request 24700: Log the user id when receiving a SIGTERM.

2014-08-14 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24700/#review50600 --- Did you test this manually? src/logging/logging.cpp

Re: Review Request 24700: Log the user id when receiving a SIGTERM.

2014-08-14 Thread Alexandra Sava
On Aug. 14, 2014, 5:26 p.m., Ben Mahler wrote: Did you test this manually? Yes I did. I ran the master and sent it SIGTERM with kill. It worked perfectly fine, I don't know why ReviewBot doesn't like it. On Aug. 14, 2014, 5:26 p.m., Ben Mahler wrote: src/logging/logging.cpp, line 75

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2316

2014-08-14 Thread Tim St Clair
it was from '--disable-python', should be fixed. ../configure --disable-java --disable-python --disable-webui Cheers, Tim - Original Message - From: Tim St Clair tstcl...@redhat.com To: dev@mesos.apache.org Sent: Thursday, August 14, 2014 12:04:25 PM Subject: Re: Build failed in

Re: Review Request 24700: Log the user id when receiving a SIGTERM.

2014-08-14 Thread Nikita Vetoshkin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24700/#review50607 --- I don't think that si_uid can give something interesting because it

Re: Review Request 24563: MESOS-1693: enable build against non-x86 arch

2014-08-14 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24563/ --- (Updated Aug. 14, 2014, 6:16 p.m.) Review request for mesos, Adam B, Benjamin

Build failed in Jenkins: mesos-reviewbot #1343

2014-08-14 Thread Apache Jenkins Server
See https://builds.apache.org/job/mesos-reviewbot/1343/changes Changes: [benjamin.hindman] Added explicit DockerInfo within ContainerInfo. [benjamin.hindman] Used new CommandInfo with Docker::run. [tstclair] Fix for configure --disable-python -- Started

Re: Review Request 24563: MESOS-1693: enable build against non-x86 arch

2014-08-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24563/#review50614 --- Ship it! 3rdparty/libprocess/include/process/internal.hpp

Re: Review Request 24264: Installed python libraries during make install.

2014-08-14 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24264/#review50616 --- Let me know if you want any help on the updated configure checks.

Build failed in Jenkins: Mesos-Ubuntu-distcheck #272

2014-08-14 Thread Apache Jenkins Server
See https://builds.apache.org/job/Mesos-Ubuntu-distcheck/272/changes Changes: [tstclair] MESOS-1169: unbundle distribute [benjamin.hindman] Added explicit DockerInfo within ContainerInfo. [benjamin.hindman] Used new CommandInfo with Docker::run. --

Re: Review Request 24563: MESOS-1693: enable build against non-x86 arch

2014-08-14 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24563/ --- (Updated Aug. 14, 2014, 6:38 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 24563: MESOS-1693: enable build against non-x86 arch

2014-08-14 Thread Timothy St. Clair
On Aug. 14, 2014, 4:44 p.m., Jie Yu wrote: 3rdparty/libprocess/include/process/internal.hpp, line 18 https://reviews.apache.org/r/24563/diff/1/?file=657649#file657649line18 Do all the other arch have nop instruction? That I'm aware of, yes. - Timothy

Re: Build failed in Jenkins: mesos-reviewbot #1343

2014-08-14 Thread Vinod Kone
On Thu, Aug 14, 2014 at 11:16 AM, Apache Jenkins Server jenk...@builds.apache.org wrote: Checking 503 files using filter

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2317

2014-08-14 Thread Apache Jenkins Server
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2317/changes

Review Request 24709: Redirect Docker logs.

2014-08-14 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24709/ --- Review request for mesos, Jie Yu and Timothy Chen. Repository: mesos-git

Re: Review Request 24709: Redirect Docker logs.

2014-08-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24709/#review50622 --- Ship it! Ship It! - Jie Yu On Aug. 14, 2014, 7:48 p.m.,

Re: Review Request 24709: Redirect Docker logs.

2014-08-14 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24709/#review50620 --- Ship it! Ship It! src/tests/mesos.cpp

Re: Review Request 24714: fix prefiex glog on mac

2014-08-14 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24714/ --- (Updated Aug. 14, 2014, 9:01 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 24700: Log the user id when receiving a SIGTERM.

2014-08-14 Thread Ben Mahler
On Aug. 14, 2014, 5:47 p.m., Nikita Vetoshkin wrote: I don't think that si_uid can give something interesting because it can be either 0 or UID of receiving process. How about logging si_pid too? si_uid represents the user id of the _sending_ process, not the receiving process. Am I

Build failed in Jenkins: mesos-reviewbot #1344

2014-08-14 Thread Apache Jenkins Server
See https://builds.apache.org/job/mesos-reviewbot/1344/changes Changes: [tstclair] MESOS-1693: enable build against non-x86 arch [yujie.jay] Fixed a few compiler warnings in stout. -- [URLTrigger] A change within the response URL invocation (log)

Re: Review Request 24714: fix prefiex glog on mac

2014-08-14 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24714/#review50639 --- configure.ac https://reviews.apache.org/r/24714/#comment88496

Re: Review Request 24714: fix prefiex glog on mac

2014-08-14 Thread Timothy St. Clair
On Aug. 14, 2014, 9:08 p.m., Vinod Kone wrote: configure.ac, line 281 https://reviews.apache.org/r/24714/diff/1/?file=660837#file660837line281 so src worked on linux but not on osx? how's that possible? It shouldn't have worked. It likely flew under the radar due to system

Re: Review Request 24714: fix prefiex glog on mac

2014-08-14 Thread Timothy St. Clair
On Aug. 14, 2014, 9:08 p.m., Vinod Kone wrote: configure.ac, line 281 https://reviews.apache.org/r/24714/diff/1/?file=660837#file660837line281 so src worked on linux but not on osx? how's that possible? Timothy St. Clair wrote: It shouldn't have worked. It likely flew

Re: Review Request 24714: fix prefiex glog on mac

2014-08-14 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24714/#review50642 --- Ship it! pls test this on linux too if you haven't already, before

Re: Review Request 24667: Added a user doc for framework rate limiting.

2014-08-14 Thread Jiang Yan Xu
On Aug. 13, 2014, 4:44 p.m., Vinod Kone wrote: docs/framework-rate-limiting.md, line 61 https://reviews.apache.org/r/24667/diff/1/?file=659575#file659575line61 what do you mean by nature of the frameworks? do you mean messages generated by the frameworks? Removed these

Re: Review Request 24667: Added a user doc for framework rate limiting.

2014-08-14 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24667/ --- (Updated Aug. 14, 2014, 3:16 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 24667: Added a user doc for framework rate limiting.

2014-08-14 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24667/#review50659 --- Ship it! docs/framework-rate-limiting.md

Review Request 24719: Added document for network monitoring.

2014-08-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24719/ --- Review request for mesos, Ian Downes and Vinod Kone. Repository: mesos-git

Jenkins build is back to normal : Mesos-Ubuntu-distcheck #273

2014-08-14 Thread Apache Jenkins Server
See https://builds.apache.org/job/Mesos-Ubuntu-distcheck/273/changes

Re: Review Request 24719: Added document for network monitoring.

2014-08-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24719/ --- (Updated Aug. 14, 2014, 10:59 p.m.) Review request for mesos, Ian Downes and

Re: Review Request 23414: Unbundling of libev

2014-08-14 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23414/#review50664 --- 3rdparty/libprocess/configure.ac

Re: Python bindings are changing!

2014-08-14 Thread Thomas Rampelberg
There is one important step to do during the upgrade: - Upgrade your python framework and executor. You'll be able to either import using the new configuration or the old. Replace the existing imports with this: try: from mesos.native import MesosExecutorDriver, MesosSchedulerDriver

Build failed in Jenkins: mesos-reviewbot #1345

2014-08-14 Thread Apache Jenkins Server
See https://builds.apache.org/job/mesos-reviewbot/1345/changes Changes: [benjamin.hindman] Redirect Docker logs. [yan] Added a user doc for framework rate limiting. -- [URLTrigger] A change within the response URL invocation (log) [URLTrigger] A change

Re: Review Request 24719: Added document for network monitoring.

2014-08-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24719/ --- (Updated Aug. 15, 2014, 12:13 a.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 24719: Added document for network monitoring.

2014-08-14 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24719/#review50668 --- Ship it! docs/network-monitoring.md

Review Request 24722: Make sure the mesos-fetcher exits if the slave terminates.

2014-08-14 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24722/ --- Review request for mesos, Ian Downes and Jie Yu. Repository: mesos-git

Re: Review Request 24722: Make sure the mesos-fetcher exits if the slave terminates.

2014-08-14 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24722/ --- (Updated Aug. 15, 2014, 12:26 a.m.) Review request for mesos, Ian Downes and

Re: Review Request 24722: Make sure the mesos-fetcher exits if the slave terminates.

2014-08-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24722/#review50673 --- Ship it! src/launcher/fetcher.cpp

Re: Review Request 24722: Make sure the mesos-fetcher exits if the slave terminates.

2014-08-14 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24722/#review50681 --- src/launcher/fetcher.cpp

Re: Review Request 24714: fix prefix glog on mac

2014-08-14 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24714/ --- (Updated Aug. 15, 2014, 1:07 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 24687: Added support for disabling glog initialization.

2014-08-14 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24687/#review50678 --- Ship it! include/mesos/executor.hpp

Re: Review Request 24722: Make sure the mesos-fetcher exits if the slave terminates.

2014-08-14 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24722/#review50687 --- Ship it! src/launcher/fetcher.cpp

Re: Review Request 23414: Unbundling of libev

2014-08-14 Thread Vinod Kone
On Aug. 15, 2014, 1:18 a.m., Vinod Kone wrote: 3rdparty/libprocess/configure.ac, lines 80-86 https://reviews.apache.org/r/23414/diff/1/?file=628545#file628545line80 I think you also forgot to plumb this through the configure.ac at the root of the repo, like you did for other

Re: Review Request 20983: Update system check (http-parser)

2014-08-14 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20983/#review50690 --- 3rdparty/libprocess/configure.ac

Re: Review Request 24719: Added document for network monitoring.

2014-08-14 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24719/#review50686 --- Ship it! all minor stuff. docs/network-monitoring.md

Re: Review Request 24667: Added a user doc for framework rate limiting.

2014-08-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24667/#review50697 --- Bad patch! Reviews applied: [24667] Failed command: git apply

Jenkins build is back to normal : mesos-reviewbot #1346

2014-08-14 Thread Apache Jenkins Server
See https://builds.apache.org/job/mesos-reviewbot/1346/changes

Re: Review Request 24700: Log the user id when receiving a SIGTERM.

2014-08-14 Thread Nikita Vetoshkin
On Aug. 14, 2014, 5:47 p.m., Nikita Vetoshkin wrote: I don't think that si_uid can give something interesting because it can be either 0 or UID of receiving process. How about logging si_pid too? Ben Mahler wrote: si_uid represents the user id of the _sending_ process, not the

Review Request 24730: Allow override to run in command executor

2014-08-14 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24730/ --- Review request for mesos, Benjamin Hindman and Jie Yu. Repository: mesos-git

Review Request 24731: Allow external isolator flag to be backward compatible

2014-08-14 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24731/ --- Review request for mesos and Benjamin Hindman. Repository: mesos-git

Re: Review Request 24731: Allow external isolator flag to be backward compatible

2014-08-14 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24731/ --- (Updated Aug. 15, 2014, 4:04 a.m.) Review request for mesos and Benjamin

Re: Review Request 24731: Allow external isolator flag to be backward compatible

2014-08-14 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24731/#review50700 --- Ship it! src/slave/containerizer/containerizer.cpp

Review Request 24732: Fix build error in docker.cpp for clang

2014-08-14 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24732/ --- Review request for mesos and Benjamin Hindman. Repository: mesos-git

Re: Review Request 24731: Allow external isolator flag to be backward compatible

2014-08-14 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24731/ --- (Updated Aug. 15, 2014, 5:01 a.m.) Review request for mesos and Benjamin

Review Request 24733: Minor fixes for prefix installation of libev and http-parser.

2014-08-14 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24733/ --- Review request for mesos, Jie Yu and Timothy St. Clair. Repository: mesos-git

Build failed in Jenkins: Mesos-Ubuntu-distcheck #275

2014-08-14 Thread Apache Jenkins Server
See https://builds.apache.org/job/Mesos-Ubuntu-distcheck/275/changes Changes: [vinodkone] Fixed style issues in slave/flags.hpp. -- [...truncated 2646 lines...] [INFO] [INFO] --- maven-remote-resources-plugin:1.3:process (default) @ mesos --- [INFO]

Re: Review Request 24733: Minor fixes for prefix installation of libev and http-parser.

2014-08-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24733/#review50705 --- Ship it! Ship It! - Jie Yu On Aug. 15, 2014, 5:36 a.m., Vinod