---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25084/#review51743
---
Looks pretty good. Just a couple questions about #if logic, testing
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24776/#review51750
---
Jie or Ben can you guys commit this?
- Timothy Chen
On Aug. 16,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24776/#review51751
---
Jie or Ben can you guys commit this?
- Timothy Chen
On Aug. 16,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25079/#review51748
---
I'm no expert in variadic templates, but the rest of the code
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24808/
---
(Updated Aug. 28, 2014, 6:35 a.m.)
Review request for mesos and Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25111/#review51761
---
Patch looks great!
Reviews applied: [25111]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25111/#review51753
---
Great start! I've got several style nits, and some thoughts about
Hi Brian,
thanks for the answer. This sounds reasonable, it would be nice to somehow
enforce this crash-if-fail behaviour in client executors, but it seems
barely possible.
Alex
On Thu, Aug 28, 2014 at 12:56 AM, Brian Wickman wick...@apache.org wrote:
A crashed thread does not terminate the
Greetings!
Because folks have been asking, I've been updating my spec here:
http://pkgs.fedoraproject.org/cgit/mesos.git/tree/mesos.spec
clone url: git://pkgs.fedoraproject.org/mesos
My integration stream is:
https://github.com/timothysc/mesos/tree/0.20-integ
I intend to push most patches
See https://builds.apache.org/job/mesos-reviewbot/1425/
--
[...truncated 5589 lines...]
rm -f sasl/*.lo
rm -f slave/containerizer/mesos/.dirstamp
rm -f sched/*.o
rm -f sched/*.lo
rm -f state/.deps/.dirstamp
rm -f scheduler/*.o
rm -f state/.dirstamp
rm -f
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25111/
---
(Updated Aug. 28, 2014, 4:15 p.m.)
Review request for mesos, Adam B and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25079/
---
(Updated Aug. 28, 2014, 4:24 p.m.)
Review request for mesos, Adam B and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25111/
---
(Updated Aug. 28, 2014, 4:36 p.m.)
Review request for mesos, Adam B and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25111/
---
(Updated Aug. 28, 2014, 4:42 p.m.)
Review request for mesos, Adam B and
On Aug. 28, 2014, 8:37 a.m., Adam B wrote:
Great start! I've got several style nits, and some thoughts about extending
beyond supersets.
- How do you plan to test this? Have you tried just restarting a
checkpointed slave process with new resources/attributes? I think you would
run
On Aug. 28, 2014, 5:15 p.m., Tobias Weingartner wrote:
src/slave/slave.cpp, lines 2736-2738
https://reviews.apache.org/r/25111/diff/7/?file=671417#file671417line2736
I appreciate the sentiment here. However, both resources and
attributes (although more attributes) could indicate
On Aug. 28, 2014, 8:37 a.m., Adam B wrote:
src/common/attributes.cpp, lines 161-164
https://reviews.apache.org/r/25111/diff/4/?file=670589#file670589line161
In your code, this.isSuperset(that) returns false if any of this's
attributes are not present in that. It therefore returns
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25111/
---
(Updated Aug. 28, 2014, 6:11 p.m.)
Review request for mesos, Adam B and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25124/
---
(Updated Aug. 28, 2014, 11:51 a.m.)
Review request for mesos, Benjamin Hindman
On Aug. 27, 2014, 4:01 p.m., Dominic Hamon wrote:
src/net-bench/main.cpp, line 166
https://reviews.apache.org/r/25124/diff/1/?file=670615#file670615line166
it might be worth (for a future version) allowing this to be a random
string of user-defined length and also tracking
See https://builds.apache.org/job/mesos-reviewbot/1426/
--
[...truncated 5588 lines...]
rm -f scheduler/*.o
rm -f slave/containerizer/isolators/cgroups/.dirstamp
rm -f scheduler/*.lo
rm -f slave/containerizer/isolators/network/.deps/.dirstamp
rm -f
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2074/changes
Changes:
[bmahler] Refactored the JSON output streaming.
[bmahler] Adjustments for new JSON streaming.
[vinodkone] Added logging when master/slaves/frameworks bind to loopback
address.
[vinodkone]
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25111/
---
(Updated Aug. 28, 2014, 10:10 p.m.)
Review request for mesos, Adam B and
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2371/changes
Changes:
[niklas] Modifed execute cli to run docker images.
--
[...truncated 260 lines...]
3rdparty/Makefile.am:145: warning: source file
See https://builds.apache.org/job/Mesos-Ubuntu-distcheck/306/changes
Changes:
[niklas] Modifed execute cli to run docker images.
--
Started by an SCM change
Building remotely on ubuntu3 (Ubuntu ubuntu) in workspace
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25167/
---
Review request for mesos, Adam B and Benjamin Hindman.
Bugs: MESOS-1744
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2075/changes
Changes:
[niklas] Modifed execute cli to run docker images.
--
Started by an SCM change
Building remotely on ubuntu3 (Ubuntu ubuntu) in workspace
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25167/#review51840
---
a quick high-level note that it's generally prefered that patches
Hmm - don't know what happened here. We didn't touch libcurl - do you
guys have any insight here?
Niklas
On 28 August 2014 15:19, Apache Jenkins Server jenk...@builds.apache.org
wrote:
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2371/changes
Thanks for the prompt response Vinod!
Niklas
On 28 August 2014 15:28, Vinod Kone vinodk...@gmail.com wrote:
libcurl is not installed on some jenkins slaves. i pinged jake farrell on
a separate thread and waiting to hear back.
On Thu, Aug 28, 2014 at 3:26 PM, Niklas Nielsen
On Aug. 28, 2014, 10:25 p.m., Dominic Hamon wrote:
a quick high-level note that it's generally prefered that patches are split
along stout, libprocess, and mesos boundaries. you can set reviewboard
patches to depend on other ones to ensure that they land together.
[~dhamon] Okay I'll
See https://builds.apache.org/job/mesos-reviewbot/1427/
--
[...truncated 5588 lines...]
rm -f slave/containerizer/.deps/.dirstamp
rm -f slave/containerizer/.dirstamp
rm -f slave/containerizer/isolators/cgroups/.deps/.dirstamp
rm -f
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25168/
---
Review request for mesos, Benjamin Hindman and Vinod Kone.
Bugs: MESOS-750
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25169/
---
Review request for mesos, Benjamin Hindman and Vinod Kone.
Bugs: MESOS-750
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25169/#review51846
---
Ship it!
3rdparty/libprocess/configure.ac
On Aug. 28, 2014, 11:30 p.m., Vinod Kone wrote:
3rdparty/libprocess/configure.ac, line 518
https://reviews.apache.org/r/25169/diff/1/?file=671777#file671777line518
Can we print the supported versions here. I think that will be helpful
for users.
nm. i think we are getting away
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25168/
---
(Updated Aug. 28, 2014, 4:40 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25169/
---
(Updated Aug. 28, 2014, 4:41 p.m.)
Review request for mesos, Benjamin Hindman
Tomorrow, I'm planning to land changes that complete the deprecation cycle
for the with-cxx11 configure flag. From this point on, the compiler you use
will need to support the subset of C++11 language features checked by our
configure script. These are:
- static_assert
- right angle brackets
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25105/#review51860
---
Patch looks great!
Reviews applied: [25105]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25084/#review51868
---
Patch looks great!
Reviews applied: [25084]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25124/
---
(Updated Aug. 28, 2014, 10:19 p.m.)
Review request for mesos, Benjamin Hindman
42 matches
Mail list logo
