Re: Review Request 25434: Propagate slave shutdown grace period to Executor and CommandExecutor.

2014-09-09 Thread Alexander Rukletsov
On Sept. 9, 2014, 9:33 a.m., Till Toenshoff wrote: src/slave/constants.hpp, lines 51-57 https://reviews.apache.org/r/25434/diff/1/?file=682522#file682522line51 I really like this approach. Just wanted to make sure we do not create timeout's (using the /2 or /3 arithmetics) that

Re: Review Request 25439: Fix protobuf detection on systems with Python 3 as default

2014-09-09 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25439/#review52717 --- Could you please rebase for clean apply. - Timothy St. Clair On

Re: Review Request 25439: Fix protobuf detection on systems with Python 3 as default

2014-09-09 Thread Kamil Domanski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25439/ --- (Updated Sept. 9, 2014, 4:49 p.m.) Review request for mesos and Timothy St.

Re: Getting Started with Mesos on Fedora 21 and CentOS 7

2014-09-09 Thread Thomas Rampelberg
This is *so* awesome. Thanks for getting the packages *and* docs together Tim =) On Mon, Sep 8, 2014 at 7:50 PM, Tim St Clair tstcl...@redhat.com wrote: http://timothysc.github.io/blog/2014/09/08/mesos-breeze/ -- Cheers, Timothy St. Clair Red Hat Inc.

Re: Review Request 25434: Propagate slave shutdown grace period to Executor and CommandExecutor.

2014-09-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25434/#review52727 --- Patch looks great! Reviews applied: [25434] All tests passed. -

Re: deploy_dir

2014-09-09 Thread Tim St Clair
Does anyone depend on the current location? - Original Message - From: Vinod Kone vinodk...@gmail.com To: dev dev@mesos.apache.org Sent: Sunday, September 7, 2014 11:18:30 PM Subject: Re: deploy_dir /etc/mesos looks straightforward to me. On Fri, Sep 5, 2014 at 1:31 AM,

Re: Review Request 25447: Update deploy_dir from localstate to sysconf

2014-09-09 Thread Timothy St. Clair
On Sept. 9, 2014, 12:55 a.m., Vinod Kone wrote: This probably needs a call out in the CHANGELOG so that people are not surprised by it. Also, do you know of anyone using/depending on it? If yes, this probably needs to go through a deprecation cycle. Are there any mechanics to

Re: Review Request 25434: Propagate slave shutdown grace period to Executor and CommandExecutor.

2014-09-09 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25434/#review52729 --- src/exec/exec.cpp https://reviews.apache.org/r/25434/#comment91709

Re: Review Request 25434: Propagate slave shutdown grace period to Executor and CommandExecutor.

2014-09-09 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25434/#review52726 --- I think this will work (and good job on style btw!). The biggest

Re: Review Request 25434: Propagate slave shutdown grace period to Executor and CommandExecutor.

2014-09-09 Thread Niklas Nielsen
On Sept. 9, 2014, 9:21 a.m., Timothy Chen wrote: src/launcher/executor.cpp, line 664 https://reviews.apache.org/r/25434/diff/2/?file=683946#file683946line664 I'm not sure we've all agreed to start using C++11 yet? Good catch - no auto's yet. - Niklas

Re: Review Request 25434: Propagate slave shutdown grace period to Executor and CommandExecutor.

2014-09-09 Thread Alexander Rukletsov
On Sept. 9, 2014, 4:21 p.m., Timothy Chen wrote: src/launcher/executor.cpp, line 682 https://reviews.apache.org/r/25434/diff/2/?file=683946#file683946line682 I'm not sure I'm really following the logic, I know the levels but I don't know why there is the divide by 2/3 on each

Re: Review Request 25111: Added the concept of dynamically configurable slave attributes

2014-09-09 Thread Patrick Reilly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25111/ --- (Updated Sept. 9, 2014, 4:51 p.m.) Review request for mesos, Adam B and

Re: Review Request 25434: Propagate slave shutdown grace period to Executor and CommandExecutor.

2014-09-09 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25434/#review52740 --- src/exec/exec.cpp https://reviews.apache.org/r/25434/#comment91728

Re: Review Request 25447: Update deploy_dir from localstate to sysconf

2014-09-09 Thread Vinod Kone
On Sept. 9, 2014, 12:55 a.m., Vinod Kone wrote: This probably needs a call out in the CHANGELOG so that people are not surprised by it. Also, do you know of anyone using/depending on it? If yes, this probably needs to go through a deprecation cycle. Timothy St. Clair wrote: Are

Twitter sprint Q3.5

2014-09-09 Thread Dominic Hamon
Hello Mesos developers! I thought it might be useful to have a little insight into how we work on Mesos at Twitter and, more specifically, what we are working on. We work in biweekly sprints and starting with this one (that just began yesterday) I'm going to start sending out a summary of what

Mesos webcast

2014-09-09 Thread Vinod Kone
Hi folks, I'm doing a webcast on Mesos this thursday (h/t Mesosphere) where I will talk about some of the core features of Mesos (slave recovery, authentication and authorization). At the end, we will have time for QA for any and all questions related to Mesos. More details:

[GitHub] mesos pull request: Added Vagrant and Ansible repo to the tools li...

2014-09-09 Thread bspaans
GitHub user bspaans opened a pull request: https://github.com/apache/mesos/pull/25 Added Vagrant and Ansible repo to the tools list You can merge this pull request into a Git repository by running: $ git pull https://github.com/bspaans/mesos master Alternatively you can

Re: Review Request 25434: Propagate slave shutdown grace period to Executor and CommandExecutor.

2014-09-09 Thread Alexander Rukletsov
On Sept. 9, 2014, 4:39 p.m., Niklas Nielsen wrote: I think this will work (and good job on style btw!). The biggest piece that I find missing is testing; we need tests to verify that the new escalation logic works as we expect. Tests in case of long (more than 3 deltas) and short

Re: Review Request 25434: Propagate slave shutdown grace period to Executor and CommandExecutor.

2014-09-09 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25434/#review52750 --- Great seeing new folks submitting reviews! Just a drive by here,

Re: Review Request 25434: Propagate slave shutdown grace period to Executor and CommandExecutor.

2014-09-09 Thread Benjamin Hindman
On Sept. 9, 2014, 4:21 p.m., Timothy Chen wrote: src/launcher/executor.cpp, line 682 https://reviews.apache.org/r/25434/diff/2/?file=683946#file683946line682 I'm not sure I'm really following the logic, I know the levels but I don't know why there is the divide by 2/3 on each

Re: Review Request 25434: Propagate slave shutdown grace period to Executor and CommandExecutor.

2014-09-09 Thread Benjamin Hindman
On Sept. 9, 2014, 4:39 p.m., Niklas Nielsen wrote: src/tests/containerizer.cpp, line 113 https://reviews.apache.org/r/25434/diff/2/?file=683955#file683955line113 Why 3 seconds? Alexander Rukletsov wrote: Though default is 5, I decide to set it to 3 (which is the lower

Re: Review Request 25434: Propagate slave shutdown grace period to Executor and CommandExecutor.

2014-09-09 Thread Alexander Rukletsov
On Sept. 9, 2014, 5:50 p.m., Benjamin Hindman wrote: src/slave/constants.hpp, line 53 https://reviews.apache.org/r/25434/diff/2/?file=683947#file683947line53 What is the 'base executor' versus the 'command executor'? We have Executor (lives in src/exec/exec.cpp) and CommandExecutor

Re: Review Request 24776: Add docker containerizer destroy tests

2014-09-09 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24776/#review52758 --- Why did you need to mock DockerContainerizerProcess in order to

Re: Review Request 25434: Propagate slave shutdown grace period to Executor and CommandExecutor.

2014-09-09 Thread Benjamin Hindman
On Sept. 9, 2014, 5:50 p.m., Benjamin Hindman wrote: src/slave/constants.hpp, line 53 https://reviews.apache.org/r/25434/diff/2/?file=683947#file683947line53 What is the 'base executor' versus the 'command executor'? Alexander Rukletsov wrote: We have Executor (lives in

Re: Review Request 25447: Update deploy_dir from localstate to sysconf

2014-09-09 Thread Timothy St. Clair
On Sept. 9, 2014, 12:55 a.m., Vinod Kone wrote: This probably needs a call out in the CHANGELOG so that people are not surprised by it. Also, do you know of anyone using/depending on it? If yes, this probably needs to go through a deprecation cycle. Timothy St. Clair wrote: Are

Re: Review Request 25237: Avoid Docker pull on each run

2014-09-09 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25237/#review52761 --- src/slave/containerizer/docker.cpp

Re: Twitter sprint Q3.5

2014-09-09 Thread Tim St Clair
Dominic - This is very helpful, thank you! - Original Message - From: Dominic Hamon dha...@twopensource.com To: dev dev@mesos.apache.org Sent: Tuesday, September 9, 2014 12:16:01 PM Subject: Twitter sprint Q3.5 Hello Mesos developers! I thought it might be useful to have a

Re: Review Request 25270: Enable bridge network in Mesos

2014-09-09 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25270/#review52764 --- Looking good! include/mesos/mesos.proto

Re: Review Request 25403: Override entrypoint when shell enabled in Docker

2014-09-09 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25403/#review52767 --- src/docker/docker.cpp

Build failed in Jenkins: mesos-reviewbot #1504

2014-09-09 Thread Apache Jenkins Server
See https://builds.apache.org/job/mesos-reviewbot/1504/ -- [...truncated 5392 lines...] rm -f slave/.deps/.dirstamp rm -f slave/.dirstamp rm -f slave/containerizer/*.lo rm -f slave/containerizer/isolators/cgroups/*.o rm -f

Re: Review Request 24264: Installed python libraries during make install.

2014-09-09 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24264/#review52769 --- I'm trying to find a policy on checking in binaries to the repo-

Re: Review Request 25035: Fix for MESOS-1688

2014-09-09 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25035/#review52763 --- src/master/hierarchical_allocator_process.hpp

Re: Review Request 25372: Made the GarbageCollector injectable into the Slave.

2014-09-09 Thread Ben Mahler
On Sept. 8, 2014, 5:42 p.m., Vinod Kone wrote: src/tests/cluster.hpp, line 597 https://reviews.apache.org/r/25372/diff/1/?file=679951#file679951line597 Since you are cleaning up this code, I don't think this variable is necessary anymore? Actually I don't know why it was used in

Re: Review Request 25372: Made the GarbageCollector injectable into the Slave.

2014-09-09 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25372/#review52775 --- Ship it! Ship It! - Vinod Kone On Sept. 9, 2014, 12:43 a.m.,

Re: Review Request 25372: Made the GarbageCollector injectable into the Slave.

2014-09-09 Thread Vinod Kone
On Sept. 8, 2014, 5:42 p.m., Vinod Kone wrote: src/tests/cluster.hpp, line 597 https://reviews.apache.org/r/25372/diff/1/?file=679951#file679951line597 Since you are cleaning up this code, I don't think this variable is necessary anymore? Actually I don't know why it was used in

Re: Review Request 25434: Propagate slave shutdown grace period to Executor and CommandExecutor.

2014-09-09 Thread Alexander Rukletsov
On Sept. 9, 2014, 5:50 p.m., Benjamin Hindman wrote: src/slave/constants.hpp, line 53 https://reviews.apache.org/r/25434/diff/2/?file=683947#file683947line53 What is the 'base executor' versus the 'command executor'? Alexander Rukletsov wrote: We have Executor (lives in

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2358

2014-09-09 Thread Yan Xu
this is https://issues.apache.org/jira/browse/MESOS-1766 -- Jiang Yan Xu y...@jxu.me @xujyan http://twitter.com/xujyan On Fri, Sep 5, 2014 at 8:53 AM, Apache Jenkins Server jenk...@builds.apache.org wrote: See

Build failed in Jenkins: mesos-reviewbot #1505

2014-09-09 Thread Apache Jenkins Server
See https://builds.apache.org/job/mesos-reviewbot/1505/changes Changes: [niklas] Updated the Mesos C++ Style Guide. [tstclair] Update deploy_dir from localstate to sysconf -- [...truncated 4178 lines...] test ../.. = .. || \

mesos authorization

2014-09-09 Thread Jay Buffington
Hi All, I've had a few conversations offline with mesos contributors regarding authorization and authentication. I'd like to solicit the larger community for comments. I want to create groups of people and allow those groups to only launch tasks as certain unix users. Commonly, this unix user

Build failed in Jenkins: mesos-reviewbot #1506

2014-09-09 Thread Apache Jenkins Server
See https://builds.apache.org/job/mesos-reviewbot/1506/ -- [...truncated 5590 lines...] rm -f slave/*.lo rm -f slave/containerizer/.deps/.dirstamp rm -f slave/containerizer/*.o rm -f slave/containerizer/.dirstamp rm -f slave/containerizer/*.lo rm -f

Re: Review Request 23708: Fix line comments end punctuation in stout

2014-09-09 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23708/#review52820 --- Ship it! Ship It! - Niklas Nielsen On Aug. 19, 2014, 5:36 p.m.,

Review Request 25487: Increased session timeouts for ZooKeeper related tests.

2014-09-09 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25487/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-1676