On Sept. 29, 2014, 2:57 p.m., Niklas Nielsen wrote:
include/mesos/module.hpp.in, lines 46-47
https://reviews.apache.org/r/25848/diff/11/?file=708522#file708522line46
Can we use existing boost helpers for this? Something like
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25861/
---
(Updated Oct. 3, 2014, 10:05 a.m.)
Review request for mesos, Jie Yu and Vinod
See https://builds.apache.org/job/mesos-reviewbot/1826/
--
[URLTrigger] A change within the response URL invocation (log)
Building remotely on ubuntu-1 (Ubuntu ubuntu) in workspace
https://builds.apache.org/job/mesos-reviewbot/ws/
git rev-parse
On Oct. 2, 2014, 12:49 a.m., Timothy Chen wrote:
src/slave/utils.cpp, line 39
https://reviews.apache.org/r/25434/diff/4/?file=709161#file709161line39
Log the timeout value
Both the one that is too small and the effective one.
- Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25434/#review55348
---
Hi Alex,
Sorry for the tardy reply on this review. I have left a
See https://builds.apache.org/job/mesos-reviewbot/1827/
On Sept. 25, 2014, 12:20 p.m., Ben Mahler wrote:
3rdparty/libprocess/include/process/event.hpp, lines 23-24
https://reviews.apache.org/r/25945/diff/1/?file=702991#file702991line23
Do you need this forward declaration? Or, can we remove the future.hpp
include?
i think i need both
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25945/
---
(Updated Oct. 3, 2014, 10:59 a.m.)
Review request for mesos, Benjamin Hindman
On Oct. 2, 2014, 9:39 p.m., Ben Mahler wrote:
Any reason why there's no bundled version for these, like we did for other
libraries?
I don't see this on my Mac and would like to avoid needing a special
./configure flag.
Timothy Chen wrote:
I was wondering if I should bundle
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25945/#review55373
---
Bad patch!
Reviews applied: [26289, 25945]
Failed command: git
On Sept. 25, 2014, 6:17 p.m., Vinod Kone wrote:
src/slave/containerizer/isolators/namespaces/pid.hpp, line 28
https://reviews.apache.org/r/25865/diff/2/?file=703446#file703446line28
s/NamespacesPid/PidNamespace/ ?
I'm following the convention set by Cgroups{Mem,Cpu}IsolatorProcess.
On Sept. 25, 2014, 3:27 p.m., Vinod Kone wrote:
src/tests/isolator_tests.cpp, line 446
https://reviews.apache.org/r/24177/diff/3/?file=703418#file703418line446
probably not part of this review, but we avoid this pattern because it
could lead to leaked temp directories if the test
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26329/
---
Review request for mesos.
Bugs: MESOS-1863
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26329/#review55397
---
src/master/master.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26329/#review55409
---
Patch looks great!
Reviews applied: [26329]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25848/
---
(Updated Oct. 3, 2014, 7:46 p.m.)
Review request for mesos, Benjamin Hindman,
16 matches
Mail list logo