---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29556/#review66795
---
src/common/protobuf_utils.hpp
On Jan. 5, 2015, 10:47 p.m., Timothy Chen wrote:
src/common/protobuf_utils.hpp, line 58
https://reviews.apache.org/r/29556/diff/2/?file=807500#file807500line58
This seems like you can just declare the function in cpp without adding
it in the headers, but this is fine with me too.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29556/#review66793
---
Ship it!
LGTM.
src/master/master.cpp
On Jan. 6, 2015, 6:47 a.m., Timothy Chen wrote:
src/common/protobuf_utils.hpp, line 58
https://reviews.apache.org/r/29556/diff/2/?file=807500#file807500line58
This seems like you can just declare the function in cpp without adding
it in the headers, but this is fine with me too.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29556/
---
(Updated Jan. 6, 2015, 7:28 a.m.)
Review request for mesos, Adam B and Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29473/#review66797
---
Ship it!
Looks great! If nobody objects, we can commit this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29526/#review66615
---
Ship it!
Ship It!
- Niklas Nielsen
On Jan. 1, 2015, 8:45 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29527/#review66616
---
Ship it!
Taken it's just a code move
- Niklas Nielsen
On Jan.
On Jan. 1, 2015, 9:03 p.m., Mesos ReviewBot wrote:
Bad patch!
Reviews applied: [29526, 29527, 29528, 29529, 29530, 29531, 29532, 29533,
29534, 29535, 29536, 29538, 29539]
Failed command: ./support/apply-review.sh -n -r 29539
Error:
2015-01-02 05:03:58
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29550/#review66659
---
Did you make sure that the stout tests are built as well as the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29551/#review1
---
Ship it!
- Cody Maloney
On Jan. 3, 2015, 12:15 a.m., Kapil Arya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29551/#review2
---
Nice idea, but you can already do this using make check
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29288/#review6
---
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29533/#review66739
---
Mind adding some tests for the stringification? :)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29556/
---
(Updated Jan. 5, 2015, 11:17 p.m.)
Review request for mesos, Adam B and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29599/
---
Review request for mesos.
Bugs: MESOS-2096
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29603/
---
Review request for mesos.
Bugs: MESOS-2096
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29605/
---
Review request for mesos.
Bugs: MESOS-2096
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29602/
---
Review request for mesos.
Bugs: MESOS-2096
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29600/
---
Review request for mesos.
Bugs: MESOS-2096
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29596/
---
Review request for mesos, Cody Maloney, Niklas Nielsen, and Till Toenshoff.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29607/
---
Review request for mesos.
Repository: mesos-git
Description
---
Module
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29598/
---
Review request for mesos, Niklas Nielsen and Till Toenshoff.
Bugs: MESOS-2096
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29597/
---
Review request for mesos, Niklas Nielsen and Till Toenshoff.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29606/
---
Review request for mesos.
Bugs: MESOS-2096
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29601/
---
Review request for mesos.
Bugs: MESOS-2096
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29604/
---
Review request for mesos.
Bugs: MESOS-2096
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29595/
---
Review request for mesos, Cody Maloney, Niklas Nielsen, and Till Toenshoff.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29602/
---
(Updated Jan. 5, 2015, 6:27 p.m.)
Review request for mesos, Niklas Nielsen and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29607/
---
(Updated Jan. 5, 2015, 6:27 p.m.)
Review request for mesos, Niklas Nielsen and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29605/
---
(Updated Jan. 5, 2015, 6:27 p.m.)
Review request for mesos, Niklas Nielsen and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29599/
---
(Updated Jan. 5, 2015, 6:27 p.m.)
Review request for mesos, Niklas Nielsen and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29603/
---
(Updated Jan. 5, 2015, 6:27 p.m.)
Review request for mesos, Niklas Nielsen and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29604/
---
(Updated Jan. 5, 2015, 6:27 p.m.)
Review request for mesos, Niklas Nielsen and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29600/
---
(Updated Jan. 5, 2015, 6:27 p.m.)
Review request for mesos, Niklas Nielsen and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29606/
---
(Updated Jan. 5, 2015, 6:27 p.m.)
Review request for mesos, Niklas Nielsen and
On Jan. 5, 2015, 5:49 p.m., Timothy Chen wrote:
src/hook/manager.cpp, line 124
https://reviews.apache.org/r/28875/diff/3/?file=803964#file803964line124
This should never happen right? CHECK instead?
This can happen, if non of the hook modules install a remove-executor hook.
This
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28655/
---
(Updated Jan. 5, 2015, 5:42 p.m.)
Review request for mesos and Niklas Nielsen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28656/
---
(Updated Jan. 5, 2015, 5:42 p.m.)
Review request for mesos and Niklas Nielsen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29496/
---
(Updated Jan. 5, 2015, 5:42 p.m.)
Review request for mesos.
Changes
---
On Jan. 5, 2015, 5:36 p.m., Dominic Hamon wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 427
https://reviews.apache.org/r/29288/diff/3/?file=803230#file803230line427
add an else to catch bad families.
I don't think the Error messages with unsupported family
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29529/#review66738
---
Ship it!
Nice cleanup, thanks!
- Ben Mahler
On Jan. 2, 2015,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29534/#review66740
---
Ship it!
Mind adding some new test cases for the URL overloads?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29033/#review66745
---
src/slave/containerizer/isolators/network/port_mapping.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29601/
---
(Updated Jan. 5, 2015, 6:27 p.m.)
Review request for mesos, Niklas Nielsen and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29033/#review66732
---
Patch looks great!
Reviews applied: [29033]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28875/
---
(Updated Jan. 5, 2015, 5:42 p.m.)
Review request for mesos and Niklas Nielsen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28875/#review66741
---
src/hook/manager.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29533/#review66742
---
3rdparty/libprocess/3rdparty/stout/include/stout/url.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29606/
---
(Updated Jan. 5, 2015, 7:04 p.m.)
Review request for mesos, Niklas Nielsen and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29606/
---
(Updated Jan. 5, 2015, 7:04 p.m.)
Review request for mesos, Niklas Nielsen and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29607/
---
(Updated Jan. 5, 2015, 7:05 p.m.)
Review request for mesos, Niklas Nielsen and
On Jan. 2, 2015, 10:23 p.m., Ben Mahler wrote:
What happened previously if a launch takes forever?
What happens now if a launch takes forever?
Timothy Chen wrote:
Ben that's a good point, previously the registration timeout gates the
launch not to take forever, however it is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29121/#review66757
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 6, 2015, 12:27 a.m.,
On Jan. 2, 2015, 10:23 p.m., Ben Mahler wrote:
What happened previously if a launch takes forever?
What happens now if a launch takes forever?
Timothy Chen wrote:
Ben that's a good point, previously the registration timeout gates the
launch not to take forever, however it is
On Jan. 6, 2015, 12:49 a.m., Dominic Hamon wrote:
Ship It!
Nice catch! Actually a lot of frameworks needs to be updated as well. I think
we should email the dev list to notify them.
- Timothy
---
This is an automatically generated
On Jan. 2, 2015, 7:52 p.m., Timothy Chen wrote:
src/tests/environment.cpp, line 241
https://reviews.apache.org/r/29121/diff/1/?file=793313#file793313line241
Does it mean we should just disable any test with MultipleSlaves
(return true)?
You are right. I was thinking if
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29121/
---
(Updated Jan. 6, 2015, 12:27 a.m.)
Review request for mesos, Ben Mahler, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29610/#review66762
---
Ship it!
Ship It!
- Dominic Hamon
On Jan. 5, 2015, 4:20 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29602/#review66760
---
Patch looks great!
Reviews applied: [29595, 29596, 29597, 29598,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29497/#review66749
---
Ship it!
Ship It!
- Ben Mahler
On Dec. 31, 2014, 12:02 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29033/
---
(Updated Jan. 6, 2015, 12:01 a.m.)
Review request for mesos, Dominic Hamon,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29556/#review66753
---
Patch looks great!
Reviews applied: [29556]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29535/#review66754
---
Ship it!
3rdparty/libprocess/include/process/future.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29610/
---
Review request for mesos.
Repository: mesos-git
Description
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29380/
---
(Updated Jan. 6, 2015, 12:45 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29033/#review66769
---
Patch looks great!
Reviews applied: [29033]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29606/#review66770
---
Bad patch!
Reviews applied: [29603]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29603/
---
(Updated Jan. 5, 2015, 9:17 p.m.)
Review request for mesos, Niklas Nielsen and
+1 to hangouts, but I think hangouts has a limit of max 10 people in the
hangout.
On Mon, Jan 5, 2015 at 4:52 PM, Tom Arnfeld t...@duedil.com wrote:
+1 also! Very interesting to hear what’s being discussed. +1 on the google
hangouts if these meetings are happening in person so we can listen
I'm a big fan of this idea, thanks Niklas for proposing it!
On Mon, Jan 5, 2015 at 6:27 PM, Arunabha Ghosh arunabha...@gmail.com
wrote:
+1 to hangouts, but I think hangouts has a limit of max 10 people in the
hangout.
On Mon, Jan 5, 2015 at 4:52 PM, Tom Arnfeld t...@duedil.com wrote:
+1
On Dec. 23, 2014, 4:45 p.m., Adam B wrote:
include/mesos/mesos.proto, lines 436-437
https://reviews.apache.org/r/29274/diff/1/?file=797605#file797605line436
So, `Resource` contains an `Operation` which contains repeated
`Resource`s? But there is no actual Operation field on
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29380/#review66781
---
Patch looks great!
Reviews applied: [29274, 29380]
All tests
On Jan. 5, 2015, 5:53 a.m., Adam B wrote:
src/master/master.cpp, line 3728
https://reviews.apache.org/r/29556/diff/1/?file=806034#file806034line3728
Not your problem, but I think it'd be nice if task reconciliation also
informed the scheduler of a non-pending task's executorId.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29556/#review66790
---
Patch looks great!
Reviews applied: [29556]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29121/#review66780
---
Patch looks great!
Reviews applied: [29121]
All tests passed.
-
On Jan. 3, 2015, 7:57 a.m., Timothy Chen wrote:
are you planning to write a test or uodate anexisting one?
Connor Doyle wrote:
Yes definitely, tests are forthcoming. Will add to or modify
`src/tests/reconciliation_tests.cpp`.
Stefan Schimanski wrote:
A very simple test:
FYI: Mesosphere will be submitting a talk or two, but it'd be good to get
the rest of the community involved too!
-- Forwarded message --
From: Rich Bowen rbo...@rcbowen.com
Date: Mon, Jan 5, 2015 at 9:40 AM
Subject: ApacheCon North America 2015 Call For Papers
To: dev
On Jan. 2, 2015, 10:23 p.m., Ben Mahler wrote:
What happened previously if a launch takes forever?
What happens now if a launch takes forever?
Timothy Chen wrote:
Ben that's a good point, previously the registration timeout gates the
launch not to take forever, however it is
On Jan. 5, 2015, 5:53 a.m., Adam B wrote:
src/master/master.cpp, lines 3711-3718
https://reviews.apache.org/r/29556/diff/1/?file=806034#file806034line3711
Since this code appears twice, it's probably worth pulling out into a
function. Could be a method on Task, or a free-standing
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29556/
---
(Updated Jan. 6, 2015, 5:29 a.m.)
Review request for mesos, Adam B and Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29556/
---
(Updated Jan. 6, 2015, 6:13 a.m.)
Review request for mesos, Adam B and Timothy
On Dec. 24, 2014, 12:45 a.m., Adam B wrote:
I'm not sure I buy into the before/after Operation style. Is there any
previous discussion of alternatives (in a JIRA)?
Adam, unfortunately, there is no specific JIRA for this. However, we can
discuss the API in this ticket
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29033/#review9
---
src/slave/containerizer/isolators/network/port_mapping.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29528/#review66671
---
3rdparty/libprocess/include/process/socket.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29532/#review66672
---
Ship it!
Ship It!
- Dominic Hamon
On Jan. 1, 2015, 8:46 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29540/#review66674
---
3rdparty/libprocess/include/process/address.hpp
On Dec. 24, 2014, 12:45 a.m., Adam B wrote:
include/mesos/mesos.proto, lines 435-437
https://reviews.apache.org/r/29274/diff/1/?file=797605#file797605line435
Is there going to have to be complex verification? What happens if I
specify a non-disk resource in before but not after,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29533/#review66673
---
3rdparty/libprocess/3rdparty/stout/include/stout/url.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28218/#review66670
---
Ship it!
Sorry about the delay, Tim! Please update it and get it
On Jan. 5, 2015, 7:47 p.m., Jie Yu wrote:
I've already committed a fix. But thanks anyway!
commit a54a7f629447023e4fdcbcc188188012f9ed20a6
Author: Jie Yu yujie@gmail.com
Date: Mon Jan 5 11:15:20 2015 -0800
Fixed the broken build caused by Fetcher.
Thanks!
- Chi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29274/
---
(Updated Jan. 5, 2015, 8:16 p.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29274/
---
(Updated Jan. 5, 2015, 8:17 p.m.)
Review request for mesos, Adam B, Benjamin
It's only flaky from what I can tell (based on the CI emails), usually I'll
look at the log on Jenkins to see if there are any indications of why it
failed. Seems like we lost the test logs at this point unfortunately.
Have you tried running it with a lot of repetitions?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29473/#review66716
---
Patch looks great!
Reviews applied: [29473]
All tests passed.
-
On Jan. 5, 2015, 5:18 p.m., Dominic Hamon wrote:
Nice idea, but you can already do this using make check GTEST_FILTER=''.
I'm unsure of the benefit of the extra overhead to enable another way to do
the same thing.
Not much code, there is runtime / developer slow down overhead in
On Jan. 5, 2015, 12:18 p.m., Dominic Hamon wrote:
Nice idea, but you can already do this using make check GTEST_FILTER=''.
I'm unsure of the benefit of the extra overhead to enable another way to do
the same thing.
Cody Maloney wrote:
Not much code, there is runtime / developer
On Jan. 5, 2015, 11:57 a.m., Cody Maloney wrote:
Did you make sure that the stout tests are built as well as the librocess
tests with testing?
The changes look visually good, I haven't verified locally they work yet
though.
Yes, it does the correct thing and I verified it locally.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29473/
---
(Updated Jan. 5, 2015, 11:43 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29589/
---
Review request for mesos, Benjamin Hindman and Bernd Mathiske.
Bugs:
1 - 100 of 103 matches
Mail list logo
