---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29796/#review68069
---
Ship it!
Ship It!
- Jie Yu
On Jan. 14, 2015, 6:44 p.m., Ben
On Jan. 13, 2015, 11:29 p.m., Vinod Kone wrote:
src/master/master.cpp, line 1337
https://reviews.apache.org/r/29869/diff/1/?file=820049#file820049line1337
We should consider using 'OneOf' protobuf type to get this check for
free.
On Jan. 13, 2015, 11:29 p.m., Vinod Kone wrote:
src/master/master.cpp, lines 1380-1381
https://reviews.apache.org/r/29869/diff/1/?file=820049#file820049line1380
Curious, why you want acceptOffers() call into this method instead of
the current way. I imagine each operation to be
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29892/#review68095
---
Ship it!
3rdparty/libprocess/include/process/collect.hpp
SASL_AUXPROP_AUTHZID: true
I0114 09:10:09.465319 6560 master.cpp:779] Framework
20150114-090950-3125920579-36524-6540- (default) at
scheduler-19ff2d50-13b4-4fa7-bdf5-24b6390ef737@67.195.81.186:36524
disconnected
I0114 09:10:09.570647 6555 auxprop.cpp:121] Skipping auxiliary property
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29895/
---
Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29496/
---
(Updated Jan. 14, 2015, 4:22 p.m.)
Review request for mesos and Niklas
-principal' realm: 'penates.apache.org' server FQDN: '
penates.apache.org' SASL_AUXPROP_VERIFY_AGAINST_HASH: false
SASL_AUXPROP_OVERRIDE: false SASL_AUXPROP_AUTHZID: true
I0114 09:10:09.465319 6560 master.cpp:779] Framework
20150114-090950-3125920579-36524-6540- (default) at
scheduler-19ff2d50
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29688/#review68113
---
Ship it!
src/slave/containerizer/isolators/posix/disk.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29742/
---
(Updated Jan. 14, 2015, 6:55 p.m.)
Review request for mesos, Adam B, Benjamin
On Jan. 14, 2015, 10:09 a.m., Adam B wrote:
Were you able to reproduce the issue without your changes and prove that it
was fixed with your changes, or are you guessing here?
Pasting in Till's summary of the problem:
After some investigation, it turns out that my two-fold solution had a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29887/#review68090
---
What is the bug here? Mind adding it to the description?
- Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29688/
---
(Updated Jan. 14, 2015, 8:28 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29869/#review68067
---
src/master/master.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29892/
---
Review request for mesos and Ben Mahler.
Repository: mesos-git
Description
On Jan. 12, 2015, 11:34 p.m., Ben Mahler wrote:
Could you pause the clock in these tests? That might help you test that the
interval is respected (if you want to add a test for that).
Added a TODO. Pausing the clock is problematic for subprocess related tests.
- Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29869/
---
(Updated Jan. 14, 2015, 7:36 p.m.)
Review request for mesos, Jie Yu, Michael
On Jan. 14, 2015, 5:43 p.m., Alexander Rukletsov wrote:
src/authentication/cram_md5/authenticator.hpp, line 465
https://reviews.apache.org/r/29887/diff/1/?file=821508#file821508line465
Shouldn't this check be under the critical section? Since it's not a
libprocess process, there
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2387/changes
Changes:
[tnachen] Clarify slave log about disk usage.
[benjamin.mahler] Added initial Call handler in the Master for accepting offers.
[benjamin.mahler] Added initial operational guide to document
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29891/
---
(Updated Jan. 14, 2015, 6:59 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29891/
---
Review request for mesos, Benjamin Hindman and Vinod Kone.
Repository:
On Jan. 14, 2015, 6:09 p.m., Adam B wrote:
Were you able to reproduce the issue without your changes and prove that it
was fixed with your changes, or are you guessing here?
Adam B wrote:
Pasting in Till's summary of the problem:
After some investigation, it turns out that my
On Jan. 13, 2015, 11:29 p.m., Vinod Kone wrote:
src/master/master.cpp, lines 1380-1381
https://reviews.apache.org/r/29869/diff/1/?file=820049#file820049line1380
Curious, why you want acceptOffers() call into this method instead of
the current way. I imagine each operation to be
On Jan. 14, 2015, 8:30 p.m., Vinod Kone wrote:
src/slave/containerizer/isolators/posix/disk.cpp, line 270
https://reviews.apache.org/r/29688/diff/5/?file=821578#file821578line270
Are you planning to implement this soon? Without this it is hard to
know the disk usage of the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29896/
---
Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29891/#review68080
---
Ship it!
Ship It!
- Vinod Kone
On Jan. 14, 2015, 6:59 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29690/
---
(Updated Jan. 14, 2015, 7:29 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29690/#review68086
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 14, 2015, 7:29 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29890/#review68108
---
Patch looks great!
Reviews applied: [29890]
All tests passed.
-
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2668/changes
Changes:
[tnachen] Clarify slave log about disk usage.
[benjamin.mahler] Added initial Call handler in the Master for accepting offers.
[benjamin.mahler] Added initial
On Jan. 14, 2015, 5:51 a.m., Jie Yu wrote:
src/master/master.cpp, line 1318
https://reviews.apache.org/r/29869/diff/2/?file=820333#file820333line1318
Any reason keeps the scheduler:: namespace prefix?
It seems nice to differentiate `scheduler::Call` from `executor::Call` (which
On Jan. 13, 2015, 11:25 a.m., Timothy Chen wrote:
src/launcher/fetcher.cpp, line 285
https://reviews.apache.org/r/29809/diff/2/?file=818721#file818721line285
So I think the reason I think the method looks like it needed to be
refactored, it's just that it seems very cluttered
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29688/
---
(Updated Jan. 14, 2015, 7:27 p.m.)
Review request for mesos, Benjamin Hindman,
A limited number of early-bird tickets are now available for #MesosCon 2015
http://mesoscon.org, an annual conference organized by the Apache Mesos
community. MesosCon brings together users and developers to share and learn
about the project and its growing ecosystem, and will take place in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29896/#review68126
---
Patch looks great!
Reviews applied: [29892, 29815, 29687, 29688,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29890/
---
Review request for mesos, Bernd Mathiske and Niklas Nielsen.
Bugs: MESOS-2213
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29891/
---
(Updated Jan. 14, 2015, 6:59 p.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29869/#review68081
---
Ship it!
Ship It!
- Vinod Kone
On Jan. 14, 2015, 1:25 a.m., Ben
On Jan. 14, 2015, 5:43 p.m., Alexander Rukletsov wrote:
src/authentication/cram_md5/authenticator.hpp, line 465
https://reviews.apache.org/r/29887/diff/1/?file=821508#file821508line465
Shouldn't this check be under the critical section? Since it's not a
libprocess process, there
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29887/#review68130
---
Ship it!
Ship It!
- Adam B
On Jan. 14, 2015, 1:58 p.m., Till
On Jan. 14, 2015, 10:10 p.m., Ben Mahler wrote:
src/authentication/cram_md5/authenticator.hpp, lines 465-480
https://reviews.apache.org/r/29887/diff/2/?file=821731#file821731line465
What is this fixing? It looks like `initialized` will already gate this
block of code from being
On Jan. 14, 2015, 2:09 a.m., Ben Mahler wrote:
src/sched/sched.cpp, line 964
https://reviews.apache.org/r/29870/diff/1/?file=820062#file820062line964
_pure_ language schedulers
Fixed.
On Jan. 14, 2015, 2:09 a.m., Ben Mahler wrote:
src/sched/sched.cpp, line 1026
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2670/changes
Changes:
[yujie.jay] Supported accept offers in C++ scheduler driver.
--
[...truncated 292328 lines...]
I0115 00:10:59.044044
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29906/
---
Review request for mesos.
Bugs: MESOS-2219
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29904/
---
Review request for mesos and Ben Mahler.
Bugs: MESOS-2219
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29887/
---
(Updated Jan. 14, 2015, 10:18 p.m.)
Review request for mesos and Adam B.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29887/#review68148
---
src/authentication/cram_md5/authenticator.hpp
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2669/changes
Changes:
[benjamin.mahler] Removed the torque / MPI document.
--
[...truncated 148401 lines...]
I0114 22:01:44.430701 1719
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29887/#review68134
---
src/authentication/cram_md5/authenticator.hpp
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2388/changes
Changes:
[benjamin.mahler] Removed the torque / MPI document.
--
[...truncated 171300 lines...]
I0114 22:21:26.443619 10025 auxprop.cpp:121] Skipping auxiliary
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29887/#review68144
---
src/authentication/cram_md5/auxprop.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29890/#review68160
---
Very nice refactor, Alex!
RR comment: This patch touches quite a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29903/
---
Review request for mesos and Ben Mahler.
Bugs: MESOS-2219
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29905/
---
Review request for mesos and Ben Mahler.
Bugs: MESOS-2219
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29887/
---
(Updated Jan. 14, 2015, 9:58 p.m.)
Review request for mesos and Adam B.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29887/
---
(Updated Jan. 14, 2015, 10:50 p.m.)
Review request for mesos and Adam B.
On Jan. 14, 2015, 10:21 p.m., Vinod Kone wrote:
src/authentication/cram_md5/auxprop.cpp, lines 33-35
https://reviews.apache.org/r/29887/diff/4/?file=821796#file821796line33
Isn't the bug here that there *are* multiple masters/authenticators
running at the same time (in tests)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29887/#review68161
---
src/authentication/cram_md5/authenticator.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29887/#review68159
---
Patch looks great!
Reviews applied: [29887]
All tests passed.
-
On Jan. 14, 2015, 11:19 p.m., Vinod Kone wrote:
src/authentication/cram_md5/authenticator.hpp, lines 465-480
https://reviews.apache.org/r/29887/diff/2/?file=821731#file821731line465
I think it's simpler to use 'Once'?
```
static process::Once* auxpropInitialize =
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2671/changes
On Jan. 14, 2015, 5:43 p.m., Alexander Rukletsov wrote:
src/authentication/cram_md5/authenticator.hpp, line 465
https://reviews.apache.org/r/29887/diff/1/?file=821508#file821508line465
Shouldn't this check be under the critical section? Since it's not a
libprocess process, there
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2389/changes
Changes:
[yujie.jay] Supported accept offers in C++ scheduler driver.
--
[...truncated 128408 lines...]
I0114 23:59:11.950073 19114 auxprop.cpp:121] Skipping
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29887/
---
(Updated Jan. 14, 2015, 10:09 p.m.)
Review request for mesos and Adam B.
On Jan. 14, 2015, 2:10 p.m., Ben Mahler wrote:
src/authentication/cram_md5/authenticator.hpp, lines 465-480
https://reviews.apache.org/r/29887/diff/2/?file=821731#file821731line465
What is this fixing? It looks like `initialized` will already gate this
block of code from being
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2390/changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28697/
---
(Updated Jan. 15, 2015, 2:10 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29913/
---
(Updated Jan. 15, 2015, 5:19 a.m.)
Review request for mesos.
Summary
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29918/
---
(Updated Jan. 15, 2015, 5:19 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29913/
---
(Updated Jan. 15, 2015, 5:19 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29913/#review68206
---
Bad patch!
Reviews applied: [28697, 29911, 29742, 29730, 28562,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29903/#review68197
---
Ship it!
Ship It!
- Kapil Arya
On Jan. 14, 2015, 7:55 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29918/#review68205
---
src/slave/slave.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29913/
---
(Updated Jan. 15, 2015, 5:03 a.m.)
Review request for mesos.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29913/#review68190
---
src/slave/slave.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29887/
---
(Updated Jan. 15, 2015, 3:55 a.m.)
Review request for mesos and Adam B.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29887/#review68201
---
Bad patch!
Reviews applied: [29887]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29918/#review68208
---
Bad patch!
Reviews applied: [29730, 28562, 28608, 29179, 28720,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29913/#review68189
---
Bad patch!
Reviews applied: [29911, 29742, 29274, 29380]
Failed
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29913/
---
Review request for mesos.
Repository: mesos-git
Description
---
Added
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29887/
---
(Updated Jan. 15, 2015, 3:57 a.m.)
Review request for mesos, Adam B, Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29904/#review68217
---
Ship it!
src/slave/main.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29905/#review68218
---
Ship it!
Ship It!
- Alexander Rukletsov
On Jan. 15, 2015, 12:55
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29903/#review68216
---
Ship it!
src/slave/monitor.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29911/
---
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29918/
---
Review request for mesos.
Repository: mesos-git
Description
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29887/#review68061
---
Were you able to reproduce the issue without your changes and prove
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29887/
---
Review request for mesos and Adam B.
Bugs: MESOS-2050
' SASL_AUXPROP_VERIFY_AGAINST_HASH: false
SASL_AUXPROP_OVERRIDE: false SASL_AUXPROP_AUTHZID: true
I0114 09:10:09.465319 6560 master.cpp:779] Framework
20150114-090950-3125920579-36524-6540- (default) at
scheduler-19ff2d50-13b4-4fa7-bdf5-24b6390ef737@67.195.81.186:36524
disconnected
I0114 09:10:09.570647 6555
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29887/#review68058
---
src/authentication/cram_md5/authenticator.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29887/#review68063
---
Patch looks great!
Reviews applied: [29887]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29889/
---
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29889/#review68064
---
can you use the 'depends on' to avoid containing other RBs?
-
On Jan. 14, 2015, 6:38 p.m., Dominic Hamon wrote:
can you use the 'depends on' to avoid containing other RBs?
This review is not meant to be merged, sorry probably should have put this on
the description.
Since my changes spans lots of reviews, it's easier to have one diff to see
On Jan. 11, 2015, 1:42 a.m., Jie Yu wrote:
docs/operational-guide.md, line 34
https://reviews.apache.org/r/29796/diff/1/?file=816101#file816101line34
Maybe we should also say something about cases like:
if changing from 7 masters to 3 masters are safe or not?
Commented
On Jan. 12, 2015, 11:11 p.m., Ben Mahler wrote:
Should there be a flag in here to make the enforcement optional for those
that need to incrementally turn this on?
Will do it in a following patch.
On Jan. 12, 2015, 11:11 p.m., Ben Mahler wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29796/
---
(Updated Jan. 14, 2015, 6:44 p.m.)
Review request for mesos and Jie Yu.
On Dec. 19, 2014, 5:17 p.m., Adam B wrote:
LGTM. What's the motivation for this change?
Alexander Rukletsov wrote:
Limit the scope of allocator-related includes. With allocator modules
coming soon, allocator tests will require at least modules API and allocator
modules.
commit
On Jan. 13, 2015, 7:55 a.m., Alexander Rukletsov wrote:
src/slave/containerizer/fetcher.cpp, lines 186-187
https://reviews.apache.org/r/29560/diff/3/?file=808632#file808632line186
`fetcher_cache_dir` is not optional, while `cache_directory` is. Maybe
we should consider making the
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2386/changes
Changes:
[adam] Revised authenticator interface to allow for two fold implementations.
[adam] Moved allocator specific declaration into allocator tests.
--
1 - 100 of 105 matches
Mail list logo
