---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28775/
---
(Updated Jan. 28, 2015, 10:55 a.m.)
Review request for mesos.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30037/
---
(Updated Jan. 28, 2015, 12:54 a.m.)
Review request for mesos, Adam B, Benjamin
On Jan. 28, 2015, 2:47 a.m., Adam B wrote:
src/slave/containerizer/fetcher.hpp, line 98
https://reviews.apache.org/r/30037/diff/8/?file=833520#file833520line98
This generates a unique pid, in case of multiple simultaneous fetchers?
Each slave has its own fetcher, so we need unique
On Jan. 23, 2015, 5:01 p.m., Adam B wrote:
include/mesos/fetcher/fetcher.proto, line 62
https://reviews.apache.org/r/30037/diff/6/?file=829684#file829684line62
Where did this go?
Bernd Mathiske wrote:
Turns out the env var HADOOP_HOME from which this was a carry-over is not
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30361/
---
Review request for mesos.
Repository: mesos-git
Description
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30361/
---
(Updated Jan. 28, 2015, 9:36 a.m.)
Review request for mesos.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29727/#review69976
---
Made another pass over the DiscoveryInfo changes and found a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29856/
---
Review request for mesos.
Summary (updated)
-
Implemented
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29736/#review69985
---
Patch looks great!
Reviews applied: [29742, 28697, 28698, 29736]
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29742/
---
(Updated Jan. 28, 2015, 9:21 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29742/
---
(Updated Jan. 28, 2015, 9:21 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28698/
---
(Updated Jan. 28, 2015, 9:21 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29748/
---
(Updated Jan. 28, 2015, 9:27 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28775/
---
Review request for mesos.
Summary (updated)
-
Fixed task
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28775/
---
(Updated Jan. 28, 2015, 9:37 a.m.)
Review request for mesos.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29748/
---
(Updated Jan. 28, 2015, 9:37 a.m.)
Review request for mesos, Adam B, Benjamin
On Jan. 23, 2015, 5:01 p.m., Adam B wrote:
include/mesos/fetcher/fetcher.proto, lines 44-45
https://reviews.apache.org/r/30037/diff/6/?file=829684#file829684line44
How does this fail for an item not present in the cache? Why wouldn't
you just want to check for presence in the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29736/
---
Review request for mesos.
Summary (updated)
-
Update the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29736/
---
(Updated Jan. 28, 2015, 9:31 a.m.)
Review request for mesos.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27760/#review69997
---
Ship it!
I think this is ready to commit now.
@vinodkone,
See https://builds.apache.org/job/mesos-reviewbot/3751/
--
[...truncated 5505 lines...]
rm -rf logging/.libs logging/_libs
rm -rf master/.libs master/_libs
rm -rf messages/.libs messages/_libs
rm -rf module/.libs module/_libs
rm -rf sched/.libs sched/_libs
See https://builds.apache.org/job/mesos-reviewbot/3752/
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30361/
---
(Updated Jan. 28, 2015, 9:36 a.m.)
Review request for mesos.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30361/
---
(Updated Jan. 28, 2015, 9:35 a.m.)
Review request for mesos.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30037/#review69973
---
Lots of feedback. Thanks for your patience.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29925/
---
(Updated Jan. 28, 2015, 5:28 p.m.)
Review request for mesos, Bernd Mathiske
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29927/
---
(Updated Jan. 28, 2015, 5:29 p.m.)
Review request for mesos, Bernd Mathiske
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29931/
---
(Updated Jan. 28, 2015, 5:31 p.m.)
Review request for mesos, Bernd Mathiske
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30082/
---
(Updated Jan. 28, 2015, 5:32 p.m.)
Review request for mesos, Bernd Mathiske
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30037/
---
(Updated Jan. 28, 2015, 9:33 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29932/
---
(Updated Jan. 28, 2015, 5:32 p.m.)
Review request for mesos, Bernd Mathiske
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27760/#review70051
---
Can you expand description on why you designed the authenticator
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30297/#review70074
---
Ship it!
3rdparty/libprocess/src/tests/limiter_tests.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28775/#review70077
---
Bad patch!
Reviews applied: [29742, 28697, 28698, 29736, 29856,
On Jan. 28, 2015, 8:07 p.m., Jie Yu wrote:
Overall, looks good! Instead of adding a test in master allocation tests,
could you please instead kill this TODO in resource offer tests:
```
// TODO(benh): Add tests which launch multiple tasks and check for
// aggregate resource usage.
But in that case, since almost all of them are pure functors (don't keep a
state), I think using values is more efficient than keeping pointers to
instances, since it will allow the compiler to create more optimisations on
them (and again, this only holds on stateless functors).
On Wed, Jan 28,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29288/
---
(Updated Jan. 28, 2015, 8:14 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29890/
---
(Updated Jan. 28, 2015, 9:50 p.m.)
Review request for mesos, Bernd Mathiske,
On Jan. 28, 2015, 6:51 p.m., Dominic Hamon wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 400
https://reviews.apache.org/r/29288/diff/13/?file=838809#file838809line400
please drop the :
explicit InternetAddress(const ...)
:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29288/
---
(Updated Jan. 28, 2015, 8:27 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28775/
---
(Updated Jan. 28, 2015, 8:34 p.m.)
Review request for mesos.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28781/#review70105
---
Mind pulling out the operation / validation changes into a separate
On Jan. 27, 2015, 8:14 p.m., Joris Van Remoortere wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 1030
https://reviews.apache.org/r/29288/diff/10/?file=836987#file836987line1030
Might be worth pulling this out as a constant?
Evelina Dumitrescu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30192/#review70073
---
Ship it!
Ship It!
- Jie Yu
On Jan. 28, 2015, 1:36 a.m., Vinod
On Jan. 19, 2015, 2:27 p.m., Alexander Rukletsov wrote:
src/tests/master_allocator_tests.cpp, lines 235-236
https://reviews.apache.org/r/29991/diff/1/?file=824066#file824066line235
What is the reason to leave this expectation? I think it's covered by
the new code in /r/29990.
On Jan. 20, 2015, 8:45 p.m., Jie Yu wrote:
I guess any expection that involves ```.Times``` shouldn't be removed? And
we should remove ```WillRepeatedly(DoDefault())``` whenever possible?
See my comments above, let me know what you think.
On Jan. 20, 2015, 8:45 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28781/
---
(Updated Jan. 29, 2015, 12:11 a.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/#review70104
---
Patch looks great!
Reviews applied: [29288, 29289, 29290]
All
On Jan. 20, 2015, 8:22 p.m., Jie Yu wrote:
src/tests/mesos.hpp, lines 686-688
https://reviews.apache.org/r/29990/diff/1/?file=824065#file824065line686
Can we pull these to the top of this file?
Yep, done.
- Ben
---
This is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28775/
---
(Updated Jan. 28, 2015, 11:57 p.m.)
Review request for mesos.
Repository:
On Dec. 19, 2014, 2:05 a.m., Adam B wrote:
src/common/resources.cpp, line 492
https://reviews.apache.org/r/28698/diff/2/?file=793362#file793362line492
Is CHECK appropriate here, or should we instead return a TryResources?
Michael Park wrote:
I think returning a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28775/#review70116
---
Bad patch!
Reviews applied: [28697, 28698, 28697]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30349/
---
(Updated Jan. 29, 2015, 12:13 a.m.)
Review request for mesos, Ben Mahler,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30386/
---
Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30349/#review70120
---
Bad patch!
Reviews applied: [30283, 30298, 28781, 30386]
Failed
On Jan. 27, 2015, 7:55 p.m., Ben Mahler wrote:
src/tests/master_allocator_tests.cpp, lines 80-81
https://reviews.apache.org/r/29927/diff/3/?file=836337#file836337line80
Can we be very explicit here about why we need this, and what is
causing the flakiness? How does this relate to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29288/
---
(Updated Jan. 28, 2015, 3:58 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
---
(Updated Jan. 28, 2015, 10:04 p.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
---
(Updated Jan. 28, 2015, 10:04 p.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30348/#review70100
---
Ship it!
3rdparty/libprocess/include/process/future.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30192/#review70101
---
3rdparty/libprocess/src/tests/limiter_tests.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29288/
---
(Updated Jan. 28, 2015, 9:57 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30283/#review70090
---
Ship it!
src/master/master.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30297/
---
(Updated Jan. 28, 2015, 10 p.m.)
Review request for mesos and Jie Yu.
On Jan. 27, 2015, 3:41 a.m., Joris Van Remoortere wrote:
3rdparty/libprocess/include/process/socket.hpp, lines 127-129
https://reviews.apache.org/r/29289/diff/9/?file=834358#file834358line127
Would it make sense to provide a constructor in net::IP::InAddrStorage
that takes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29288/
---
(Updated Jan. 28, 2015, 10:05 p.m.)
Review request for mesos, Benjamin
FYI We've seen some anonymous transitions of issues occurring lately, e.g.:
(look at the history)
https://issues.apache.org/jira/browse/MESOS-1554
https://issues.apache.org/jira/browse/MESOS-2031
I filed https://issues.apache.org/jira/browse/INFRA-9078 to update JIRA
permissions to restrict this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30297/#review70099
---
Patch looks great!
Reviews applied: [30348, 30191, 30192, 30297]
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30298/#review70103
---
Ship it!
Thanks Jie, we probably want to consider moving towards
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30348/
---
(Updated Jan. 28, 2015, 10 p.m.)
Review request for mesos, Benjamin Hindman,
On Jan. 28, 2015, 8:14 p.m., Jie Yu wrote:
3rdparty/libprocess/include/process/future.hpp, line 1103
https://reviews.apache.org/r/30348/diff/1/?file=837828#file837828line1103
This will race with clearAllCallbacks if one thread is calling
f.discard() and another thread is
Sorry, in what case? Are you referring to using values with what we have
today (pre-C++11 inheritance-style functors)...?
On Wed, Jan 28, 2015 at 1:12 PM, Alexander Rojas alexan...@mesosphere.io
wrote:
But in that case, since almost all of them are pure functors (don't keep a
state), I think
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30348/#review70091
---
Ship it!
3rdparty/libprocess/include/process/future.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28781/#review70137
---
Looks good, just a quick question, can the implicit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29539/
---
(Updated Jan. 29, 2015, 2:09 a.m.)
Review request for mesos and Niklas
On Jan. 22, 2015, 9:14 p.m., Joris Van Remoortere wrote:
3rdparty/libprocess/include/process/network.hpp, line 61
https://reviews.apache.org/r/29527/diff/1/?file=805371#file805371line61
Failed to bind on: ?
We only concatenate with ':' when we're adding another error message. In
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30394/
---
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-1806
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30395/
---
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-1806
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30393/
---
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-1806
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30398/
---
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-1806
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30397/
---
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-1806
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30396/
---
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-1806
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30398/#review70153
---
Bad patch!
Reviews applied: [30194, 30195, 29526, 29527]
Failed
On Jan. 27, 2015, 7:55 p.m., Ben Mahler wrote:
src/tests/master_allocator_tests.cpp, lines 80-81
https://reviews.apache.org/r/29927/diff/3/?file=836337#file836337line80
Can we be very explicit here about why we need this, and what is
causing the flakiness? How does this relate to
On Jan. 22, 2015, 9:29 p.m., Niklas Nielsen wrote:
To Tim's point - I don't see 'EtcdMasterContenderProcess' in the source
base or in the patch chain?
Otherwise, looks good but again, we need consensus on the address (or at
least the naming) change.
I neglected to push the update
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29539/#review70140
---
Ship it!
Ship It!
- Niklas Nielsen
On Jan. 28, 2015, 6:09 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29538/#review70141
---
Ship it!
Ship It!
- Joris Van Remoortere
On Jan. 21, 2015, 5:49
On Jan. 28, 2015, 12:33 p.m., Vinod Kone wrote:
Can you expand description on why you designed the authenticator inteface
this way? Particularly, expand on The initial design and implementation of
the authenticator module interface caused issues and was not optimal for
heavy lifting
On Jan. 22, 2015, 1:23 p.m., Niklas Nielsen wrote:
LGTM but fundamentally, it seems like we do not have consensus on this
change. Awaiting feedback on the dev@ thread before giving ship-it
Think we have gotten to censensus on calling this Address and the IP::Address
for InternetAddress.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29538/#review70143
---
Ship it!
Modulus out-standing issues
- Niklas Nielsen
On Jan.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30402/
---
Review request for mesos, Alexander Rukletsov and Vinod Kone.
Bugs: MESOS-2228
On Jan. 20, 2015, 8:45 p.m., Jie Yu wrote:
src/tests/master_allocator_tests.cpp, lines 235-236
https://reviews.apache.org/r/29991/diff/1/?file=824066#file824066line235
Ditto Alexander's comments. Could you please do a search for
```WillRepeatedly(DoDefault())``` and make sure all
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29991/#review70158
---
Ship it!
Thanks for the cleanup! LGTM.
- Jie Yu
On Jan. 16,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30402/#review70157
---
Patch looks great!
Reviews applied: [30402]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29742/
---
(Updated Jan. 29, 2015, 5:24 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29736/
---
(Updated Jan. 29, 2015, 5:25 a.m.)
Review request for mesos.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29742/
---
(Updated Jan. 29, 2015, 5:27 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28698/
---
(Updated Jan. 29, 2015, 5:30 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30361/
---
(Updated Jan. 29, 2015, 5:36 a.m.)
Review request for mesos.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29748/
---
(Updated Jan. 29, 2015, 5:38 a.m.)
Review request for mesos, Adam B, Benjamin
1 - 100 of 143 matches
Mail list logo
