---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31362/
---
(Updated Feb. 25, 2015, 5:45 a.m.)
Review request for mesos, Adam B, Ben
On Feb. 25, 2015, 12:36 a.m., Adam B wrote:
Looks great, although potentially more verbose than necessary.
+1 on both comments. Let's get those fixed and land this :) I'll update the
changelog patch accordingly.
- Niklas
---
This
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774/#review74040
---
docs/fetcher.md
https://reviews.apache.org/r/30774/#comment120509
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31415/
---
Review request for mesos, Benjamin Hindman and Ben Mahler.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30850/
---
(Updated Feb. 25, 2015, 5:53 p.m.)
Review request for mesos, Ben Mahler,
On Feb. 25, 2015, 7:26 a.m., Timothy Chen wrote:
docs/fetcher.md, line 16
https://reviews.apache.org/r/30774/diff/17/?file=872869#file872869line16
The framework provides a list of CommandInfo::URI values as part of the
TaskInfo message that becomes the input to the Mesos fetcher.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31415/#review74041
---
Patch looks great!
Reviews applied: [31415]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31424/#review74071
---
Ship it!
src/tests/rate_limiting_tests.cpp
On Feb. 25, 2015, 7:08 p.m., Adam B wrote:
Minor markdown tweaks, but I'll fix those myself and commit this.
Adam B wrote:
Submitted.
Adam: Did you forget to mark this review as submitted?
- Ben
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31426/
---
Review request for mesos and Vinod Kone.
Repository: mesos
Description
On Feb. 25, 2015, 6:43 p.m., Ben Mahler wrote:
include/mesos/resources.hpp, lines 107-108
https://reviews.apache.org/r/30850/diff/3/?file=875892#file875892line107
Checkpointing seems like a mesos implementation detail, any reason you
want it in resources.hpp? What about creating
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31390/
---
(Updated Feb. 25, 2015, 11:16 a.m.)
Review request for mesos, Adam B, Connor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30510/#review74057
---
src/slave/containerizer/mesos/containerizer.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774/#review74069
---
Bad patch!
Reviews applied: [30609, 30606, 30774]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31424/
---
(Updated Feb. 25, 2015, 11:50 a.m.)
Review request for mesos and Vinod Kone.
Yes, but I'd really recommend starting with smaller contributions. Why
don't you see if you can tackle:
https://issues.apache.org/jira/browse/MESOS-2353 and we can go from there.
Sound good?
On Tue, Feb 24, 2015 at 11:35 PM, Atri Sharma atri.j...@gmail.com wrote:
Thanks.
So the idea is to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774/#review74043
---
src/slave/containerizer/fetcher.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31424/
---
Review request for mesos and Vinod Kone.
Repository: mesos
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31378/#review74046
---
Ship it!
src/Makefile.am
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31378/
---
(Updated Feb. 25, 2015, 6:37 p.m.)
Review request for mesos, Ian Downes and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31416/#review74052
---
Patch looks great!
Reviews applied: [31416]
All tests passed.
-
On Feb. 25, 2015, 11:08 a.m., Adam B wrote:
Minor markdown tweaks, but I'll fix those myself and commit this.
Submitted.
- Adam
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31378/#review74054
---
Ship it!
Ship It!
- Ian Downes
On Feb. 25, 2015, 10:37 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774/#review74053
---
src/slave/containerizer/fetcher.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774/#review74048
---
src/slave/containerizer/fetcher.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30850/#review74044
---
Ship it!
include/mesos/resources.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31390/#review74051
---
Ship it!
Minor markdown tweaks, but I'll fix those myself and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31426/#review74085
---
Ship it!
src/tests/utils.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30850/
---
(Updated Feb. 25, 2015, 8:48 p.m.)
Review request for mesos, Ben Mahler,
https://issues.apache.org/jira/browse/MESOS-2403
On Tue, Feb 24, 2015 at 3:24 PM, Apache Jenkins Server
jenk...@builds.apache.org wrote:
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2769/changes
Changes:
On Feb. 25, 2015, 11:08 a.m., Adam B wrote:
Minor markdown tweaks, but I'll fix those myself and commit this.
Adam B wrote:
Submitted.
Ben Mahler wrote:
Adam: Did you forget to mark this review as submitted?
Unfortunately, I don't have permission to mark others reviews as
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31426/#review74095
---
Patch looks great!
Reviews applied: [31426]
All tests passed.
-
Have you filed an INFRA ticket about that?
On Wed, Feb 25, 2015 at 12:46 PM, Adam B a...@mesosphere.io wrote:
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31390/
On February 25th, 2015, 11:08 a.m. PST, *Adam B* wrote:
Minor markdown tweaks,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31276/
---
(Updated Feb. 25, 2015, 9:53 p.m.)
Review request for mesos, Dominic Hamon,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31327/
---
(Updated Feb. 25, 2015, 1:56 p.m.)
Review request for mesos, Ben Mahler, Kapil
On Feb. 25, 2015, 12:24 a.m., Adam B wrote:
docs/configuration.md, line 164
https://reviews.apache.org/r/31327/diff/2/?file=874659#file874659line164
Did you mean `p/`?
Aha! I misread the existing paragraph tags. Thanks! Good catch
- Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31276/
---
(Updated Feb. 25, 2015, 9:59 p.m.)
Review request for mesos, Dominic Hamon,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31328/
---
(Updated Feb. 25, 2015, 1:58 p.m.)
Review request for mesos.
Summary
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30609/#review74026
---
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774/#review73462
---
This really is an impressive project Bernd, tipping my hat here!
I
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30958/
---
(Updated Feb. 25, 2015, 10:21 p.m.)
Review request for mesos, Jie Yu and Cong
On Feb. 24, 2015, 10:57 p.m., Timothy Chen wrote:
src/docker/docker.cpp, line 791
https://reviews.apache.org/r/31125/diff/2/?file=875320#file875320line791
This also assumes ID is the first column and the ID is always 10 width,
I thought this patch is going to not expect any
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31443/
---
Review request for mesos, Dominic Hamon and Jie Yu.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31441/
---
Review request for mesos, Dominic Hamon and Jie Yu.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31439/
---
Review request for mesos, Dominic Hamon and Jie Yu.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31440/
---
Review request for mesos, Dominic Hamon and Jie Yu.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31438/
---
Review request for mesos, Dominic Hamon and Jie Yu.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31442/
---
Review request for mesos, Dominic Hamon and Jie Yu.
Repository: mesos
On Feb. 23, 2015, 2:34 p.m., Till Toenshoff wrote:
src/slave/slave.cpp, line 176
https://reviews.apache.org/r/30931/diff/4/?file=863304#file863304line176
How about supporting Mesos local and possibly the test as well?
Joerg Schad wrote:
Is already automatially provided by
On Feb. 25, 2015, 7:30 p.m., Vinod Kone wrote:
src/slave/containerizer/mesos/containerizer.cpp, line 1246
https://reviews.apache.org/r/30510/diff/6/?file=872653#file872653line1246
CHECK(resource.disk().has_persistence()); ?
use the new 'persistentVolumes()' method introduced by
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31444/#review74125
---
src/slave/containerizer/mesos/launch.hpp
On Feb. 24, 2015, 12:02 a.m., Ben Mahler wrote:
src/slave/slave.cpp, lines 3633-3678
https://reviews.apache.org/r/30014/diff/3/?file=830489#file830489line3633
I don't think this is the right approach, as you're re-ordering garbage
collections by changing the delay here.
On Feb. 23, 2015, 3:52 p.m., Ben Mahler wrote:
CHANGELOG, line 94
https://reviews.apache.org/r/31324/diff/2/?file=873193#file873193line94
Do you want a top-level bullet about this one? Seems like a major
addition. Is it ready for frameworks to use? Is there any user
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31455/
---
Review request for mesos, Dominic Hamon, Evelina Dumitrescu, and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31324/#review74192
---
Patch looks great!
Reviews applied: [31324]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31473/#review74232
---
Patch looks great!
Reviews applied: [31470, 31471, 29288, 29289,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30510/
---
(Updated Feb. 25, 2015, 10:41 p.m.)
Review request for mesos, Ben Mahler, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31446/
---
(Updated Feb. 25, 2015, 3:30 p.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31446/
---
Review request for mesos and Vinod Kone.
Bugs: mesos-1830
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31438/#review74114
---
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp
On Feb. 25, 2015, 3:17 p.m., Jie Yu wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, lines 405-430
https://reviews.apache.org/r/31440/diff/1/?file=876471#file876471line405
Consider moving these to stout/stat.hpp and rename them to be:
os::stat::islink
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31441/#review74144
---
Ship it!
Ship It!
- Jie Yu
On Feb. 25, 2015, 10:31 p.m., Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27760/#review74158
---
Hey Till,
Can you rebase this? :)
- Niklas Nielsen
On Feb. 22,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30510/#review74166
---
Ship it!
Ship It!
- Vinod Kone
On Feb. 25, 2015, 10:41 p.m.,
On Feb. 25, 2015, 1:20 a.m., Adam B wrote:
CHANGELOG, lines 40-41
https://reviews.apache.org/r/31324/diff/4/?file=874690#file874690line40
No need for double-blank line here. We usually reserve those for
between releases.
Ah - great point.
On Feb. 25, 2015, 1:20 a.m., Adam B
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31443/#review74116
---
src/linux/fs.cpp
https://reviews.apache.org/r/31443/#comment120637
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31276/#review74139
---
Patch looks great!
Reviews applied: [31008, 30545, 31276]
All
Found another segfault issue
https://issues.apache.org/jira/browse/MESOS-2407
On Tue, Feb 24, 2015 at 10:05 AM, Niklas Nielsen nik...@mesosphere.io
wrote:
Sure can.
How have you tracked them previously?
I created a doc where we can track the commits (taken there isn't a
template or git
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31439/#review74124
---
Ship it!
Ship It!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31439/#review74135
---
Ship it!
Ship It!
- Jie Yu
On Feb. 25, 2015, 10:31 p.m., Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774/#review74155
---
src/slave/containerizer/fetcher.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31328/#review74112
---
Patch looks great!
Reviews applied: [31327, 31328]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31324/
---
(Updated Feb. 25, 2015, 5:03 p.m.)
Review request for mesos, Benjamin Hindman,
I'll take a look at, but someone who worked on that code base recently
(joris? benh?) might figure it out sooner than me.
On Wed, Feb 25, 2015 at 5:07 PM, Niklas Nielsen nik...@mesosphere.io
wrote:
Thanks Vinod! I created a placeholder for it in the document. Do you need
anyone to take a look
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31438/#review74115
---
Ship it!
Ship It!
- Dominic Hamon
On Feb. 25, 2015, 2:31 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31440/#review74121
---
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp
Sorry, that was in reply to Adam.
On Wed, Feb 25, 2015 at 2:33 PM, Christos Kozyrakis kozyr...@gmail.com
wrote:
If by INFRA you meant JIRA:
https://issues.apache.org/jira/browse/MESOS-2396
Otherwise, I am not sure what an INFRA ticket is.
On Wed, Feb 25, 2015 at 1:39 PM, Benjamin Mahler
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31442/#review74152
---
Ship it!
src/linux/fs.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30510/#review74165
---
Patch looks great!
Reviews applied: [30509, 30510]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31324/
---
(Updated Feb. 25, 2015, 4:32 p.m.)
Review request for mesos, Benjamin Hindman,
On Feb. 25, 2015, 10:20 p.m., Till Toenshoff wrote:
src/slave/containerizer/fetcher.cpp, lines 459-460
https://reviews.apache.org/r/30774/diff/18/?file=875547#file875547line459
So a force removes from cache -- can you explain why this is needed?
Ow I got it :) ... a force is a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31440/#review74141
---
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31442/#review74174
---
src/linux/fs.cpp
https://reviews.apache.org/r/31442/#comment120699
Thanks Vinod! I created a placeholder for it in the document. Do you need
anyone to take a look at it or do you know how to track it down?
Niklas
On 25 February 2015 at 16:55, Vinod Kone vinodk...@apache.org wrote:
Found another segfault issue
https://issues.apache.org/jira/browse/MESOS-2407
On Feb. 23, 2015, 2:11 p.m., Alexander Rojas wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, lines 366-368
https://reviews.apache.org/r/31246/diff/2/?file=871696#file871696line366
We are basically counting set bits here. Cannot we do better than
iterating over
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
---
(Updated Feb. 26, 2015, 6:44 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29288/
---
(Updated Feb. 26, 2015, 7:18 a.m.)
Review request for mesos, Dominic Hamon and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31472/
---
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
---
(Updated Feb. 26, 2015, 6:42 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29288/
---
(Updated Feb. 26, 2015, 6:42 a.m.)
Review request for mesos, Dominic Hamon and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31472/
---
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31473/
---
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31471/
---
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31470/
---
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774/
---
(Updated Feb. 25, 2015, 2:19 a.m.)
Review request for mesos, Adam B, Benjamin
On Feb. 25, 2015, 1:46 a.m., Adam B wrote:
src/tests/fetcher_tests.cpp, lines 731-733
https://reviews.apache.org/r/31362/diff/2/?file=875479#file875479line731
Looks like ReviewBot disagrees with this setup.
../../src/tests/fetcher_tests.cpp:720: Failure
Value of:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774/#review74010
---
Bad patch!
Reviews applied: [30609, 30606, 30774]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31362/#review74005
---
Ship it!
LGTM, as long as you can get ReviewBot to pass your
On Feb. 24, 2015, 11:26 p.m., Timothy Chen wrote:
docs/fetcher.md, line 16
https://reviews.apache.org/r/30774/diff/17/?file=872869#file872869line16
The framework provides a list of CommandInfo::URI values as part of the
TaskInfo message that becomes the input to the Mesos
On Feb. 23, 2015, 7:36 p.m., Alexander Rukletsov wrote:
src/master/allocator/sorter/sorter.hpp, lines 64-66
https://reviews.apache.org/r/31183/diff/2/?file=869986#file869986line64
Maybe we can provide overrides here to avoid duplicating `foreach`s in
the client code in
1 - 100 of 105 matches
Mail list logo
