See https://builds.apache.org/job/mesos-reviewbot/4587/
On March 10, 2015, 9:11 p.m., Niklas Nielsen wrote:
How about we try to make this look like the Containerizer factory-like
method (Containerizer::create)? That would be a bit more consistent
I think `Containerizer` is not a good example here. I would rather point to
`Authenticator` and /
See https://builds.apache.org/job/mesos-reviewbot/4590/changes
Changes:
[vinodkone] Print errno in process:childMain().
--
[...truncated 5563 lines...]
rm -rf module/.libs module/_libs
rm -rf sched/.libs sched/_libs
rm -rf scheduler/.libs scheduler/_libs
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32008/#review76405
---
Blanket LDADD will fail rpm checks because it will link all deps
See https://builds.apache.org/job/mesos-reviewbot/4591/
--
[...truncated 5604 lines...]
==
real11m26.003s
user64m49.931s
sys 4m53.314s
+ chmod -R +w 3rdparty aclocal.m4 ar-lib autom4te.cache bin
On Feb. 25, 2015, 3:04 p.m., Dominic Hamon wrote:
src/slave/containerizer/mesos/launch.cpp, line 371
https://reviews.apache.org/r/31444/diff/1/?file=876502#file876502line371
aside: why are we returning arbitrary integers instead of boolean or
useful errors?
That's the interface
The only way you can increase or decrease memory for an executor is by
launching/killing tasks. So you could presumably use no-op tasks to achieve
what you want.
On Fri, Mar 13, 2015 at 7:51 AM, haosdent haosd...@gmail.com wrote:
Hello, I write a redis service based on Mesos. And I have a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31986/#review76393
---
Patch looks great!
Reviews applied: [31985, 31986]
All tests
On March 10, 2015, 9:10 p.m., Niklas Nielsen wrote:
src/tests/mesos.hpp, line 770
https://reviews.apache.org/r/31263/diff/3/?file=886222#file886222line770
Do you want to have:
CHECK_NOTNULL(allocator-real)-initialize(arg0, arg1, arg2);
?
We do not
See https://builds.apache.org/job/mesos-reviewbot/4589/
On March 10, 2015, 9:10 p.m., Niklas Nielsen wrote:
Can you leave a comment about why you need it? (In terms of your following
refactorings will break if you don't do it)
As I mention in the description, once TestAllocator is not a template
(r/31263/), the allocator actions should be
See https://builds.apache.org/job/mesos-reviewbot/4588/changes
Changes:
[niklas] Add doc for slave_removal_rate_limit.
--
[...truncated 5606 lines...]
==
real12m7.598s
user68m20.432s
sys 5m31.141s
+
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2537/changes
We should implement something like ballooning. It can be very convenient
for such use cases.
See vmware's ballooning
http://www.vmware.com/files/pdf/perf-vsphere-memory_management.pdf for
details.
On Fri, Mar 13, 2015 at 10:53 AM, Vinod Kone vinodk...@apache.org wrote:
The only way you can
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32008/#review76398
---
LGTM
- Niklas Nielsen
On March 12, 2015, 5:10 p.m., Cody Maloney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32034/#review76387
---
src/common/type_utils.cpp
On March 10, 2015, 9:10 p.m., Niklas Nielsen wrote:
src/tests/mesos.hpp, line 1021
https://reviews.apache.org/r/31263/diff/3/?file=886222#file886222line1021
Can you reintroduce this destructor?
It is redundant, since we have a d-tor in
`mesos::master::allocator::Allocator`, but I
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32058/
---
Review request for mesos and Till Toenshoff.
Bugs: MESOS-1194
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32058/#review76439
---
Patch looks great!
Reviews applied: [32058]
All tests passed.
-
On March 13, 2015, 9:31 p.m., Kapil Arya wrote:
Can we do similar thing to libprocess?
We don't currently ship libprocess as a .so / link against it ever, so it
doesn't come up. It is treated as part of libmesos, or linked into the binaries
of the tests directly ATM.
- Cody
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32008/#review76428
---
Patch looks great!
Reviews applied: [32008]
All tests passed.
-
On March 13, 2015, 9:31 p.m., Kapil Arya wrote:
Can we do similar thing to libprocess?
Cody Maloney wrote:
We don't currently ship libprocess as a .so / link against it ever, so it
doesn't come up. It is treated as part of libmesos, or linked into the
binaries of the tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31262/
---
(Updated March 13, 2015, 9:49 p.m.)
Review request for mesos, Kapil Arya,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31267/
---
(Updated March 13, 2015, 9:48 p.m.)
Review request for mesos, Kapil Arya,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32008/#review76416
---
Ship it!
Provided builds are clean, +1
- Timothy St. Clair
On
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32008/#review76438
---
Ship it!
Can we do similar thing to libprocess?
- Kapil Arya
On
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31263/
---
(Updated March 13, 2015, 9:49 p.m.)
Review request for mesos, Kapil Arya,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31268/
---
(Updated March 13, 2015, 9:51 p.m.)
Review request for mesos, Kapil Arya,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32008/#review76420
---
Ship it!
src/Makefile.am
See https://builds.apache.org/job/mesos-reviewbot/4592/
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32008/
---
(Updated March 13, 2015, 7:55 p.m.)
Review request for mesos, Niklas Nielsen
On March 13, 2015, 5:31 p.m., Kapil Arya wrote:
Can we do similar thing to libprocess?
Cody Maloney wrote:
We don't currently ship libprocess as a .so / link against it ever, so it
doesn't come up. It is treated as part of libmesos, or linked into the
binaries of the tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31266/
---
(Updated March 13, 2015, 9:44 p.m.)
Review request for mesos, Kapil Arya,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31776/
---
(Updated March 13, 2015, 9:42 p.m.)
Review request for mesos, Kapil Arya,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31265/
---
(Updated March 13, 2015, 9:50 p.m.)
Review request for mesos, Kapil Arya,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31268/#review76451
---
Patch looks great!
Reviews applied: [31775, 31776, 31266, 31267,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31028/
---
(Updated March 13, 2015, 4:04 p.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30962/
---
(Updated March 13, 2015, 4:04 p.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31017/
---
(Updated March 13, 2015, 4:04 p.m.)
Review request for mesos and Kapil Arya.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30961/
---
(Updated March 13, 2015, 4:04 p.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31775/
---
(Updated March 13, 2015, 7:30 p.m.)
Review request for mesos, Kapil Arya,
fwiw - other systems also have attributes on the job/submission side as well as
the machine side.
The job attributes are updated every time they are evicted, and the
requirements could be adjusted by expression.
This allows for expressive steering mechanics.
Cheers,
Tim
- Original
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31324/
---
(Updated March 13, 2015, 4:19 p.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32008/#review76458
---
Ship it!
LGTM, although you should s/--as-neede/--as-needed/ in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31017/#review76460
---
Patch looks great!
Reviews applied: [30961, 30962, 31016, 31028,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31324/#review76467
---
Bad patch!
Reviews applied: [31324]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31016/
---
(Updated March 13, 2015, 4:04 p.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31838/#review76464
---
Ship it!
src/slave/slave.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31985/#review76470
---
The change looks good, but I'm not sure how exposing the container
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32002/#review76345
---
Ship it!
Mind adding it to the cherry pick doc? :) Thanks Tim!
-
On March 13, 2015, 10:52 a.m., Alexander Rojas wrote:
src/common/type_utils.cpp, lines 331-342
https://reviews.apache.org/r/31905/diff/3/?file=892475#file892475line331
This change breaks the build if using warnings as errors, since you add
a `;` and then you compare the rest of
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32034/
---
(Updated March 13, 2015, 11:56 a.m.)
Review request for mesos and Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32034/
---
(Updated March 13, 2015, 11:56 a.m.)
Review request for mesos and Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31905/#review76347
---
src/common/type_utils.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32034/
---
Review request for mesos and Till Toenshoff.
Repository: mesos
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32034/#review76352
---
Patch looks great!
Reviews applied: [32034]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32034/#review76350
---
Ship it!
Ship It!
- Till Toenshoff
On March 13, 2015, 10:56
master.cpp:2945] Registering slave at
(5434)@67.195.81.190:44892 (pietas.apache.org) with id
20150313-130624-3193029443-44892-14205-S0
I0313 13:06:24.293993 14247 authenticatee.hpp:139] Creating new client SASL
connection
I0313 13:06:24.294255 14251 master.cpp:3815] Authenticating
scheduler-7973c8d4
See https://builds.apache.org/job/mesos-reviewbot/4583/
See https://builds.apache.org/job/mesos-reviewbot/4582/changes
Changes:
[toenshoff] Fixed unused comparisons on the == operator for TaskStatus.
--
[...truncated 5609 lines...]
+ git clean -fdx
Removing .gitignore
Removing .libs/
Removing .reviewboardrc
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31977/#review76367
---
Ship it!
Ship It!
- Alexander Rojas
On March 12, 2015, 8:53
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31961/#review76368
---
Ship it!
I really like to keep those separated. Ship it!
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31985/
---
(Updated March 13, 2015, 4:20 p.m.)
Review request for mesos, Bernd Mathiske,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31986/
---
(Updated March 13, 2015, 4:21 p.m.)
Review request for mesos, Bernd Mathiske,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31960/#review76370
---
Ship it!
Ship It!
- Alexander Rojas
On March 12, 2015, 12:06
See https://builds.apache.org/job/mesos-reviewbot/4584/
--
[...truncated 5616 lines...]
Removing 3rdparty/libprocess/3rdparty/.deps/
Removing 3rdparty/libprocess/3rdparty/Makefile
Removing 3rdparty/libprocess/3rdparty/Makefile.in
Removing
See https://builds.apache.org/job/mesos-reviewbot/4585/
--
[...truncated 5694 lines...]
Removing 3rdparty/libprocess/m4/libtool.m4
Removing 3rdparty/libprocess/m4/ltoptions.m4
Removing 3rdparty/libprocess/m4/ltsugar.m4
Removing
On March 13, 2015, 9:52 a.m., Alexander Rojas wrote:
src/common/type_utils.cpp, lines 331-342
https://reviews.apache.org/r/31905/diff/3/?file=892475#file892475line331
This change breaks the build if using warnings as errors, since you add
a `;` and then you compare the rest of
On Feb. 28, 2015, 5:03 p.m., Jay Buffington wrote:
src/slave/containerizer/mesos/launch.cpp, line 262
https://reviews.apache.org/r/31444/diff/1/?file=876502#file876502line262
I was curious how you came up with this list. I did man MAKEDEV and
read this:
On March 11, 2015, 9:59 p.m., Jie Yu wrote:
src/tests/memory_test_helper.cpp, line 100
https://reviews.apache.org/r/31276/diff/4/?file=890584#file890584line100
You need a comment explaining why fsync is necessary here.
confirmed it's not needed. i likedly added during debugging :).
See https://builds.apache.org/job/mesos-reviewbot/4586/
--
[...truncated 5631 lines...]
rm -f zookeeper/*.lo
rm -rf ./.deps authentication/.deps authentication/cram_md5/.deps
authorizer/.deps cli/.deps common/.deps containerizer/.deps docker/.deps
71 matches
Mail list logo
